Skip to content
体验新版
项目
组织
正在加载...
登录
切换导航
打开侧边栏
2dot5
ClickHouse
提交
fe62b8ae
C
ClickHouse
项目概览
2dot5
/
ClickHouse
通知
3
Star
0
Fork
0
代码
文件
提交
分支
Tags
贡献者
分支图
Diff
Issue
0
列表
看板
标记
里程碑
合并请求
0
DevOps
流水线
流水线任务
计划
Wiki
0
Wiki
分析
仓库
DevOps
项目成员
Pages
C
ClickHouse
项目概览
项目概览
详情
发布
仓库
仓库
文件
提交
分支
标签
贡献者
分支图
比较
Issue
0
Issue
0
列表
看板
标记
里程碑
合并请求
0
合并请求
0
Pages
DevOps
DevOps
流水线
流水线任务
计划
分析
分析
仓库分析
DevOps
Wiki
0
Wiki
成员
成员
收起侧边栏
关闭侧边栏
动态
分支图
创建新Issue
流水线任务
提交
Issue看板
体验新版 GitCode,发现更多精彩内容 >>
提交
fe62b8ae
编写于
1月 28, 2021
作者:
R
robot-clickhouse
浏览文件
操作
浏览文件
下载
电子邮件补丁
差异文件
Backport #19763 to 20.12: Fix crash when nested column name was used in `WHERE` or `PREWHERE`
上级
af0f6952
变更
3
隐藏空白更改
内联
并排
Showing
3 changed file
with
17 addition
and
2 deletion
+17
-2
src/Interpreters/ExpressionAnalyzer.cpp
src/Interpreters/ExpressionAnalyzer.cpp
+12
-2
tests/queries/0_stateless/01674_where_prewhere_array_crash.reference
...es/0_stateless/01674_where_prewhere_array_crash.reference
+0
-0
tests/queries/0_stateless/01674_where_prewhere_array_crash.sql
.../queries/0_stateless/01674_where_prewhere_array_crash.sql
+5
-0
未找到文件。
src/Interpreters/ExpressionAnalyzer.cpp
浏览文件 @
fe62b8ae
...
...
@@ -658,7 +658,12 @@ ActionsDAGPtr SelectQueryExpressionAnalyzer::appendPrewhere(
step
.
required_output
.
push_back
(
prewhere_column_name
);
step
.
can_remove_required_output
.
push_back
(
true
);
auto
filter_type
=
(
*
step
.
actions
()
->
getIndex
().
find
(
prewhere_column_name
))
->
result_type
;
const
auto
&
index
=
step
.
actions
()
->
getIndex
();
auto
it
=
index
.
find
(
prewhere_column_name
);
if
(
it
==
index
.
end
())
throw
Exception
(
ErrorCodes
::
UNKNOWN_IDENTIFIER
,
"Unknown identifier: '{}'"
,
prewhere_column_name
);
auto
filter_type
=
(
*
it
)
->
result_type
;
if
(
!
filter_type
->
canBeUsedInBooleanContext
())
throw
Exception
(
"Invalid type for filter in PREWHERE: "
+
filter_type
->
getName
(),
ErrorCodes
::
ILLEGAL_TYPE_OF_COLUMN_FOR_FILTER
);
...
...
@@ -758,7 +763,12 @@ bool SelectQueryExpressionAnalyzer::appendWhere(ExpressionActionsChain & chain,
step
.
required_output
.
push_back
(
where_column_name
);
step
.
can_remove_required_output
=
{
true
};
auto
filter_type
=
(
*
step
.
actions
()
->
getIndex
().
find
(
where_column_name
))
->
result_type
;
const
auto
&
index
=
step
.
actions
()
->
getIndex
();
auto
it
=
index
.
find
(
where_column_name
);
if
(
it
==
index
.
end
())
throw
Exception
(
ErrorCodes
::
UNKNOWN_IDENTIFIER
,
"Unknown identifier: '{}'"
,
where_column_name
);
auto
filter_type
=
(
*
it
)
->
result_type
;
if
(
!
filter_type
->
canBeUsedInBooleanContext
())
throw
Exception
(
"Invalid type for filter in WHERE: "
+
filter_type
->
getName
(),
ErrorCodes
::
ILLEGAL_TYPE_OF_COLUMN_FOR_FILTER
);
...
...
tests/queries/0_stateless/01674_where_prewhere_array_crash.reference
0 → 100644
浏览文件 @
fe62b8ae
tests/queries/0_stateless/01674_where_prewhere_array_crash.sql
0 → 100644
浏览文件 @
fe62b8ae
drop
table
if
exists
tab
;
create
table
tab
(
x
UInt64
,
`arr.a`
Array
(
UInt64
),
`arr.b`
Array
(
UInt64
))
engine
=
MergeTree
order
by
x
;
select
x
from
tab
array
join
arr
prewhere
x
!=
0
where
arr
;
-- { serverError 47; }
select
x
from
tab
array
join
arr
prewhere
arr
where
x
!=
0
;
-- { serverError 47; }
drop
table
if
exists
tab
;
编辑
预览
Markdown
is supported
0%
请重试
或
添加新附件
.
添加附件
取消
You are about to add
0
people
to the discussion. Proceed with caution.
先完成此消息的编辑!
取消
想要评论请
注册
或
登录