enable input_format_defaults_for_omitted_fields & disable (not working)...

enable input_format_defaults_for_omitted_fields & disable (not working) defaults for table functions

dbms/programs/server/TCPHandler.cpp

@@ -382,7 +382,10 @@ void TCPHandler::processInsertQuery(const Settings & global_settings)
     {
         const auto & db_and_table = query_context->getInsertionTable();
         if (query_context->getSettingsRef().input_format_defaults_for_omitted_fields)
-            sendTableColumns(query_context->getTable(db_and_table.first, db_and_table.second)->getColumns());
+        {
+            if (!db_and_table.second.empty())
+                sendTableColumns(query_context->getTable(db_and_table.first, db_and_table.second)->getColumns());
+        }
     }
 
     /// Send block to the client - table structure.

dbms/src/Core/Settings.h

@@ -170,7 +170,7 @@ struct Settings : public SettingsCollection<Settings>
     M(SettingBool, input_format_skip_unknown_fields, false, "Skip columns with unknown names from input data (it works for JSONEachRow, CSVWithNames, TSVWithNames and TSKV formats).") \
     M(SettingBool, input_format_with_names_use_header, false, "For TSVWithNames and CSVWithNames input formats this controls whether format parser is to assume that column data appear in the input exactly as they are specified in the header.") \
     M(SettingBool, input_format_import_nested_json, false, "Map nested JSON data to nested tables (it works for JSONEachRow format).") \
-    M(SettingBool, input_format_defaults_for_omitted_fields, false, "For input data calculate default expressions for omitted fields (it works for JSONEachRow format).") \
+    M(SettingBool, input_format_defaults_for_omitted_fields, true, "For input data calculate default expressions for omitted fields (it works for JSONEachRow format).") \
     \
     M(SettingBool, input_format_values_interpret_expressions, true, "For Values format: if field could not be parsed by streaming parser, run SQL parser and try to interpret it as SQL expression.") \
     \

dbms/src/DataStreams/RemoteBlockOutputStream.cpp

@@ -50,6 +50,11 @@ RemoteBlockOutputStream::RemoteBlockOutputStream(Connection & connection_,
             if (auto log_queue = CurrentThread::getInternalTextLogsQueue())
                 log_queue->pushBlock(std::move(packet.block));
         }
+        else if (Protocol::Server::TableColumns == packet.type)
+        {
+            /// Server could attach ColumnsDescription in front of stream for column defaults. There's no need to pass it through cause
+            /// client's already got this information for remote table. Ignore.
+        }
         else
             throw NetException("Unexpected packet from server (expected Data or Exception, got "
                 + String(Protocol::Server::toString(packet.type)) + ")", ErrorCodes::UNEXPECTED_PACKET_FROM_SERVER);

dbms/src/Interpreters/executeQuery.cpp

@@ -247,7 +247,12 @@ static std::tuple<ASTPtr, BlockIO> executeQueryImpl(
             res = interpreter->execute();
 
         if (auto * insert_interpreter = typeid_cast<const InterpreterInsertQuery *>(&*interpreter))
-            context.setInsertionTable(insert_interpreter->getDatabaseTable());
+        {
+            /// Save insertion table (not table function). TODO: support remote() table function.
+            auto db_table = insert_interpreter->getDatabaseTable();
+            if (!db_table.second.empty())
+                context.setInsertionTable(std::move(db_table));
+        }
 
         if (process_list_entry)
         {