Fixed error with falsely reported large memory consumption of long running...

Fixed error with falsely reported large memory consumption of long running INSERT queries [#METR-23288].

dbms/include/DB/Common/MemoryTracker.h

@@ -86,3 +86,22 @@ public:
   * Таким образом, его нужно всего-лишь протащить во все потоки, в которых обрабатывается один запрос.
   */
 extern __thread MemoryTracker * current_memory_tracker;
+
+
+#include <boost/noncopyable.hpp>
+
+struct TemporarilyDisableMemoryTracker : private boost::noncopyable
+{
+	MemoryTracker * memory_tracker;
+
+	TemporarilyDisableMemoryTracker()
+	{
+		memory_tracker = current_memory_tracker;
+		current_memory_tracker = nullptr;
+	}
+
+	~TemporarilyDisableMemoryTracker()
+	{
+		current_memory_tracker = memory_tracker;
+	}
+};

dbms/include/DB/Interpreters/ExternalDictionaries.h

@@ -107,21 +107,7 @@ public:
 			/** During synchronous loading of external dictionaries at moment of query execution,
 			  *  we should not use per query memory limit.
 			  */
-			struct TemporarilyDisableMemoryTracker
-			{
-				MemoryTracker * memory_tracker;
-
-				TemporarilyDisableMemoryTracker()
-				{
-					memory_tracker = current_memory_tracker;
-					current_memory_tracker = nullptr;
-				}
-
-				~TemporarilyDisableMemoryTracker()
-				{
-					current_memory_tracker = memory_tracker;
-				}
-			} temporarily_disable_memory_tracker;
+			TemporarilyDisableMemoryTracker temporarily_disable_memory_tracker;
 
 			reloadImpl(throw_on_error);
 		}

dbms/include/DB/Storages/MergeTree/MergedBlockOutputStream.h

@@ -442,20 +442,30 @@ private:
 			}
 		}
 
-		/// Пишем индекс. Индекс содержит значение Primary Key для каждой index_granularity строки.
-		for (size_t i = index_offset; i < rows; i += storage.index_granularity)
 		{
-			if (storage.merging_params.mode != MergeTreeData::MergingParams::Unsorted)
+			/** While filling index (index_columns), disable memory tracker.
+			  * Because memory is allocated here (maybe in context of INSERT query),
+			  *  but then freed in completely different place (while merging parts), where query memory_tracker is not available.
+			  * And otherwise it will look like excessively growing memory consumption in context of query.
+			  *  (observed in long INSERT SELECTs)
+			  */
+			TemporarilyDisableMemoryTracker temporarily_disable_memory_tracker;
+
+			/// Пишем индекс. Индекс содержит значение Primary Key для каждой index_granularity строки.
+			for (size_t i = index_offset; i < rows; i += storage.index_granularity)
 			{
-				for (size_t j = 0, size = primary_columns.size(); j < size; ++j)
+				if (storage.merging_params.mode != MergeTreeData::MergingParams::Unsorted)
 				{
-					const IColumn & primary_column = *primary_columns[j].column.get();
-					index_columns[j].get()->insertFrom(primary_column, i);
-					primary_columns[j].type.get()->serializeBinary(primary_column, i, *index_stream);
+					for (size_t j = 0, size = primary_columns.size(); j < size; ++j)
+					{
+						const IColumn & primary_column = *primary_columns[j].column.get();
+						index_columns[j].get()->insertFrom(primary_column, i);
+						primary_columns[j].type.get()->serializeBinary(primary_column, i, *index_stream);
+					}
 				}
-			}
 
-			++marks_count;
+				++marks_count;
+			}
 		}
 
 		size_t written_for_last_mark = (storage.index_granularity - index_offset + rows) % storage.index_granularity;