未验证 提交 ef39def7 编写于 作者: A Alexander Kuzmenkov 提交者: GitHub

Apply suggestions from code review

Co-authored-by: Nfilimonov <1549571+filimonov@users.noreply.github.com>
上级 77f66e5a
...@@ -336,7 +336,7 @@ void LocalServer::processQueries() ...@@ -336,7 +336,7 @@ void LocalServer::processQueries()
throw Exception("Cannot parse and execute the following part of query: " + String(parse_res.first), ErrorCodes::SYNTAX_ERROR); throw Exception("Cannot parse and execute the following part of query: " + String(parse_res.first), ErrorCodes::SYNTAX_ERROR);
/// we can't mutate global global_context (can lead to races, as it was already passed to some background threads) /// we can't mutate global global_context (can lead to races, as it was already passed to some background threads)
/// so we can't reuse it safely as a query global_context and need a copy here /// so we can't reuse it safely as a query context and need a copy here
auto context = Context(*global_context); auto context = Context(*global_context);
context.makeSessionContext(); context.makeSessionContext();
......
...@@ -3,7 +3,7 @@ ...@@ -3,7 +3,7 @@
CURDIR=$(cd "$(dirname "${BASH_SOURCE[0]}")" && pwd) CURDIR=$(cd "$(dirname "${BASH_SOURCE[0]}")" && pwd)
. "$CURDIR"/../shell_config.sh . "$CURDIR"/../shell_config.sh
WORKING_FOLDER_01528="${CLICKHOUSE_TMP}/01527_clickhouse_local_optimize" WORKING_FOLDER_01528="${CLICKHOUSE_TMP}/01528_clickhouse_local_prepare_parts"
rm -rf "${WORKING_FOLDER_01528}" rm -rf "${WORKING_FOLDER_01528}"
mkdir -p "${WORKING_FOLDER_01528}/metadata/local" mkdir -p "${WORKING_FOLDER_01528}/metadata/local"
...@@ -80,4 +80,4 @@ ${CLICKHOUSE_LOCAL} --query "OPTIMIZE TABLE local.test FINAL;" -- --path="${WORK ...@@ -80,4 +80,4 @@ ${CLICKHOUSE_LOCAL} --query "OPTIMIZE TABLE local.test FINAL;" -- --path="${WORK
${CLICKHOUSE_LOCAL} --query "SELECT toYYYYMM(d) m, uniqExact(_part) FROM local.test GROUP BY m ORDER BY m" -- --path="${WORKING_FOLDER_01528}" ${CLICKHOUSE_LOCAL} --query "SELECT toYYYYMM(d) m, uniqExact(_part) FROM local.test GROUP BY m ORDER BY m" -- --path="${WORKING_FOLDER_01528}"
# cleanup # cleanup
rm -rf "${WORKING_FOLDER_01528}" rm -rf "${WORKING_FOLDER_01528}"
\ No newline at end of file
Markdown is supported
0% .
You are about to add 0 people to the discussion. Proceed with caution.
先完成此消息的编辑!
想要评论请 注册