Merge pull request #11182 from 4ertus2/some

Remove stale unit-test

programs/CMakeLists.txt

@@ -207,7 +207,7 @@ if (TARGET clickhouse-server AND TARGET copy-headers)
 endif ()
 
 if (ENABLE_TESTS AND USE_GTEST)
-    set (CLICKHOUSE_ALL_TESTS_TARGETS local_date_time_comparison unit_tests_libcommon unit_tests_dbms hashing_write_buffer hashing_read_buffer in_join_subqueries_preprocessor expression_analyzer)
+    set (CLICKHOUSE_ALL_TESTS_TARGETS local_date_time_comparison unit_tests_libcommon unit_tests_dbms hashing_write_buffer hashing_read_buffer in_join_subqueries_preprocessor)
     add_custom_target (clickhouse-tests ALL DEPENDS ${CLICKHOUSE_ALL_TESTS_TARGETS})
     add_dependencies(clickhouse-bundle clickhouse-tests)
 endif()

src/Interpreters/tests/CMakeLists.txt

@@ -51,10 +51,6 @@ add_executable (in_join_subqueries_preprocessor in_join_subqueries_preprocessor.
 target_link_libraries (in_join_subqueries_preprocessor PRIVATE dbms clickhouse_parsers)
 add_check(in_join_subqueries_preprocessor)
 
-add_executable (expression_analyzer expression_analyzer.cpp)
-target_link_libraries (expression_analyzer PRIVATE dbms clickhouse_storages_system clickhouse_parsers clickhouse_common_io)
-add_check(expression_analyzer)
-
 add_executable (users users.cpp)
 target_link_libraries (users PRIVATE dbms clickhouse_common_config)
 

src/Interpreters/tests/expression_analyzer.cpp

-#include <DataTypes/DataTypesNumber.h>
-
-#include <Storages/System/StorageSystemOne.h>
-#include <Storages/System/StorageSystemNumbers.h>
-#include <Databases/DatabaseMemory.h>
-
-#include <Parsers/ParserSelectQuery.h>
-#include <Parsers/parseQuery.h>
-
-#include <Interpreters/Context.h>
-#include <Interpreters/SyntaxAnalyzer.h>
-
-#include <IO/WriteBufferFromFileDescriptor.h>
-#include <IO/ReadBufferFromFileDescriptor.h>
-
-#include <vector>
-#include <unordered_map>
-#include <iostream>
-
-
-using namespace DB;
-
-namespace DB
-{
-    namespace ErrorCodes
-    {
-        extern const int SYNTAX_ERROR;
-    }
-}
-
-struct TestEntry
-{
-    String query;
-    std::unordered_map<String, String> expected_aliases; /// alias -> AST.getID()
-    NamesAndTypesList source_columns = {};
-
-    bool check(const Context & context)
-    {
-        ASTPtr ast = parse(query);
-
-        auto res = SyntaxAnalyzer(context).analyze(ast, source_columns);
-        return checkAliases(*res);
-    }
-
-private:
-    bool checkAliases(const SyntaxAnalyzerResult & res)
-    {
-        for (const auto & alias : res.aliases)
-        {
-            const String & alias_name = alias.first;
-            if (expected_aliases.count(alias_name) == 0 ||
-                expected_aliases[alias_name] != alias.second->getID())
-            {
-                std::cout << "unexpected alias: " << alias_name << ' ' << alias.second->getID() << std::endl;
-                return false;
-            }
-            else
-                expected_aliases.erase(alias_name);
-        }
-
-        if (!expected_aliases.empty())
-        {
-            std::cout << "missing aliases: " << expected_aliases.size() << std::endl;
-            return false;
-        }
-
-        return true;
-    }
-
-    static ASTPtr parse(const std::string & query)
-    {
-        ParserSelectQuery parser;
-        std::string message;
-        const auto * text = query.data();
-        if (ASTPtr ast = tryParseQuery(parser, text, text + query.size(), message, false, "", false, 0, 0))
-            return ast;
-        throw Exception(message, ErrorCodes::SYNTAX_ERROR);
-    }
-};
-
-
-int main()
-{
-    std::vector<TestEntry> queries =
-    {
-        {
-            "SELECT number AS n FROM system.numbers LIMIT 0",
-            {{"n", "Identifier_number"}},
-            { NameAndTypePair("number", std::make_shared<DataTypeUInt64>()) }
-        },
-
-        {
-            "SELECT number AS n FROM system.numbers LIMIT 0",
-            {{"n", "Identifier_number"}}
-        }
-    };
-
-    SharedContextHolder shared_context = Context::createShared();
-    Context context = Context::createGlobal(shared_context.get());
-    context.makeGlobalContext();
-
-    auto system_database = std::make_shared<DatabaseMemory>("system");
-    DatabaseCatalog::instance().attachDatabase("system", system_database);
-    //context.setCurrentDatabase("system");
-    system_database->attachTable("one", StorageSystemOne::create("one"), {});
-    system_database->attachTable("numbers", StorageSystemNumbers::create(StorageID("system", "numbers"), false), {});
-
-    size_t success = 0;
-    for (auto & entry : queries)
-    {
-        try
-        {
-            if (entry.check(context))
-            {
-                ++success;
-                std::cout << "[OK] " << entry.query << std::endl;
-            }
-            else
-                std::cout << "[Failed] " << entry.query << std::endl;
-        }
-        catch (Exception & e)
-        {
-            std::cout << "[Error] " << entry.query << std::endl << e.displayText() << std::endl;
-        }
-    }
-
-    return success != queries.size();
-}