Merge pull request #12292 from ClickHouse/fix-typo

Fix typo in setting name

src/Core/Settings.h

@@ -369,7 +369,7 @@ struct Settings : public SettingsCollection<Settings>
     M(SettingBool, optimize_move_functions_out_of_any, true, "Move functions out of aggregate functions 'any', 'anyLast'.", 0) \
     M(SettingBool, optimize_arithmetic_operations_in_aggregate_functions, true, "Move arithmetic operations out of aggregation functions", 0) \
     M(SettingBool, optimize_duplicate_order_by_and_distinct, true, "Remove duplicate ORDER BY and DISTINCT if it's possible", 0) \
-    M(SettingBool, optimize_if_chain_to_miltiif, false, "Replace if(cond1, then1, if(cond2, ...)) chains to multiIf. Currently it's not beneficial for numeric types.", 0) \
+    M(SettingBool, optimize_if_chain_to_multiif, false, "Replace if(cond1, then1, if(cond2, ...)) chains to multiIf. Currently it's not beneficial for numeric types.", 0) \
     M(SettingBool, allow_experimental_alter_materialized_view_structure, false, "Allow atomic alter on Materialized views. Work in progress.", 0) \
     M(SettingBool, enable_early_constant_folding, true, "Enable query optimization where we analyze function and subqueries results and rewrite query if there're constants there", 0) \
     \

src/Interpreters/SyntaxAnalyzer.cpp

@@ -578,12 +578,12 @@ void optimizeUsing(const ASTSelectQuery * select_query)
         expression_list = uniq_expressions_list;
 }
 
-void optimizeIf(ASTPtr & query, Aliases & aliases, bool if_chain_to_miltiif)
+void optimizeIf(ASTPtr & query, Aliases & aliases, bool if_chain_to_multiif)
 {
     /// Optimize if with constant condition after constants was substituted instead of scalar subqueries.
     OptimizeIfWithConstantConditionVisitor(aliases).visit(query);
 
-    if (if_chain_to_miltiif)
+    if (if_chain_to_multiif)
         OptimizeIfChainsVisitor().visit(query);
 }
 
@@ -978,7 +978,7 @@ SyntaxAnalyzerResultPtr SyntaxAnalyzer::analyzeSelect(
     executeScalarSubqueries(query, context, subquery_depth, result.scalars, select_options.only_analyze);
 
     {
-        optimizeIf(query, result.aliases, settings.optimize_if_chain_to_miltiif);
+        optimizeIf(query, result.aliases, settings.optimize_if_chain_to_multiif);
 
         /// Move arithmetic operations out of aggregation functions
         if (settings.optimize_arithmetic_operations_in_aggregate_functions)
@@ -1055,7 +1055,7 @@ SyntaxAnalyzerResultPtr SyntaxAnalyzer::analyze(
     /// Executing scalar subqueries. Column defaults could be a scalar subquery.
     executeScalarSubqueries(query, context, 0, result.scalars, false);
 
-    optimizeIf(query, result.aliases, settings.optimize_if_chain_to_miltiif);
+    optimizeIf(query, result.aliases, settings.optimize_if_chain_to_multiif);
 
     if (allow_aggregations)
     {

src/Storages/tests/gtest_SplitTokenExtractor.cpp

@@ -35,7 +35,7 @@ public:
     {
         const auto & param = GetParam();
         const auto & source = param.source;
-        data = std::make_unique<PaddedPODArray<const char>>(source.data(), source.data() + source.size());
+        data = std::make_unique<PaddedPODArray<char>>(source.data(), source.data() + source.size());
 
         // add predefined padding that forms tokens to ensure no reads past end of buffer.
         const char extra_padding[] = "this is the end \xd1\x8d\xd1\x82\xd0\xbe\xd0\xba\xd0\xbe \xd0\xbd\xd0\xb5\xd1\x86";
@@ -44,7 +44,7 @@ public:
         data->resize(data->size() - sizeof(extra_padding));
     }
 
-    std::unique_ptr<PaddedPODArray<const char>> data;
+    std::unique_ptr<PaddedPODArray<char>> data;
 };
 
 TEST_P(SplitTokenExtractorTest, next)

tests/queries/0_stateless/01388_multi_if_optimization.reference

+SELECT if(number = 1, \'hello\', if(number = 2, \'world\', \'xyz\'))
+FROM numbers(10)
+SELECT multiIf(number = 1, \'hello\', number = 2, \'world\', \'xyz\')
+FROM numbers(10)

tests/queries/0_stateless/01388_multi_if_optimization.sql

+-- If you are reading this test please note that as of now this setting does not provide benefits in most of the cases.
+SET optimize_if_chain_to_multiif = 0;
+EXPLAIN SYNTAX SELECT number = 1 ? 'hello' : (number = 2 ? 'world' : 'xyz') FROM numbers(10);
+SET optimize_if_chain_to_multiif = 1;
+EXPLAIN SYNTAX SELECT number = 1 ? 'hello' : (number = 2 ? 'world' : 'xyz') FROM numbers(10);