🔧 correct type cast for LCM result

e0f981f4 · Maks Skorokhod · a6f17071 · e0f981f4
隐藏空白更改
内联并排

Showing with 8 addition and 8 deletion

dbms/src/Functions/FunctionsArithmetic.h dbms/src/Functions/FunctionsArithmetic.h +8 -8

未找到文件。
--- a/dbms/src/Functions/FunctionsArithmetic.h
+++ b/dbms/src/Functions/FunctionsArithmetic.h
@@ -441,11 +441,11 @@ struct GCDImpl
    template <typename Result = ResultType>
    static inline Result apply(A a, B b)
    {
-        throwIfDivisionLeadsToFPE(typename NumberTraits::ToInteger<A>::Type(a), typename NumberTraits::ToInteger<A>::Type(b));
-        throwIfDivisionLeadsToFPE(typename NumberTraits::ToInteger<A>::Type(b), typename NumberTraits::ToInteger<A>::Type(a));
+        throwIfDivisionLeadsToFPE(typename NumberTraits::ToInteger<A>::Type(a), typename NumberTraits::ToInteger<B>::Type(b));
+        throwIfDivisionLeadsToFPE(typename NumberTraits::ToInteger<B>::Type(b), typename NumberTraits::ToInteger<A>::Type(a));
        return boost::math::gcd(
-            typename NumberTraits::ToInteger<A>::Type(a),
-            typename NumberTraits::ToInteger<A>::Type(b));
+            typename NumberTraits::ToInteger<Result>::Type(a),
+            typename NumberTraits::ToInteger<Result>::Type(b));
    }
 };

@@ -457,11 +457,11 @@ struct LCMImpl
    template <typename Result = ResultType>
    static inline Result apply(A a, B b)
    {
-        throwIfDivisionLeadsToFPE(typename NumberTraits::ToInteger<A>::Type(a), typename NumberTraits::ToInteger<A>::Type(b));
-        throwIfDivisionLeadsToFPE(typename NumberTraits::ToInteger<A>::Type(b), typename NumberTraits::ToInteger<A>::Type(a));
+        throwIfDivisionLeadsToFPE(typename NumberTraits::ToInteger<A>::Type(a), typename NumberTraits::ToInteger<B>::Type(b));
+        throwIfDivisionLeadsToFPE(typename NumberTraits::ToInteger<B>::Type(b), typename NumberTraits::ToInteger<A>::Type(a));
        return boost::math::lcm(
-            typename NumberTraits::ToInteger<A>::Type(a),
-            typename NumberTraits::ToInteger<A>::Type(b));
+            typename NumberTraits::ToInteger<Result>::Type(a),
+            typename NumberTraits::ToInteger<Result>::Type(b));
    }
 };