Merge pull request #14455 from ClickHouse/prepare-clang-11

Prepare for clang 11

contrib/capnproto-cmake/CMakeLists.txt

@@ -74,10 +74,9 @@ target_link_libraries(capnpc PUBLIC capnp)
 
 # The library has substandard code
 if (COMPILER_GCC)
-    set (SUPPRESS_WARNINGS -Wno-non-virtual-dtor -Wno-sign-compare -Wno-strict-aliasing -Wno-maybe-uninitialized
-        -Wno-deprecated-declarations -Wno-class-memaccess)
+    set (SUPPRESS_WARNINGS -w)
 elseif (COMPILER_CLANG)
-    set (SUPPRESS_WARNINGS -Wno-non-virtual-dtor -Wno-sign-compare -Wno-strict-aliasing -Wno-deprecated-declarations)
+    set (SUPPRESS_WARNINGS -w)
     set (CAPNP_PRIVATE_CXX_FLAGS -fno-char8_t)
 endif ()
 

src/Common/ZooKeeper/ZooKeeperImpl.cpp

@@ -424,7 +424,7 @@ void ZooKeeperRequest::write(WriteBuffer & out) const
 
 struct ZooKeeperResponse : virtual Response
 {
-    virtual ~ZooKeeperResponse() = default;
+    virtual ~ZooKeeperResponse() override = default;
     virtual void readImpl(ReadBuffer &) = 0;
 };
 

src/Common/ZooKeeper/ZooKeeperImpl.h

@@ -260,7 +260,7 @@ struct ZooKeeperRequest : virtual Request
 
     ZooKeeperRequest() = default;
     ZooKeeperRequest(const ZooKeeperRequest &) = default;
-    virtual ~ZooKeeperRequest() = default;
+    virtual ~ZooKeeperRequest() override = default;
 
     virtual ZooKeeper::OpNum getOpNum() const = 0;
 

src/Core/MySQL/MySQLReplication.h

@@ -499,7 +499,7 @@ namespace MySQLReplication
         virtual BinlogEventPtr readOneEvent() = 0;
         virtual void setReplicateDatabase(String db) = 0;
         virtual void setGTIDSets(GTIDSets sets) = 0;
-        virtual ~IFlavor() = default;
+        virtual ~IFlavor() override = default;
     };
 
     class MySQLFlavor : public IFlavor

src/Functions/GatherUtils/Sources.h

@@ -122,9 +122,15 @@ struct NumericArraySource : public ArraySourceImpl<NumericArraySource<T>>
     }
 };
 
+
+/// The methods can be virtual or not depending on the template parameter. See IStringSource.
 #if !__clang__
-#pragma GCC diagnostic push
-#pragma GCC diagnostic ignored "-Wsuggest-override"
+    #pragma GCC diagnostic push
+    #pragma GCC diagnostic ignored "-Wsuggest-override"
+#elif __clang_major__ >= 11
+    #pragma GCC diagnostic push
+    #pragma GCC diagnostic ignored "-Wsuggest-override"
+    #pragma GCC diagnostic ignored "-Wsuggest-destructor-override"
 #endif
 
 template <typename Base>
@@ -205,7 +211,7 @@ struct ConstSource : public Base
     }
 };
 
-#if !__clang__
+#if !__clang__ || __clang_major__ >= 11
 #pragma GCC diagnostic pop
 #endif