提交 93890423 编写于 作者: A Alexey Milovidov

Fixed zero-width spaces [#CLICKHOUSE-3].

find dbms -name '*.h' -or -name '*.cpp' | xargs grep -l $'\xe2\x80\x8b' | xargs sed -i 's/'$'\xe2\x80\x8b''//g'
上级 edd405ef
......@@ -46,14 +46,14 @@ ColumnPtr ColumnAggregateFunction::convertToValues() const
* Due to the presence of WITH TOTALS, during aggregation the states of this aggregate function will be stored
* in the ColumnAggregateFunction column of type
* AggregateFunction(quantileTimingState(0.5), UInt64).
* Then, in `TotalsHavingBlockInputStream`, it will be called `convertToValues` ​​method,
* Then, in `TotalsHavingBlockInputStream`, it will be called `convertToValues` method,
* to get the "ready" values.
* But it just converts a column of type
* `AggregateFunction(quantileTimingState(0.5), UInt64)`
* into `AggregateFunction(quantileTiming(0.5), UInt64)`
* - in the same states.
*
* Then `finalizeAggregation` function will be calculated, which will call `convertToValues` ​​already on the result.
* Then `finalizeAggregation` function will be calculated, which will call `convertToValues` already on the result.
* And this converts a column of type
* AggregateFunction(quantileTiming(0.5), UInt64)
* into UInt16 - already finished result of `quantileTiming`.
......
......@@ -214,7 +214,7 @@ void report(const char * name, size_t n, double elapsed, UInt64 tsc_diff, size_t
template <size_t Func(UInt64)>
static inline void test(size_t n, const UInt64 * data, const char * name)
{
/// throughput. Calculations of hash functions from different values ​​may overlap.
/// throughput. Calculations of hash functions from different values may overlap.
{
Stopwatch watch;
......
......@@ -17,7 +17,7 @@ namespace ErrorCodes
}
/// Write values ​​in binary form. NOTE: You could use protobuf, but it would be overkill for this case.
/// Write values in binary form. NOTE: You could use protobuf, but it would be overkill for this case.
void BlockInfo::write(WriteBuffer & out) const
{
/// Set of pairs `FIELD_NUM`, value in binary form. Then 0.
......@@ -31,7 +31,7 @@ void BlockInfo::write(WriteBuffer & out) const
writeVarUInt(0, out);
}
/// Read values ​​in binary form.
/// Read values in binary form.
void BlockInfo::read(ReadBuffer & in)
{
UInt64 field_num = 0;
......
......@@ -8,7 +8,7 @@ void AddingDefaultBlockOutputStream::write(const DB::Block & block)
{
Block res = block;
/// Computes explicitly specified values ​​(in column_defaults) by default.
/// Computes explicitly specified values (in column_defaults) by default.
/** @todo if somehow block does not contain values for implicitly-defaulted columns that are prerequisites
* for explicitly-defaulted ones, exception will be thrown during evaluating such columns
* (implicitly-defaulted columns are evaluated on the line after following one. */
......
......@@ -100,7 +100,7 @@ void AggregatingSortedBlockInputStream::merge(ColumnPlainPtrs & merged_columns,
{
current_key.swap(next_key);
/// We will write the data for the group. We copy the values ​​of ordinary columns.
/// We will write the data for the group. We copy the values of ordinary columns.
for (size_t i = 0, size = column_numbers_not_to_aggregate.size(); i < size; ++i)
{
size_t j = column_numbers_not_to_aggregate[i];
......
......@@ -232,7 +232,7 @@ void GraphiteRollupSortedBlockInputStream::startNextRow(ColumnPlainPtrs & merged
void GraphiteRollupSortedBlockInputStream::finishCurrentRow(ColumnPlainPtrs & merged_columns)
{
/// Insert calculated values ​​of the columns `time`, `value`, `version`.
/// Insert calculated values of the columns `time`, `value`, `version`.
merged_columns[time_column_num]->insert(UInt64(current_time_rounded));
merged_columns[version_column_num]->insert(current_max_version);
......
......@@ -68,7 +68,7 @@ bool JSONEachRowRowInputStream::read(Block & block)
size_t columns = block.columns();
/// Set of columns for which the values ​​were read. The rest will be filled with default values.
/// Set of columns for which the values were read. The rest will be filled with default values.
/// TODO Ability to provide your DEFAULTs.
bool read_columns[columns];
memset(read_columns, 0, columns);
......
......@@ -101,7 +101,7 @@ void PrettyBlockOutputStream::write(const Block & block_)
return;
}
/// We will insert here columns with the calculated values ​​of visible lengths.
/// We will insert here columns with the calculated values of visible lengths.
Block block = block_;
size_t rows = block.rows();
......
......@@ -118,7 +118,7 @@ void PrettyCompactBlockOutputStream::write(const Block & block_)
return;
}
/// We will insert columns here with the calculated values ​​of visible lengths.
/// We will insert columns here with the calculated values of visible lengths.
Block block = block_;
size_t rows = block.rows();
......
......@@ -15,7 +15,7 @@ void PrettySpaceBlockOutputStream::write(const Block & block_)
return;
}
/// We will insert here columns with the calculated values ​​of visible lengths.
/// We will insert here columns with the calculated values of visible lengths.
Block block = block_;
size_t rows = block.rows();
......
......@@ -92,7 +92,7 @@ bool TSKVRowInputStream::read(Block & block)
size_t columns = block.columns();
/// Set of columns for which the values ​​were read. The rest will be filled with default values.
/// Set of columns for which the values were read. The rest will be filled with default values.
/// TODO Ability to provide your DEFAULTs.
bool read_columns[columns];
memset(read_columns, 0, columns);
......
......@@ -86,7 +86,7 @@ Block TotalsHavingBlockInputStream::readImpl()
{
block = children[0]->read();
/// Block with values ​​not included in `max_rows_to_group_by`. We'll postpone it.
/// Block with values not included in `max_rows_to_group_by`. We'll postpone it.
if (overflow_row && block && block.info.is_overflows)
{
overflow_aggregates = block;
......@@ -125,7 +125,7 @@ Block TotalsHavingBlockInputStream::readImpl()
IColumn::Filter & filter = filter_column->getData();
/// Add values ​​to `totals` (if it was not already done).
/// Add values to `totals` (if it was not already done).
if (totals_mode == TotalsMode::BEFORE_HAVING)
addToTotals(current_totals, block, nullptr);
else
......
......@@ -69,7 +69,7 @@ struct AssociativeOperationImpl
AssociativeOperationImpl(UInt8ColumnPtrs & in)
: vec(in[in.size() - N]->getData()), continuation(in) {}
/// Returns a combination of values ​​in the i-th row of all columns stored in the constructor.
/// Returns a combination of values in the i-th row of all columns stored in the constructor.
inline UInt8 apply(size_t i) const
{
//return vec[i] ? continuation.apply(i) : 0;
......
Markdown is supported
0% .
You are about to add 0 people to the discussion. Proceed with caution.
先完成此消息的编辑!
想要评论请 注册