Merge pull request #4748 from yandex/adding_thread_sanitizer

Add clang-8 build

docker/packager/binary/Dockerfile

 FROM ubuntu:18.04
 
 RUN echo "deb [trusted=yes] http://apt.llvm.org/bionic/ llvm-toolchain-bionic-7 main" >> /etc/apt/sources.list
+RUN echo "deb [trusted=yes] http://apt.llvm.org/bionic/ llvm-toolchain-bionic-8 main" >> /etc/apt/sources.list
 
 RUN apt-get update -y \
     && env DEBIAN_FRONTEND=noninteractive \
@@ -23,6 +24,10 @@ RUN apt-get update -y \
             lld-7 \
             libclang-7-dev \
             liblld-7-dev \
+            clang-8 \
+            lld-8 \
+            libclang-8-dev \
+            liblld-8-dev \
             libicu-dev \
             libreadline-dev \
             ninja-build \

docker/packager/deb/Dockerfile

 FROM ubuntu:18.04
 
 RUN echo "deb [trusted=yes] http://apt.llvm.org/bionic/ llvm-toolchain-bionic-7 main" >> /etc/apt/sources.list
+RUN echo "deb [trusted=yes] http://apt.llvm.org/bionic/ llvm-toolchain-bionic-8 main" >> /etc/apt/sources.list
 
 RUN apt-get --allow-unauthenticated update -y \
     && env DEBIAN_FRONTEND=noninteractive \
@@ -24,6 +25,10 @@ RUN apt-get --allow-unauthenticated update -y \
             lld-7 \
             libclang-7-dev \
             liblld-7-dev \
+            clang-8 \
+            lld-8 \
+            libclang-8-dev \
+            liblld-8-dev \
             libicu-dev \
             libreadline-dev \
             ninja-build \

docker/packager/packager

@@ -146,7 +146,7 @@ if __name__ == "__main__":
     parser.add_argument("--clickhouse-repo-path", default="../../")
     parser.add_argument("--output-dir", required=True)
     parser.add_argument("--build-type", choices=("debug", ""), default="")
-    parser.add_argument("--compiler", choices=("clang-6.0", "clang-7", "gcc-7", "gcc-8"), default="gcc-7")
+    parser.add_argument("--compiler", choices=("clang-6.0", "clang-7", "gcc-7", "clang-8", "gcc-8"), default="gcc-7")
     parser.add_argument("--sanitizer", choices=("address", "thread", "memory", "undefined", ""), default="")
     parser.add_argument("--unbundled", action="store_true")
     parser.add_argument("--split-binary", action="store_true")

docker/test/integration/Dockerfile

 FROM ubuntu:18.04
 
-RUN apt-get update && apt-get -y install tzdata python
+RUN apt-get update && apt-get -y install tzdata python llvm-6.0 llvm-6.0-dev
 
 ENV TZ=Europe/Moscow
 RUN ln -snf /usr/share/zoneinfo/$TZ /etc/localtime && echo $TZ > /etc/timezone
+
+CMD echo "TSAN_OPTIONS='halt_on_error=1'" >> /etc/environment;
+CMD echo "UBSAN_OPTIONS='print_stacktrace=1'" >> /etc/environment;
+CMD echo "ASAN_SYMBOLIZER_PATH=/usr/lib/llvm-6.0/bin/llvm-symbolizer" >> /etc/environment;
+CMD echo "UBSAN_SYMBOLIZER_PATH=/usr/lib/llvm-6.0/bin/llvm-symbolizer" >> /etc/environment;
+CMD echo "LLVM_SYMBOLIZER_PATH=/usr/lib/llvm-6.0/bin/llvm-symbolizer" >> /etc/environment;

docker/test/stateful/Dockerfile

@@ -13,6 +13,11 @@ CMD dpkg -i package_folder/clickhouse-common-static_*.deb; \
     dpkg -i package_folder/clickhouse-server_*.deb;  \
     dpkg -i package_folder/clickhouse-client_*.deb; \
     dpkg -i package_folder/clickhouse-test_*.deb; \
+    echo "TSAN_OPTIONS='halt_on_error=1'" >> /etc/environment; \
+    echo "UBSAN_OPTIONS='print_stacktrace=1'" >> /etc/environment; \
+    echo "ASAN_SYMBOLIZER_PATH=/usr/lib/llvm-6.0/bin/llvm-symbolizer" >> /etc/environment; \
+    echo "UBSAN_SYMBOLIZER_PATH=/usr/lib/llvm-6.0/bin/llvm-symbolizer" >> /etc/environment; \
+    echo "LLVM_SYMBOLIZER_PATH=/usr/lib/llvm-6.0/bin/llvm-symbolizer" >> /etc/environment; \
     service zookeeper start; sleep 5; \
     service clickhouse-server start && sleep 5 \
     && /s3downloader --dataset-names $DATASETS \