Merge pull request #5528 from infinivision/fix_bitmapHasAny

Fix bitmapHasAny segment fault

dbms/src/Functions/FunctionsBitmap.h

@@ -55,6 +55,12 @@ namespace ErrorCodes
   *
   * Two bitmap andnot calculation, return cardinality:
   * bitmapAndnotCardinality: bitmap,bitmap -> integer
+  *
+  * Judge if a bitmap is superset of the another one:
+  * bitmapHasAll: bitmap,bitmap -> bool
+  *
+  * Judge if the intersection of two bitmap is nonempty:
+  * bitmapHasAny: bitmap,bitmap -> bool
   */
 
 template <typename Name>
@@ -430,20 +436,32 @@ private:
         Block & block, const ColumnNumbers & arguments, size_t input_rows_count, typename ColumnVector<ToType>::Container & vec_to)
     {
         const ColumnAggregateFunction * columns[2];
+        bool isColumnConst[2];
         for (size_t i = 0; i < 2; ++i)
         {
-            if (auto argument_column_const = typeid_cast<const ColumnConst *>(block.getByPosition(arguments[i]).column.get()))
-                columns[i] = typeid_cast<const ColumnAggregateFunction *>(argument_column_const->getDataColumnPtr().get());
+            if (auto argument_column_const = typeid_cast<const ColumnConst*>(block.getByPosition(arguments[i]).column.get()))
+            {
+                columns[i] = typeid_cast<const ColumnAggregateFunction*>(argument_column_const->getDataColumnPtr().get());
+                isColumnConst[i] = true;
+            }
             else
-                columns[i] = typeid_cast<const ColumnAggregateFunction *>(block.getByPosition(arguments[i]).column.get());
+            {
+                columns[i] = typeid_cast<const ColumnAggregateFunction*>(block.getByPosition(arguments[i]).column.get());
+                isColumnConst[i] = false;
+            }
         }
 
+        const PaddedPODArray<AggregateDataPtr> & container0 = columns[0]->getData();
+        const PaddedPODArray<AggregateDataPtr> & container1 = columns[1]->getData();
+
         for (size_t i = 0; i < input_rows_count; ++i)
         {
+            const AggregateDataPtr dataPtr0 = isColumnConst[0] ? container0[0] : container0[i];
+            const AggregateDataPtr dataPtr1 = isColumnConst[1] ? container1[0] : container1[i];
             const AggregateFunctionGroupBitmapData<T> & bd1
-                = *reinterpret_cast<const AggregateFunctionGroupBitmapData<T> *>(columns[0]->getData()[i]);
+                = *reinterpret_cast<const AggregateFunctionGroupBitmapData<T>*>(dataPtr0);
             const AggregateFunctionGroupBitmapData<T> & bd2
-                = *reinterpret_cast<const AggregateFunctionGroupBitmapData<T> *>(columns[1]->getData()[i]);
+                = *reinterpret_cast<const AggregateFunctionGroupBitmapData<T>*>(dataPtr1);
             vec_to[i] = Impl<T>::apply(bd1, bd2);
         }
     }

dbms/tests/queries/0_stateless/00829_bitmap_function.reference

@@ -15,6 +15,9 @@
 2019-01-02	60	[11,12,13,14,15,16,17,18,19,20,21,22,23,24,25,26,27,28,29,30,31,32,33,34,35,36,37,38,39,40,41,42,43,44,45,46,47,48,49,50,51,52,53,54,55,56,57,58,59,60,61,62,63,64,65,66,67,68,69,70]
 60	50	70	40	20	30
 60	50	70	40	20	30
+90
+90
+20
 2019-01-01	50
 2019-01-02	60
 1

dbms/tests/queries/0_stateless/00829_bitmap_function.sql

@@ -56,6 +56,12 @@ ALL LEFT JOIN
 )
 USING city_id;
 
+SELECT count(*) FROM bitmap_test WHERE bitmapHasAny((SELECT groupBitmapState(uid) FROM bitmap_test WHERE pickup_date = '2019-01-01'), bitmapBuild([uid]));
+
+SELECT count(*) FROM bitmap_test WHERE bitmapHasAny(bitmapBuild([uid]), (SELECT groupBitmapState(uid) FROM bitmap_test WHERE pickup_date = '2019-01-01'));
+
+SELECT count(*) FROM bitmap_test WHERE 0 = bitmapHasAny((SELECT groupBitmapState(uid) FROM bitmap_test WHERE pickup_date = '2019-01-01'), bitmapBuild([uid]));
+
 -- bitmap state test
 DROP TABLE IF EXISTS bitmap_state_test;
 CREATE TABLE bitmap_state_test