Merge pull request #16048 from ClickHouse/materialized-view-check-stack-size

Fix possible stack overflow in materialized views.

src/DataStreams/PushingToViewsBlockOutputStream.cpp

@@ -10,6 +10,7 @@
 #include <Common/CurrentThread.h>
 #include <Common/setThreadName.h>
 #include <Common/ThreadPool.h>
+#include <Common/checkStackSize.h>
 #include <Storages/MergeTree/ReplicatedMergeTreeBlockOutputStream.h>
 #include <Storages/StorageValues.h>
 #include <Storages/LiveView/StorageLiveView.h>
@@ -29,6 +30,8 @@ PushingToViewsBlockOutputStream::PushingToViewsBlockOutputStream(
     , context(context_)
     , query_ptr(query_ptr_)
 {
+    checkStackSize();
+
     /** TODO This is a very important line. At any insertion into the table one of streams should own lock.
       * Although now any insertion into the table is done via PushingToViewsBlockOutputStream,
       *  but it's clear that here is not the best place for this functionality.

src/Storages/StorageMaterializedView.cpp

@@ -21,6 +21,7 @@
 #include <Storages/SelectQueryDescription.h>
 
 #include <Common/typeid_cast.h>
+#include <Common/checkStackSize.h>
 #include <Processors/Sources/SourceFromInputStream.h>
 #include <Processors/QueryPlan/SettingQuotaAndLimitsStep.h>
 
@@ -30,6 +31,7 @@ namespace DB
 
 namespace ErrorCodes
 {
+    extern const int BAD_ARGUMENTS;
     extern const int NOT_IMPLEMENTED;
     extern const int INCORRECT_QUERY;
     extern const int QUERY_IS_NOT_SUPPORTED_IN_MATERIALIZED_VIEW;
@@ -72,7 +74,11 @@ StorageMaterializedView::StorageMaterializedView(
     setInMemoryMetadata(storage_metadata);
 
     if (!has_inner_table)
+    {
+        if (query.to_table_id.database_name == table_id_.database_name && query.to_table_id.table_name == table_id_.table_name)
+            throw Exception(ErrorCodes::BAD_ARGUMENTS, "Materialized view {} cannot point to itself", table_id_.getFullTableName());
         target_table_id = query.to_table_id;
+    }
     else if (attach_)
     {
         /// If there is an ATTACH request, then the internal table must already be created.
@@ -351,11 +357,13 @@ void StorageMaterializedView::shutdown()
 
 StoragePtr StorageMaterializedView::getTargetTable() const
 {
+    checkStackSize();
     return DatabaseCatalog::instance().getTable(target_table_id, global_context);
 }
 
 StoragePtr StorageMaterializedView::tryGetTargetTable() const
 {
+    checkStackSize();
     return DatabaseCatalog::instance().tryGetTable(target_table_id, global_context);
 }
 

tests/queries/0_stateless/01527_materialized_view_stack_overflow.sql

+DROP TABLE IF EXISTS t;
+DROP TABLE IF EXISTS v;
+
+CREATE TABLE t (c String) ENGINE = Memory;
+
+CREATE MATERIALIZED VIEW v to v AS SELECT c FROM t; -- { serverError 36 }
+CREATE MATERIALIZED VIEW v to t AS SELECT * FROM v; -- { serverError 60 }
+
+DROP TABLE IF EXISTS t1;
+DROP TABLE IF EXISTS t2;
+DROP TABLE IF EXISTS v1;
+DROP TABLE IF EXISTS v2;
+
+CREATE TABLE t1 (c String) ENGINE = Memory;
+CREATE TABLE t2 (c String) ENGINE = Memory;
+
+CREATE MATERIALIZED VIEW v1 to t1 AS SELECT * FROM t2;
+CREATE MATERIALIZED VIEW v2 to t2 AS SELECT * FROM t1;
+
+INSERT INTO t1 VALUES ('Hello'); -- { serverError 306 }
+INSERT INTO t2 VALUES ('World'); -- { serverError 306 }
+
+DROP TABLE IF EXISTS t;
+DROP TABLE IF EXISTS v;
+DROP TABLE IF EXISTS t1;
+DROP TABLE IF EXISTS t2;
+DROP TABLE IF EXISTS v1;
+DROP TABLE IF EXISTS v2;