Merge pull request #14340 from ClickHouse/backport/20.6/14326

Backport #14326 to 20.6: Throw exception on alter for storages created from table functions

src/Databases/DatabaseOrdinary.cpp

@@ -33,6 +33,11 @@ static constexpr size_t PRINT_MESSAGE_EACH_N_OBJECTS = 256;
 static constexpr size_t PRINT_MESSAGE_EACH_N_SECONDS = 5;
 static constexpr size_t METADATA_FILE_BUFFER_SIZE = 32768;
 
+namespace ErrorCodes
+{
+    extern const int NOT_IMPLEMENTED;
+}
+
 namespace
 {
     void tryAttachTable(
@@ -250,6 +255,9 @@ void DatabaseOrdinary::alterTable(const Context & context, const StorageID & tab
 
     auto & ast_create_query = ast->as<ASTCreateQuery &>();
 
+    if (ast_create_query.as_table_function)
+        throw Exception(ErrorCodes::NOT_IMPLEMENTED, "Cannot alter table {} because it was created AS table function", backQuote(table_name));
+
     ASTPtr new_columns = InterpreterCreateQuery::formatColumns(metadata.columns);
     ASTPtr new_indices = InterpreterCreateQuery::formatIndices(metadata.secondary_indices);
     ASTPtr new_constraints = InterpreterCreateQuery::formatConstraints(metadata.constraints);

tests/queries/0_stateless/01461_alter_table_function.reference

+CREATE TABLE default.table_from_remote AS remote(\'localhost\', \'system\', \'numbers\')
+CREATE TABLE default.table_from_remote AS remote(\'localhost\', \'system\', \'numbers\')
+CREATE TABLE default.table_from_numbers AS numbers(1000)
+CREATE TABLE default.table_from_numbers AS numbers(1000)
+CREATE TABLE default.table_from_select\n(\n    `number` UInt64\n)\nENGINE = MergeTree()\nORDER BY tuple()\nSETTINGS index_granularity = 8192
+CREATE TABLE default.table_from_select\n(\n    `number` UInt64,\n    `col` UInt8\n)\nENGINE = MergeTree()\nORDER BY tuple()\nSETTINGS index_granularity = 8192
+1

tests/queries/0_stateless/01461_alter_table_function.sql

+DROP TABLE IF EXISTS table_from_remote;
+DROP TABLE IF EXISTS table_from_select;
+DROP TABLE IF EXISTS table_from_numbers;
+
+CREATE TABLE table_from_remote AS remote('localhost', 'system', 'numbers');
+
+SHOW CREATE TABLE table_from_remote;
+
+ALTER TABLE table_from_remote ADD COLUMN col UInt8; --{serverError 48}
+
+SHOW CREATE TABLE table_from_remote;
+
+CREATE TABLE table_from_numbers AS numbers(1000);
+
+SHOW CREATE TABLE table_from_numbers;
+
+ALTER TABLE table_from_numbers ADD COLUMN col UInt8; --{serverError 48}
+
+SHOW CREATE TABLE table_from_numbers;
+
+CREATE TABLE table_from_select ENGINE = MergeTree() ORDER BY tuple() AS SELECT number from system.numbers LIMIT 1;
+
+SHOW CREATE TABLE table_from_select;
+
+ALTER TABLE table_from_select ADD COLUMN col UInt8;
+
+SHOW CREATE TABLE table_from_select;
+
+SELECT 1;
+
+DROP TABLE IF EXISTS table_from_remote;
+DROP TABLE IF EXISTS table_from_select;
+DROP TABLE IF EXISTS table_from_numbers;