Fix banch of flapping perf tests. Improve average speed calculation

dbms/programs/performance-test/TestStats.cpp

 #include "TestStats.h"
+#include <algorithm>
 namespace DB
 {
 
@@ -92,11 +93,10 @@ void TestStats::update_average_speed(
     avg_speed_value /= number_of_info_batches;
 
     if (avg_speed_first == 0)
-    {
         avg_speed_first = avg_speed_value;
-    }
 
-    if (std::abs(avg_speed_value - avg_speed_first) >= precision)
+    auto [min, max] = std::minmax(avg_speed_value, avg_speed_first);
+    if (1 - min / max >= precision)
     {
         avg_speed_first = avg_speed_value;
         avg_speed_watch.restart();

dbms/programs/performance-test/TestStats.h

@@ -40,11 +40,11 @@ struct TestStats
 
     double avg_rows_speed_value = 0;
     double avg_rows_speed_first = 0;
-    static inline double avg_rows_speed_precision = 0.001;
+    static inline double avg_rows_speed_precision = 0.005;
 
     double avg_bytes_speed_value = 0;
     double avg_bytes_speed_first = 0;
-    static inline double avg_bytes_speed_precision = 0.001;
+    static inline double avg_bytes_speed_precision = 0.005;
 
     size_t number_of_rows_speed_info_batches = 0;
     size_t number_of_bytes_speed_info_batches = 0;

dbms/tests/performance/array_element.xml

@@ -4,8 +4,8 @@
 
     <stop_conditions>
         <any_of>
-            <average_speed_not_changing_for_ms>10000</average_speed_not_changing_for_ms>
-            <total_time_ms>1000</total_time_ms>
+            <average_speed_not_changing_for_ms>1000</average_speed_not_changing_for_ms>
+            <total_time_ms>10000</total_time_ms>
         </any_of>
     </stop_conditions>
 

dbms/tests/performance/array_join.xml

@@ -4,8 +4,8 @@
 
     <stop_conditions>
         <any_of>
-            <average_speed_not_changing_for_ms>10000</average_speed_not_changing_for_ms>
-            <total_time_ms>1000</total_time_ms>
+            <average_speed_not_changing_for_ms>1000</average_speed_not_changing_for_ms>
+            <total_time_ms>10000</total_time_ms>
         </any_of>
     </stop_conditions>
 

dbms/tests/performance/complex_array_creation.xml

@@ -4,8 +4,8 @@
 
     <stop_conditions>
         <any_of>
-            <average_speed_not_changing_for_ms>10000</average_speed_not_changing_for_ms>
-            <total_time_ms>1000</total_time_ms>
+            <average_speed_not_changing_for_ms>1000</average_speed_not_changing_for_ms>
+            <total_time_ms>10000</total_time_ms>
         </any_of>
     </stop_conditions>
 

dbms/tests/performance/conditional.xml

@@ -5,8 +5,8 @@
 
     <stop_conditions>
         <any_of>
-            <average_speed_not_changing_for_ms>10000</average_speed_not_changing_for_ms>
-            <total_time_ms>1000</total_time_ms>
+            <average_speed_not_changing_for_ms>1000</average_speed_not_changing_for_ms>
+            <total_time_ms>10000</total_time_ms>
         </any_of>
     </stop_conditions>
 

dbms/tests/performance/consistent_hashes.xml

@@ -4,7 +4,7 @@
 
     <stop_conditions>
         <any_of>
-            <min_time_not_changing_for_ms>1000</min_time_not_changing_for_ms>
+            <max_speed_not_changing_for_ms>1000</max_speed_not_changing_for_ms>
             <total_time_ms>5000</total_time_ms>
         </any_of>
     </stop_conditions>

dbms/tests/performance/date_time.xml

@@ -9,8 +9,8 @@
 
     <stop_conditions>
         <any_of>
-            <average_speed_not_changing_for_ms>10000</average_speed_not_changing_for_ms>
-            <total_time_ms>1000</total_time_ms>
+            <average_speed_not_changing_for_ms>1000</average_speed_not_changing_for_ms>
+            <total_time_ms>10000</total_time_ms>
         </any_of>
     </stop_conditions>
 

dbms/tests/performance/format_date_time.xml

@@ -8,8 +8,8 @@
 
     <stop_conditions>
         <any_of>
-            <average_speed_not_changing_for_ms>10000</average_speed_not_changing_for_ms>
-            <total_time_ms>1000</total_time_ms>
+            <average_speed_not_changing_for_ms>1000</average_speed_not_changing_for_ms>
+            <total_time_ms>10000</total_time_ms>
         </any_of>
     </stop_conditions>
 

dbms/tests/performance/functions_coding.xml

@@ -4,8 +4,8 @@
 
     <stop_conditions>
         <any_of>
-            <average_speed_not_changing_for_ms>10000</average_speed_not_changing_for_ms>
-            <total_time_ms>1000</total_time_ms>
+            <average_speed_not_changing_for_ms>5000</average_speed_not_changing_for_ms>
+            <total_time_ms>20000</total_time_ms>
         </any_of>
     </stop_conditions>
 

dbms/tests/performance/if_array_num.xml

@@ -4,8 +4,8 @@
 
     <stop_conditions>
         <any_of>
-            <average_speed_not_changing_for_ms>10000</average_speed_not_changing_for_ms>
-            <total_time_ms>1000</total_time_ms>
+            <average_speed_not_changing_for_ms>1000</average_speed_not_changing_for_ms>
+            <total_time_ms>10000</total_time_ms>
         </any_of>
     </stop_conditions>
 

dbms/tests/performance/if_array_string.xml

@@ -4,8 +4,8 @@
 
     <stop_conditions>
         <any_of>
-            <average_speed_not_changing_for_ms>10000</average_speed_not_changing_for_ms>
-            <total_time_ms>1000</total_time_ms>
+            <average_speed_not_changing_for_ms>1000</average_speed_not_changing_for_ms>
+            <total_time_ms>10000</total_time_ms>
         </any_of>
     </stop_conditions>
 

dbms/tests/performance/if_string_const.xml

@@ -4,8 +4,8 @@
 
     <stop_conditions>
         <any_of>
-            <average_speed_not_changing_for_ms>10000</average_speed_not_changing_for_ms>
-            <total_time_ms>1000</total_time_ms>
+            <average_speed_not_changing_for_ms>1000</average_speed_not_changing_for_ms>
+            <total_time_ms>10000</total_time_ms>
         </any_of>
     </stop_conditions>
 

dbms/tests/performance/simple_join_query.xml

@@ -8,7 +8,7 @@
             <total_time_ms>30000</total_time_ms>
         </all_of>
         <any_of>
-            <min_time_not_changing_for_ms>5000</min_time_not_changing_for_ms>
+            <max_speed_not_changing_for_ms>5000</max_speed_not_changing_for_ms>
             <total_time_ms>60000</total_time_ms>
         </any_of>
     </stop_conditions>

dbms/tests/performance/system_numbers.xml

@@ -5,8 +5,8 @@
     <stop_conditions>
         <any_of>
             <!-- This is only for infinite running query. -->
-            <average_speed_not_changing_for_ms>10000</average_speed_not_changing_for_ms>
-            <total_time_ms>1000</total_time_ms>
+            <average_speed_not_changing_for_ms>1000</average_speed_not_changing_for_ms>
+            <total_time_ms>10000</total_time_ms>
         </any_of>
     </stop_conditions>
 

dbms/tests/performance/uniq.xml

@@ -13,7 +13,7 @@
         </all_of>
         <any_of>
             <average_speed_not_changing_for_ms>5000</average_speed_not_changing_for_ms>
-            <total_time_ms>15000</total_time_ms>
+            <total_time_ms>20000</total_time_ms>
         </any_of>
     </stop_conditions>
 

dbms/tests/performance/visit_param_extract_raw.xml

@@ -4,8 +4,8 @@
 
     <stop_conditions>
         <any_of>
-            <average_speed_not_changing_for_ms>10000</average_speed_not_changing_for_ms>
-            <total_time_ms>1000</total_time_ms>
+            <average_speed_not_changing_for_ms>1000</average_speed_not_changing_for_ms>
+            <total_time_ms>10000</total_time_ms>
         </any_of>
     </stop_conditions>