Merge pull request #7153 from 4ertus2/some

Try to fix some PVS false positives

dbms/src/AggregateFunctions/AggregateFunctionSumMap.h

@@ -111,7 +111,7 @@ public:
                 using IteratorType = typename MapType::iterator;
 
                 array_column.getData().get(values_vec_offset + i, value);
-                const auto & key = keys_vec.getData()[keys_vec_offset + i];
+                const auto & key = keys_vec.getElement(keys_vec_offset + i);
 
                 if (!keepKey(key))
                 {

dbms/src/AggregateFunctions/AggregateFunctionUniq.h

@@ -171,7 +171,7 @@ struct OneAdder
         {
             if constexpr (!std::is_same_v<T, String>)
             {
-                const auto & value = assert_cast<const ColumnVector<T> &>(column).getData()[row_num];
+                const auto & value = assert_cast<const ColumnVector<T> &>(column).getElement(row_num);
                 data.set.insert(AggregateFunctionUniqTraits<T>::hash(value));
             }
             else

dbms/src/AggregateFunctions/AggregateFunctionUniqCombined.h

@@ -132,7 +132,7 @@ public:
     {
         if constexpr (!std::is_same_v<T, String>)
         {
-            const auto & value = assert_cast<const ColumnVector<T> &>(*columns[0]).getData()[row_num];
+            const auto & value = assert_cast<const ColumnVector<T> &>(*columns[0]).getElement(row_num);
             this->data(place).set.insert(detail::AggregateFunctionUniqCombinedTraits<T>::hash(value));
         }
         else

dbms/src/DataTypes/DataTypesDecimal.cpp

@@ -111,7 +111,7 @@ void DataTypeDecimal<T>::serializeBinary(const Field & field, WriteBuffer & ostr
 template <typename T>
 void DataTypeDecimal<T>::serializeBinary(const IColumn & column, size_t row_num, WriteBuffer & ostr) const
 {
-    const FieldType & x = assert_cast<const ColumnType &>(column).getData()[row_num];
+    const FieldType & x = assert_cast<const ColumnType &>(column).getElement(row_num);
     writeBinary(x, ostr);
 }
 

dbms/src/Interpreters/CollectJoinOnKeysVisitor.h

@@ -23,7 +23,7 @@ public:
         const NameSet & source_columns;
         const NameSet & joined_columns;
         const Aliases & aliases;
-        const bool is_asof;
+        const bool is_asof{false};
         ASTPtr asof_left_key{};
         ASTPtr asof_right_key{};
         bool has_some{false};