Fix compiler warnings about unused options (#1542)

* Lib Parsers

* Update parseIdentifierOrStringLiteral.h

* Freebsd fix

* Try fix warnings

* fix

* libc++ test

* Core/Progress.h -> IO/Progress.h

* Core/FieldVisitors.h -> Common/FieldVisitors.h

* Fix link tests

* Fix freebsd link

* tests: sudo --non-interactive

CMakeLists.txt

@@ -123,15 +123,6 @@ if (ARCHNATIVE)
     set (COMPILER_FLAGS                  "${COMPILER_FLAGS} -march=native")
 endif ()
 
-if (CMAKE_SYSTEM MATCHES "Linux" AND CMAKE_CXX_COMPILER_ID STREQUAL "Clang")
-    option (USE_LIBCXX "Use libc++ and libc++abi instead of libstdc++ (only make sense on Linux with Clang)" ON)
-    if (USE_LIBCXX)
-        set (COMPILER_FLAGS              "${COMPILER_FLAGS} -pthread") # NOTE: Why this is not the default and why this is needed only with libc++?
-        set (CMAKE_CXX_FLAGS             "${CMAKE_CXX_FLAGS} -stdlib=libc++")
-        set (CMAKE_CXX_FLAGS_DEBUG       "${CMAKE_CXX_FLAGS_DEBUG} -D_LIBCPP_DEBUG=1") # More checks in debug build.
-    endif ()
-endif ()
-
 # Special options for better optimized code with clang
 #if (CMAKE_CXX_COMPILER_ID STREQUAL "Clang")
 #    set (CMAKE_CXX_FLAGS_RELWITHDEBINFO  "${CMAKE_CXX_FLAGS_RELWITHDEBINFO} -Wno-unused-command-line-argument -mllvm -inline-threshold=10000")
@@ -156,16 +147,23 @@ set (CMAKE_C_FLAGS                       "${CMAKE_C_FLAGS} ${COMPILER_FLAGS} -fn
 set (CMAKE_C_FLAGS_RELWITHDEBINFO        "${CMAKE_C_FLAGS_RELWITHDEBINFO} -O3")
 set (CMAKE_C_FLAGS_DEBUG                 "${CMAKE_C_FLAGS_DEBUG} -O0 -g3 -ggdb3 -fno-inline")
 
-if (NOT APPLE AND NOT (CMAKE_CXX_COMPILER_ID STREQUAL "Clang" AND CMAKE_SYSTEM MATCHES "FreeBSD"))
-    set (CMAKE_EXE_LINKER_FLAGS          "${CMAKE_EXE_LINKER_FLAGS} -static-libgcc")
-    set (CMAKE_EXE_LINKER_FLAGS          "${CMAKE_EXE_LINKER_FLAGS} -static-libstdc++")
+if (MAKE_STATIC_LIBRARIES AND NOT APPLE AND NOT (CMAKE_CXX_COMPILER_ID STREQUAL "Clang" AND CMAKE_SYSTEM MATCHES "FreeBSD"))
+    set (CMAKE_EXE_LINKER_FLAGS          "${CMAKE_EXE_LINKER_FLAGS} -static-libgcc -static-libstdc++")
 endif ()
 
-if (NOT APPLE)
+if (CMAKE_SYSTEM MATCHES "Linux" AND CMAKE_CXX_COMPILER_ID STREQUAL "Clang")
     set (CMAKE_EXE_LINKER_FLAGS          "${CMAKE_EXE_LINKER_FLAGS} ${GLIBC_COMPATIBILITY_LINK_FLAGS} ${CXX11_ABI_FLAGS}")
 
-    if (USE_LIBCXX AND (CMAKE_CXX_COMPILER_ID STREQUAL "Clang"))
-        link_libraries (-Wl,-Bstatic -stdlib=libc++ c++ c++abi -Wl,-Bdynamic)
+    option (USE_LIBCXX "Use libc++ and libc++abi instead of libstdc++ (only make sense on Linux with Clang)" ${HAVE_LIBCPP})
+    if (USE_LIBCXX)
+        set (CMAKE_CXX_FLAGS_DEBUG       "${CMAKE_CXX_FLAGS_DEBUG} -D_LIBCPP_DEBUG=1") # More checks in debug build.
+        if (CMAKE_CXX_COMPILER_ID STREQUAL "Clang")
+            if (MAKE_STATIC_LIBRARIES)
+                link_libraries (-Wl,-Bstatic -stdlib=libc++ c++ c++abi -Wl,-Bdynamic)
+            else ()
+                link_libraries (-stdlib=libc++ c++ c++abi)
+            endif ()
+        endif ()
     endif ()
 endif ()
 
@@ -278,9 +276,10 @@ include (libs/libdaemon/cmake/find_unwind.cmake)
 
 set (FULL_C_FLAGS "${CMAKE_C_FLAGS} ${CMAKE_C_FLAGS_${CMAKE_BUILD_TYPE_UC}}")
 set (FULL_CXX_FLAGS "${CMAKE_CXX_FLAGS} ${CMAKE_CXX_FLAGS_${CMAKE_BUILD_TYPE_UC}}")
-message (STATUS "C_FLAGS    = ${FULL_C_FLAGS}")
-message (STATUS "CXX_FLAGS  = ${FULL_CXX_FLAGS}")
-message (STATUS "LINK_FLAGS = ${CMAKE_EXE_LINKER_FLAGS}")
+set (FULL_EXE_LINKER_FLAGS "${CMAKE_EXE_LINKER_FLAGS} ${CMAKE_EXE_LINKER_FLAGS_${CMAKE_BUILD_TYPE_UC}}")
+message (STATUS "C_FLAGS      = ${FULL_C_FLAGS}")
+message (STATUS "CXX_FLAGS    = ${FULL_CXX_FLAGS}")
+message (STATUS "LINKER_FLAGS = ${FULL_EXE_LINKER_FLAGS}")
 
 # Directory for Yandex specific files
 set (CLICKHOUSE_PRIVATE_DIR ${ClickHouse_SOURCE_DIR}/private/)

cmake/test_compiler.cmake

 include (CheckCXXSourceCompiles)
 include (CMakePushCheckState)
 
+cmake_push_check_state ()
+
 if (CMAKE_CXX_COMPILER_ID STREQUAL "Clang")
 # clang4 : -no-pie cause error
 # clang6 : -no-pie cause warning
+
+
+    set (TEST_FLAG "-lc++ -lc++abi")
+    set (CMAKE_REQUIRED_FLAGS "${TEST_FLAG}")
+
+    check_cxx_source_compiles("
+        #include <iostream>
+        int main() {
+            std::cerr << std::endl;
+            return 0;
+        }
+        " HAVE_LIBCPP)
+
 else ()
 
     cmake_push_check_state ()
@@ -21,6 +36,7 @@ else ()
         set (FLAG_NO_PIE ${TEST_FLAG})
     endif ()
 
-    cmake_pop_check_state ()
 
 endif ()
+
+cmake_pop_check_state ()