Preparations, part 6 [#CLICKHOUSE-31].

dbms/src/TableFunctions/ITableFunction.h

@@ -32,7 +32,7 @@ public:
     virtual std::string getName() const = 0;
 
     /// Create storage according to the query
-    virtual StoragePtr execute(ASTPtr ast_function, const Context & context) const = 0;
+    virtual StoragePtr execute(const ASTPtr & ast_function, const Context & context) const = 0;
 
     virtual ~ITableFunction() {};
 };

dbms/src/TableFunctions/TableFunctionMerge.cpp

@@ -53,7 +53,7 @@ static NamesAndTypesList chooseColumns(const String & source_database, const Str
 }
 
 
-StoragePtr TableFunctionMerge::execute(ASTPtr ast_function, const Context & context) const
+StoragePtr TableFunctionMerge::execute(const ASTPtr & ast_function, const Context & context) const
 {
     ASTs & args_func = typeid_cast<ASTFunction &>(*ast_function).children;
 

dbms/src/TableFunctions/TableFunctionMerge.h

@@ -14,7 +14,7 @@ class TableFunctionMerge: public ITableFunction
 {
 public:
     std::string getName() const override { return "merge"; }
-    StoragePtr execute(ASTPtr ast_function, const Context & context) const override;
+    StoragePtr execute(const ASTPtr & ast_function, const Context & context) const override;
 };
 
 

dbms/src/TableFunctions/TableFunctionRemote.cpp

@@ -179,7 +179,7 @@ static std::vector<String> parseDescription(const String & description, size_t l
 }
 
 
-StoragePtr TableFunctionRemote::execute(ASTPtr ast_function, const Context & context) const
+StoragePtr TableFunctionRemote::execute(const ASTPtr & ast_function, const Context & context) const
 {
     ASTs & args_func = typeid_cast<ASTFunction &>(*ast_function).children;
 

dbms/src/TableFunctions/TableFunctionRemote.h

@@ -16,7 +16,7 @@ class TableFunctionRemote : public ITableFunction
 {
 public:
     std::string getName() const override { return "remote"; }
-    StoragePtr execute(ASTPtr ast_function, const Context & context) const override;
+    StoragePtr execute(const ASTPtr & ast_function, const Context & context) const override;
 };
 
 }

dbms/src/TableFunctions/TableFunctionShardByHash.cpp

@@ -20,7 +20,7 @@ namespace ErrorCodes
     extern const int BAD_ARGUMENTS;
 }
 
-StoragePtr TableFunctionShardByHash::execute(ASTPtr ast_function, const Context & context) const
+StoragePtr TableFunctionShardByHash::execute(const ASTPtr & ast_function, const Context & context) const
 {
     ASTs & args_func = typeid_cast<ASTFunction &>(*ast_function).children;
 

dbms/src/TableFunctions/TableFunctionShardByHash.h

@@ -15,7 +15,7 @@ class TableFunctionShardByHash : public ITableFunction
 {
 public:
     std::string getName() const override { return "shardByHash"; }
-    StoragePtr execute(ASTPtr ast_function, const Context & context) const override;
+    StoragePtr execute(const ASTPtr & ast_function, const Context & context) const override;
 };
 
 }