Merge pull request #10791 from oandrew/key-condition-source-type

Use src_type for conversion in KeyCondition

(cherry picked from commit a1333895)

src/Storages/MergeTree/KeyCondition.cpp

@@ -741,8 +741,7 @@ static void castValueToType(const DataTypePtr & desired_type, Field & src_value,
 
     try
     {
-        /// NOTE: We don't need accurate info about src_type at this moment
-        src_value = convertFieldToType(src_value, *desired_type);
+        src_value = convertFieldToType(src_value, *desired_type, src_type.get());
     }
     catch (...)
     {

tests/queries/1_stateful/00155_date_datetime_key_condition.reference

+['2020-01-01 10:00:00']
+['2020-01-02 00:00:00']
+['2020-01-01 00:00:00','2020-01-01 10:00:00']
+['2020-01-01 00:00:00','2020-01-01 10:00:00','2020-01-02 00:00:00']
+['2020-01-01 00:00:00','2020-01-01 10:00:00','2020-01-02 00:00:00']
+['2020-01-01 00:00:00','2020-01-01 10:00:00','2020-01-02 00:00:00']
+['2020-01-01 00:00:00','2020-01-01 10:00:00','2020-01-02 00:00:00']
+[]
+[]
+[]

tests/queries/1_stateful/00155_date_datetime_key_condition.sql

+DROP TABLE IF EXISTS test.date_datetime_key_condition;
+
+CREATE TABLE test.date_datetime_key_condition (dt DateTime) ENGINE = MergeTree() ORDER BY dt;
+INSERT INTO test.date_datetime_key_condition VALUES ('2020-01-01 00:00:00'), ('2020-01-01 10:00:00'), ('2020-01-02 00:00:00');
+
+-- partial
+SELECT groupArray(dt) from test.date_datetime_key_condition WHERE dt > toDate('2020-01-01') AND dt < toDate('2020-01-02');
+SELECT groupArray(dt) from test.date_datetime_key_condition WHERE dt >= toDate('2020-01-02');
+SELECT groupArray(dt) from test.date_datetime_key_condition WHERE dt < toDate('2020-01-02');
+
+-- inside
+SELECT groupArray(dt) from test.date_datetime_key_condition WHERE dt > toDate('2019-01-02');
+SELECT groupArray(dt) from test.date_datetime_key_condition WHERE dt < toDate('2021-01-02');
+SELECT groupArray(dt) from test.date_datetime_key_condition WHERE dt >= toDate('2019-01-02') AND dt < toDate('2021-01-02');
+SELECT groupArray(dt) from test.date_datetime_key_condition WHERE dt > toDate('2019-01-02') OR dt <= toDate('2021-01-02');
+
+-- outside 
+SELECT groupArray(dt) from test.date_datetime_key_condition WHERE dt < toDate('2019-01-02');
+SELECT groupArray(dt) from test.date_datetime_key_condition WHERE dt > toDate('2021-01-02');
+SELECT groupArray(dt) from test.date_datetime_key_condition WHERE dt < toDate('2019-01-02') OR dt > toDate('2021-01-02');
+
+DROP TABLE test.date_datetime_key_condition;
\ No newline at end of file