Build fixes (#4516)

cmake/find_gtest.cmake

@@ -19,6 +19,7 @@ endif()
 if (NOT GTEST_SRC_DIR AND NOT GTEST_INCLUDE_DIRS AND NOT MISSING_INTERNAL_GTEST_LIBRARY)
     set (USE_INTERNAL_GTEST_LIBRARY 1)
     set (GTEST_MAIN_LIBRARIES gtest_main)
+    set (GTEST_LIBRARIES gtest)
     set (GTEST_INCLUDE_DIRS ${ClickHouse_SOURCE_DIR}/contrib/googletest/googletest)
 endif ()
 
@@ -26,4 +27,4 @@ if((GTEST_INCLUDE_DIRS AND GTEST_MAIN_LIBRARIES) OR GTEST_SRC_DIR)
     set(USE_GTEST 1)
 endif()
 
-message (STATUS "Using gtest=${USE_GTEST}: ${GTEST_INCLUDE_DIRS} : ${GTEST_MAIN_LIBRARIES} : ${GTEST_SRC_DIR}")
+message (STATUS "Using gtest=${USE_GTEST}: ${GTEST_INCLUDE_DIRS} : ${GTEST_LIBRARIES}, ${GTEST_MAIN_LIBRARIES} : ${GTEST_SRC_DIR}")

dbms/src/Formats/ProtobufReader.h

@@ -202,30 +202,30 @@ class ProtobufReader
 public:
     bool startMessage() { return false; }
     void endMessage() {}
-    bool readColumnIndex(size_t & column_index) { return false; }
-    bool readNumber(Int8 & value) { return false; }
-    bool readNumber(UInt8 & value) { return false; }
-    bool readNumber(Int16 & value) { return false; }
-    bool readNumber(UInt16 & value) { return false; }
-    bool readNumber(Int32 & value) { return false; }
-    bool readNumber(UInt32 & value) { return false; }
-    bool readNumber(Int64 & value) { return false; }
-    bool readNumber(UInt64 & value) { return false; }
-    bool readNumber(UInt128 & value) { return false; }
-    bool readNumber(Float32 & value) { return false; }
-    bool readNumber(Float64 & value) { return false; }
-    bool readStringInto(PaddedPODArray<UInt8> & str) { return false; }
-    void prepareEnumMapping(const std::vector<std::pair<std::string, Int8>> & name_value_pairs) {}
-    void prepareEnumMapping(const std::vector<std::pair<std::string, Int16>> & name_value_pairs) {}
-    bool readEnum(Int8 & value) { return false; }
-    bool readEnum(Int16 & value) { return false; }
-    bool readUUID(UUID & uuid) { return false; }
-    bool readDate(DayNum & date) { return false; }
-    bool readDateTime(time_t & tm) { return false; }
-    bool readDecimal(Decimal32 & decimal, UInt32 precision, UInt32 scale) { return false; }
-    bool readDecimal(Decimal64 & decimal, UInt32 precision, UInt32 scale) { return false; }
-    bool readDecimal(Decimal128 & decimal, UInt32 precision, UInt32 scale) { return false; }
-    bool readAggregateFunction(const AggregateFunctionPtr & function, AggregateDataPtr place, Arena & arena) { return false; }
+    bool readColumnIndex(size_t &) { return false; }
+    bool readNumber(Int8 &) { return false; }
+    bool readNumber(UInt8 &) { return false; }
+    bool readNumber(Int16 &) { return false; }
+    bool readNumber(UInt16 &) { return false; }
+    bool readNumber(Int32 &) { return false; }
+    bool readNumber(UInt32 &) { return false; }
+    bool readNumber(Int64 &) { return false; }
+    bool readNumber(UInt64 &) { return false; }
+    bool readNumber(UInt128 &) { return false; }
+    bool readNumber(Float32 &) { return false; }
+    bool readNumber(Float64 &) { return false; }
+    bool readStringInto(PaddedPODArray<UInt8> &) { return false; }
+    void prepareEnumMapping(const std::vector<std::pair<std::string, Int8>> &) {}
+    void prepareEnumMapping(const std::vector<std::pair<std::string, Int16>> &) {}
+    bool readEnum(Int8 &) { return false; }
+    bool readEnum(Int16 &) { return false; }
+    bool readUUID(UUID &) { return false; }
+    bool readDate(DayNum &) { return false; }
+    bool readDateTime(time_t &) { return false; }
+    bool readDecimal(Decimal32 &, UInt32, UInt32) { return false; }
+    bool readDecimal(Decimal64 &, UInt32, UInt32) { return false; }
+    bool readDecimal(Decimal128 &, UInt32, UInt32) { return false; }
+    bool readAggregateFunction(const AggregateFunctionPtr &, AggregateDataPtr, Arena &) { return false; }
     bool maybeCanReadValue() const { return false; }
 };
 

dbms/src/Formats/ProtobufRowInputStream.cpp

@@ -87,7 +87,7 @@ void registerInputFormatProtobuf(FormatFactory & factory)
 namespace DB
 {
 class FormatFactory;
-void registerInputFormatProtobuf(FormatFactory & factory) {}
+void registerInputFormatProtobuf(FormatFactory &) {}
 }
 
 #endif

libs/libcommon/src/tests/CMakeLists.txt

@@ -21,7 +21,7 @@ add_check(local_date_time_comparison)
 
 if(USE_GTEST)
     add_executable(unit_tests_libcommon gtest_json_test.cpp gtest_strong_typedef.cpp gtest_find_symbols.cpp)
-    target_link_libraries(unit_tests_libcommon common ${GTEST_MAIN_LIBRARIES})
+    target_link_libraries(unit_tests_libcommon common ${GTEST_MAIN_LIBRARIES} ${GTEST_LIBRARIES})
     add_check(unit_tests_libcommon)
 endif()