Merge pull request #14320 from bharatnc/ncb/fix-alter-live-lock

 fix ALTER LIVE VIEW  [REFRESH] lock issue 

src/Interpreters/InterpreterAlterQuery.cpp

@@ -101,7 +101,7 @@ BlockIO InterpreterAlterQuery::execute()
             switch (command.type)
             {
                 case LiveViewCommand::REFRESH:
-                    live_view->refresh(context);
+                    live_view->refresh();
                     break;
             }
         }

src/Storages/LiveView/StorageLiveView.cpp

@@ -518,9 +518,10 @@ void StorageLiveView::drop()
     condition.notify_all();
 }
 
-void StorageLiveView::refresh(const Context & context)
+void StorageLiveView::refresh()
 {
-    auto table_lock = lockExclusively(context.getCurrentQueryId(), context.getSettingsRef().lock_acquire_timeout);
+    // Lock is already acquired exclusively from InterperterAlterQuery.cpp InterpreterAlterQuery::execute() method.
+    // So, reacquiring lock is not needed and will result in an exception.
     {
         std::lock_guard lock(mutex);
         if (getNewBlocks())

src/Storages/LiveView/StorageLiveView.h

@@ -122,7 +122,7 @@ public:
     void startup() override;
     void shutdown() override;
 
-    void refresh(const Context & context);
+    void refresh();
 
     Pipe read(
         const Names & column_names,

tests/queries/0_stateless/01463_test_alter_live_view_refresh.reference

+ALTER LIVE VIEW live1 REFRESH

tests/queries/0_stateless/01463_test_alter_live_view_refresh.sql

+CREATE TABLE test0 (
+        c0 UInt64
+    ) ENGINE = MergeTree() PARTITION BY c0 ORDER BY c0;
+
+SET allow_experimental_live_view=1;
+
+CREATE LIVE VIEW live1 AS SELECT * FROM test0;
+
+select 'ALTER LIVE VIEW live1 REFRESH';
+ALTER LIVE VIEW live1 REFRESH; -- success