Add user-friendly error message in optimizer ops to give a hint about the...

Add user-friendly error message in optimizer ops to give a hint about the position sensitive problem of run(startup_program) (#19605)

* add extra error message hint in optimizer ops

* polish format & delete useless change, test=develop

* extract init judue from shape compare, test=develop

paddle/fluid/operators/optimizers/adadelta_op.cc

@@ -56,6 +56,11 @@ class AdadeltaOp : public framework::OperatorWithKernel {
     PADDLE_ENFORCE_EQ(
         param_dim, ctx->GetInputDim("Grad"),
         "param and grad input of AdadeltaOp should have same dimension");
+    PADDLE_ENFORCE_NE(framework::product(ctx->GetInputDim("AvgSquaredGrad")), 0,
+                      "Maybe the Input variable AvgSquaredGrad has not "
+                      "been initialized. You may need to confirm if you put "
+                      "exe.run(startup_program) after optimizer.minimize "
+                      "function.");
     PADDLE_ENFORCE_EQ(param_dim, ctx->GetInputDim("AvgSquaredGrad"),
                       "Param and AvgSquaredGrad input of AdadeltaOp "
                       "should have same dimension");

paddle/fluid/operators/optimizers/adagrad_op.cc

@@ -44,6 +44,11 @@ class AdagradOp : public framework::OperatorWithKernel {
                    "Output(MomentOut) of AdagradOp should not be null.");
 
     auto lr_dims = ctx->GetInputDim("LearningRate");
+    PADDLE_ENFORCE_NE(framework::product(lr_dims), 0,
+                      "Maybe the Input variable LearningRate has not "
+                      "been initialized. You may need to confirm "
+                      "if you put exe.run(startup_program) "
+                      "after optimizer.minimize function.");
     PADDLE_ENFORCE_EQ(framework::product(lr_dims), 1,
                       "LearningRate should have one element");
     auto param_dims = ctx->GetInputDim("Param");

paddle/fluid/operators/optimizers/adam_op.cc

@@ -43,6 +43,11 @@ void AdamOp::InferShape(framework::InferShapeContext* ctx) const {
                  "Output(Moment2Out) of AdamOp should not be null.");
 
   auto lr_dims = ctx->GetInputDim("LearningRate");
+  PADDLE_ENFORCE_NE(framework::product(lr_dims), 0,
+                    "Maybe the Input variable LearningRate has not "
+                    "been initialized. You may need to confirm "
+                    "if you put exe.run(startup_program) "
+                    "after optimizer.minimize function.");
   PADDLE_ENFORCE_EQ(framework::product(lr_dims), 1,
                     "Learning rate should have 1 dimension");
   auto beta1_pow_dims = ctx->GetInputDim("Beta1Pow");

paddle/fluid/operators/optimizers/adamax_op.cc

@@ -54,6 +54,11 @@ class AdamaxOp : public framework::OperatorWithKernel {
                    "Output(InfNormOut) of AdamaxOp should not be null.");
 
     auto lr_dims = ctx->GetInputDim("LearningRate");
+    PADDLE_ENFORCE_NE(framework::product(lr_dims), 0,
+                      "Maybe the Input variable LearningRate has not "
+                      "been initialized. You may need to confirm "
+                      "if you put exe.run(startup_program) "
+                      "after optimizer.minimize function.");
     PADDLE_ENFORCE_EQ(framework::product(lr_dims), 1,
                       "Learning rate should have 1 dimension");
     auto beta1_pow_dims = ctx->GetInputDim("Beta1Pow");

paddle/fluid/operators/optimizers/decayed_adagrad_op.cc

@@ -49,6 +49,11 @@ class DecayedAdagradOp : public framework::OperatorWithKernel {
                    "Output(MomentOut) of DecayedAdagradOp should not be null.");
 
     auto lr_dims = ctx->GetInputDim("LearningRate");
+    PADDLE_ENFORCE_NE(framework::product(lr_dims), 0,
+                      "Maybe the Input variable LearningRate has not "
+                      "been initialized. You may need to confirm "
+                      "if you put exe.run(startup_program) "
+                      "after optimizer.minimize function.");
     PADDLE_ENFORCE_EQ(framework::product(lr_dims), 1,
                       "LearningRate should have one element");
     auto param_dims = ctx->GetInputDim("Param");

paddle/fluid/operators/optimizers/ftrl_op.cc

@@ -57,6 +57,11 @@ class FTRLOp : public framework::OperatorWithKernel {
                       "Two input of FTRL Op's dimension must be same.");
 
     auto lr_dim = ctx->GetInputDim("LearningRate");
+    PADDLE_ENFORCE_NE(framework::product(lr_dim), 0,
+                      "Maybe the Input variable LearningRate has not "
+                      "been initialized. You may need to confirm "
+                      "if you put exe.run(startup_program) "
+                      "after optimizer.minimize function.");
     PADDLE_ENFORCE_EQ(framework::product(lr_dim), 1,
                       "Learning Rate should be a scalar.");
 

paddle/fluid/operators/optimizers/momentum_op.h

@@ -54,6 +54,15 @@ class MomentumOp : public framework::OperatorWithKernel {
     PADDLE_ENFORCE(ctx->HasOutput("VelocityOut"),
                    "Output(VelocityOut) of Momentum should not be null.");
 
+    auto lr_dims = ctx->GetInputDim("LearningRate");
+    PADDLE_ENFORCE_NE(framework::product(lr_dims), 0,
+                      "Maybe the Input variable LearningRate has not "
+                      "been initialized. You may need to confirm "
+                      "if you put exe.run(startup_program) "
+                      "after optimizer.minimize function.");
+    PADDLE_ENFORCE_EQ(framework::product(lr_dims), 1,
+                      "Learning_rate should be a scalar");
+
     auto param_dim = ctx->GetInputDim("Param");
     if (ctx->GetInputsVarType("Grad")[0] ==
         framework::proto::VarType::LOD_TENSOR) {
@@ -64,8 +73,6 @@ class MomentumOp : public framework::OperatorWithKernel {
           param_dim, ctx->GetInputDim("Velocity"),
           "Param and Velocity of MomentumOp should have the same dimension.");
     }
-    PADDLE_ENFORCE_EQ(framework::product(ctx->GetInputDim("LearningRate")), 1,
-                      "Learning_rate should be a scalar");
 
     ctx->SetOutputDim("ParamOut", param_dim);
     ctx->SetOutputDim("VelocityOut", param_dim);

paddle/fluid/operators/optimizers/sgd_op.cc

@@ -32,6 +32,11 @@ class SGDOp : public framework::OperatorWithKernel {
                    "Output(ParamOut) of SGDOp should not be null.");
 
     auto lr_dims = ctx->GetInputDim("LearningRate");
+    PADDLE_ENFORCE_NE(framework::product(lr_dims), 0,
+                      "Maybe the Input variable LearningRate has not "
+                      "been initialized. You may need to confirm "
+                      "if you put exe.run(startup_program) "
+                      "after optimizer.minimize function.");
     PADDLE_ENFORCE_EQ(framework::product(lr_dims), 1,
                       "Learning rate should have 1 element");
     auto param_dim = ctx->GetInputDim("Param");