- 19 8月, 2019 6 次提交
-
-
由 Sam Brannen 提交于
-
由 Sam Brannen 提交于
-
由 Sam Brannen 提交于
-
由 Brian Clozel 提交于
This commit moves the dependency management and test source files related to integration tests to a dedicated module. This allows us to focus the root project on building the Spring Framework. See gh-23282
-
由 Brian Clozel 提交于
This commit removes JDiff from the Spring Framework build and instead, adds a Gradle plugin that configure JApiCmp tasks on the framework modules. Fixes gh-22942 See gh-23282
-
由 Sebastien Deleuze 提交于
This updates brings full interoperability between Reactor and Coroutines contexts. Closes gh-22986
-
- 18 8月, 2019 6 次提交
-
-
由 Sam Brannen 提交于
See gh-23467
-
由 Stephane Nicoll 提交于
* pr/23480: Fix typo Closes gh-23480
-
由 부종민 提交于
See gh-23480
-
由 Sam Brannen 提交于
Closes gh-23479
-
由 Sam Brannen 提交于
The spring-build-src module does not contain any tests. Thus, we do not need any test dependencies.
-
由 Sam Brannen 提交于
Closes gh-23467
-
- 17 8月, 2019 14 次提交
-
-
由 Phillip Webb 提交于
Add `SpringJUnit5` checkstyle rule to ensure that JUnit 4 annotations aren't accidentally used in new tests. The "must not be public" rule has been suppressed since there are quite a few tests that extend base tests from other packages.
-
由 Phillip Webb 提交于
-
由 Andrey Kolchanov 提交于
Closes gh-23477
-
由 Sam Brannen 提交于
Prior to this commit, the "reactive matrix" contained a duplicate argument set per parameterized client.
-
由 Sam Brannen 提交于
Closes gh-23476
-
由 Sam Brannen 提交于
-
由 Sam Brannen 提交于
-
由 Sam Brannen 提交于
Inspired by the fact that example.com is currently not reachable from my network.
-
由 Sam Brannen 提交于
Closes gh-23451
-
由 Sam Brannen 提交于
This commit migrates the spring-test test suite from JUnit 4 to JUnit Jupiter where applicable. Tests specific to our JUnit 4 and TestNG support remain written using those frameworks. In addition, some tests are still written in JUnit 4 if they extend a test class that should not be migrated to JUnit Jupiter. See gh-23451
-
由 Sam Brannen 提交于
This commit removes the JUnit 4 dependency from all modules except spring-test which provides explicit JUnit 4 support. This commit also includes the following. - migration from JUnit 4 assertions to JUnit Jupiter assertions in all Kotlin tests - migration from JUnit 4 assumptions in Spring's TestGroup support to JUnit Jupiter assumptions, based on org.opentest4j.TestAbortedException - introduction of a new TestGroups utility class than can be used from existing JUnit 4 tests in the spring-test module in order to perform assumptions using JUnit 4's Assume class See gh-23451
-
由 Sam Brannen 提交于
This commit migrates the rest of Spring's test suite to JUnit Jupiter, except spring-test which will be migrated in a separate commit. See gh-23451
-
由 Sam Brannen 提交于
This commit migrates parameterized tests in spring-core using the "composed @ParameterizedTest" approach. This approach is reused in follow-up commits for the migration of the remaining modules. For a concrete example, see AbstractDataBufferAllocatingTests and its subclasses (e.g., DataBufferTests). Specifically, AbstractDataBufferAllocatingTests declares a custom @ParameterizedDataBufferAllocatingTest annotation that is meta-annotated with @ParameterizedTest and @MethodSource("org.springframework.core.io.buffer.AbstractDataBufferAllocatingTests#dataBufferFactories()"). Individual methods in concrete subclasses are then annotated with @ParameterizedDataBufferAllocatingTest instead of @ParameterizedTest or @test. The approach makes the migration from JUnit 4 to JUnit Jupiter rather straightforward; however, there is one major downside. The arguments for a @ParameterizedTest test method can only be accessed by the test method itself. It is not possible to access them in an @BeforeEach method (see https://github.com/junit-team/junit5/issues/944). Consequently, we are forced to declare the parameters in each such method and delegate to a custom "setup" method. Although this is a bit cumbersome, I feel it is currently the best way to achieve fine grained parameterized tests within our test suite without implementing a custom TestTemplateInvocationContextProvider for each specific use case. Once https://github.com/junit-team/junit5/issues/878 is resolved, we should consider migrating to parameterized test classes. See gh-23451
-
由 Sam Brannen 提交于
This first commit for this issue: - allows JUnit Jupiter to be used for all tests - adds a dependency on mockito-junit-jupiter - migrates tests in spring-core to JUnit Jupiter, except parameterized tests The following script was developed in order to semi-automate the migration process. https://github.com/sbrannen/junit-converters/blob/master/junit4ToJUnitJupiter.zsh See gh-23451
-
- 16 8月, 2019 3 次提交
-
-
由 Brian Clozel 提交于
See gh-23282
-
由 Brian Clozel 提交于
This commit removes unused parts of the Gradle build: * Gradle wrapper customization which should not be needed in recent versions of Gradle (or can be replaced with options in the gradle.properties file) * the branch strategy configuration See gh-23282
-
由 Brian Clozel 提交于
See gh-23282
-
- 15 8月, 2019 1 次提交
-
-
由 Brian Clozel 提交于
This commit moves the compile configuration from the Gradle DSL to a convention. This configuration is not changing often, and we're using that opportunity to make the Java source compatibility a project property so as to easily recent JDKs this on the command line. See gh-23282
-
- 14 8月, 2019 5 次提交
-
-
由 Sebastien Deleuze 提交于
See gh-21778
-
由 Sebastien Deleuze 提交于
See gh-21778
-
由 Sebastien Deleuze 提交于
See gh-21778
-
由 Juergen Hoeller 提交于
ClassLoaderAwareUndeclaredThrowableStrategy fails with a VerifyError on recent JDKs after the CGLIB 3.3 upgrade. The alternative is to replace it with a plain ClassLoaderAwareGeneratorStrategy (extracted from CglibSubclassingInstantiationStrategy) and custom UndeclaredThrowableException handling in CglibMethodInvocation. See gh-23453
-
由 Brian Clozel 提交于
Prior to this commit, the Spring Framework build would be using the propdeps Gradle plugin to introduce two new configurations to the build: "optional" and "provided". This would also configure related conventions for IDEs, adding those configurations to published POMs. This commit removes the need for this plugin and creates instead a custom plugin for an "optional" configuration. While the Eclipse IDE support is still supported, there is no need for specific conventions for IntelliJ IDEA anymore. This new plugin does not introduce the "provided" scope, as "compileOnly" and "testCompileOnly" are here for that. Also as of this commit, optional/provided dependencies are not published with the Spring Framework modules POMs annymore. Generally, these dependencies do not provide actionable information to the developers reading / tools consuming the published POMs. Optional/Provided dependencies are **not**: * dependencies you can add to enable some supported feature * dependencies versions that you can use to figure out CVEs or bugs * dependencies that might be missing in existing Spring applications In the context of Spring Framework, optional dependencies are just libraries are Spring is compiling against for various technical reasons. With that in mind, we are not publishing that information anymore. See gh-23282
-
- 13 8月, 2019 5 次提交
-
-
由 Sebastien Deleuze 提交于
See gh-21778
-
由 Sebastien Deleuze 提交于
-
由 Sebastien Deleuze 提交于
See gh-21778
-
由 Brian Clozel 提交于
This commit moves the existing "test sources" Gradle plugin from Groovy to Java and updates the "buildSrc" build file to prepare for additional plugins in the Spring Framework build. The plugin itself looks, for a given Spring Framework module, at all the project dependencies for the following scopes: "compile", "testCompile", "api", "implementation" and "optional" (to be supported by a different plugin). See gh-23282
-
由 Sam Brannen 提交于
See gh-23457
-