Fix namespace selector for _all namespaces (#1197)

* Fix namespace selector for _all namespaces

src/app/frontend/common/namespace/namespaceselect_component.js

@@ -95,7 +95,7 @@ export class NamespaceSelectController {
       let newNamespace = toParams[namespaceParam];
       if (newNamespace) {
         if (this.namespacesInitialized_) {
-          if (this.namespaces.indexOf(newNamespace) >= 0) {
+          if (this.namespaces.indexOf(newNamespace) >= 0 || newNamespace === ALL_NAMESPACES) {
             this.selectedNamespace = newNamespace;
           } else {
             this.selectedNamespace = DEFAULT_NAMESPACE;
@@ -141,8 +141,9 @@ export class NamespaceSelectController {
       return resource.get().$promise.then((/** !backendApi.NamespaceList */ namespaceList) => {
         this.namespaces = namespaceList.namespaces.map((n) => n.objectMeta.name);
         this.namespacesInitialized_ = true;
-        if (this.namespaces.indexOf(this.selectedNamespace) === -1) {
-          this.selectedNamespace = ALL_NAMESPACES;
+        if (this.namespaces.indexOf(this.selectedNamespace) === -1 &&
+            this.selectedNamespace !== ALL_NAMESPACES) {
+          this.selectedNamespace = DEFAULT_NAMESPACE;
           this.changeNamespace();
         }
       });

src/test/frontend/common/namespace/namespaceselect_component_test.js

@@ -100,10 +100,29 @@ describe('Namespace select component ', () => {
     scope.$digest();
     expect(ctrl.selectedNamespace).toBe('default');
 
+    state.go('fakeState', {namespace: '_all'});
+    scope.$digest();
+    expect(ctrl.selectedNamespace).toBe('_all');
+
     // Do not init twice. Nothing happens.
     ctrl.loadNamespacesIfNeeded();
   });
 
+  it('should initialize from all namespaces', () => {
+    ctrl.$onInit();
+    state.go('fakeState', new StateParams('_all'));
+    scope.$digest();
+    expect(ctrl.selectedNamespace).toBe('_all');
+
+    ctrl.loadNamespacesIfNeeded();
+    httpBackend.whenGET('api/v1/namespace').respond({
+      namespaces: [{objectMeta: {name: 'a'}}],
+    });
+    httpBackend.flush();
+    expect(ctrl.namespaces).toEqual(['a']);
+    expect(ctrl.selectedNamespace).toBe('_all');
+  });
+
   it('should format namespace', () => {
     ctrl.selectedNamespace = '_all';
     expect(ctrl.formatNamespace()).toBe('All namespaces');