Fix development container (#4875)

* Ensure installing dependencies.
* Enable to pass K8S_DASHBOARD_NPM_CMD as env to run-npm-on-container.sh.
* Fix typo.

aio/develop/gosu-command.sh

@@ -29,9 +29,10 @@ GOSU="exec /usr/sbin/gosu user"
 # Run command if K8S_DASHBOARD_CMD is set,
 # otherwise run `npm ${K8S_DASHBOARD_NPM_CMD}`.
 if [[ -n "${K8S_DASHBOARD_CMD}" ]] ; then
-  # Run npm command
+  # Run specified command
   echo "Run '${K8S_DASHBOARD_CMD}'"
   ${GOSU} ${K8S_DASHBOARD_CMD}
 else
+  # Run npm command
   ${GOSU} aio/develop/npm-command.sh
 fi

aio/develop/npm-command.sh

@@ -13,8 +13,12 @@
 # See the License for the specific language governing permissions and
 # limitations under the License.
 
+# Install dependencies
+echo "Install dependencies"
+npm ci
+
 # Run npm command if K8S_DASHBOARD_NPM_CMD is set,
-# otherwise install and start dashboard.
+# otherwise start dashboard.
 if [[ -n "${K8S_DASHBOARD_NPM_CMD}" ]] ; then
   # Run npm command
   echo "Run npm '${K8S_DASHBOARD_NPM_CMD}'"
@@ -23,9 +27,6 @@ if [[ -n "${K8S_DASHBOARD_NPM_CMD}" ]] ; then
     --kubernetes-dashboard:sidecar_host=${K8S_DASHBOARD_SIDECAR_HOST} \
     --kubernetes-dashboard:port=${K8S_DASHBOARD_PORT}
 else
-  # Install dashboard.
-  echo "Install dashboard"
-  npm ci
   if [[ "${K8S_OWN_CLUSTER}" != true ]] ; then
     # Stop cluster.
     echo "Stop cluster"

aio/develop/run-npm-on-container.sh

@@ -31,7 +31,7 @@ LOCAL_GID=$(id -g)
 # command with K8S_DASHBOAD_NPM_CMD.
 # But if K8S_DASHBOARD_CMD is set, the command in K8S_DASHBOARD_CMD will be
 # executed instead of `npm ${K8S_DASHBOARD_NPM_CMD}`.
-K8S_DASHBOARD_NPM_CMD=$*
+K8S_DASHBOARD_NPM_CMD=${K8S_DASHBOARD_NPM_CMD:-*}
 
 # kubeconfig for dashboard.
 # This will be mounted and certain npm command can modify it,