- 14 7月, 2020 21 次提交
-
-
由 Matt Bierner 提交于
These currently do not work on web Skipping while investigating this
-
由 rebornix 提交于
-
由 rebornix 提交于
-
由 rebornix 提交于
-
由 chrisdias 提交于
-
由 rebornix 提交于
-
由 rebornix 提交于
-
由 Matt Bierner 提交于
Fixes #86658
-
由 Matt Bierner 提交于
Fixes #101946 Webview can currently trigger some keyboard events twice. Sequence of events: - User presses ctrl+v with a webview focused - Webview is listening to keyboard events for rebroadcast (so that we can handle normal VS code commands even when focused on webviews) - We rebroadcast the keypresses back to VS Code - The webview then triggers the standard copy behavior on its own (I believe this is either chromium or electron) - VS Code gets the ctrl+v keypress event and resolves it to the 'paste' command - The paste command triggers the paste method on the webview - This calls back into the webview content to trigger a second paste This does not happen in cases where we are using native menus, which can call `setIgnoreMenuShortcuts` to disable the browser geenrated paste event. ## The fix To fix this, I think we want to completely block the browser generate events in all cases and instead always dispatch the events through VS Code. This should ensure more consistent behavior. This PR does this by: - In the webview, add a keypress listener for copy/paste/cut and undo/redo. When we see these events, call `preventDefault` to block them but still dispatch back to VS Code - In VS Code, more the logic for triggering undo/redo, etc. on webviews out of the electron layer and into the browser layer. iframe based webviews have the exact same problem as electron based webviews, so we need to fix this issue for both of them.
-
由 Rob Lourens 提交于
Looks like it is possible for this to be called when initializing, before layoutBody is called.
-
由 Orta Therox 提交于
-
由 Rob Lourens 提交于
-
由 Connor Peet 提交于
-
由 Connor Peet 提交于
-
由 Connor Peet 提交于
-
由 David Linskey 提交于
Fixes #61489 Co-authored-by: NMatt Bierner <matb@microsoft.com>
-
由 rebornix 提交于
-
由 Rachel Macfarlane 提交于
-
由 Matt Bierner 提交于
This command should be active if: - we are on mac - or we are not using custom title bars The previous code was incorrectly disabling these commands entirely on mac
-
由 Matt Bierner 提交于
This avoids having the uri transformed unexpectedly
-
由 rebornix 提交于
-
- 13 7月, 2020 19 次提交
-
-
由 João Moreno 提交于
-
由 acheronfail 提交于
* fix: rename textFileEdiorModel to textFileEditorModel * fix: accumualted and valdiate typos
-
由 Alex Ross 提交于
-
-
由 Daniel Imms 提交于
Part of #101857
-
由 Daniel Imms 提交于
Part of #98494
-
由 Daniel Imms 提交于
use ^H to delete word left in cmd.exe
-
由 Daniel Imms 提交于
Part of #101857
-
由 Daniel Imms 提交于
Part of #101857
-
由 Benjamin Pasero 提交于
Not sure why, looks like Windows and encodings are not intuitive.
-
由 João Moreno 提交于
-
由 Benjamin Pasero 提交于
-
由 Benjamin Pasero 提交于
-
由 Alex Ross 提交于
Part of #101073
-
由 Alex Ross 提交于
-
-
由 Johannes Rieken 提交于
env.appRoot is empty string when not having an application root, https://github.com/microsoft/vscode/issues/101857
-
由 Johannes Rieken 提交于
re-use default NotImplementedError, make base type as implementing task service, https://github.com/microsoft/vscode/issues/101857 fyi @alexr00
-
-