1. 28 6月, 2019 1 次提交
  2. 17 6月, 2019 3 次提交
  3. 12 6月, 2019 1 次提交
  4. 08 6月, 2019 2 次提交
    • M
      Use ReadonlyArray for a few more lists of IActions · 9f6de388
      Matt Bierner 提交于
      Also changes processService to not modify its input actions, which seems like unexpected behavior
      9f6de388
    • M
      Use ReadonlyArrays for IActions used in notifications · e78f05a7
      Matt Bierner 提交于
      These arrays of actions should not be modified by the caller. Mark them as readonly to prevent this. This also let me eliminate a number of not null supressions that had been introduced during the strict null migration
      
      One small code change was required in `showError`. However I believe this was actually a bug since modifying the input array was likely not what would be expected (in practice, we usually just passed in array literals so I don't think we hit this one)
      e78f05a7
  5. 07 6月, 2019 1 次提交
  6. 06 6月, 2019 3 次提交
  7. 28 5月, 2019 1 次提交
  8. 24 5月, 2019 3 次提交
  9. 23 5月, 2019 1 次提交
  10. 16 5月, 2019 1 次提交
  11. 25 4月, 2019 1 次提交
  12. 18 4月, 2019 1 次提交
  13. 16 4月, 2019 1 次提交
  14. 13 4月, 2019 1 次提交
  15. 12 4月, 2019 1 次提交
    • S
      adding overlayService (#72014) · 27c30c8a
      SteVen Batten 提交于
      * adding overlayService
      
      * addressing feedback from UX meeting
      
      * relocating to progressService2
      
      * remove overlayService and update progressService
      27c30c8a
  16. 04 4月, 2019 1 次提交
  17. 01 4月, 2019 1 次提交
  18. 07 3月, 2019 2 次提交
  19. 05 3月, 2019 1 次提交
  20. 02 3月, 2019 1 次提交
  21. 07 2月, 2019 1 次提交
  22. 24 1月, 2019 2 次提交
    • J
      less async#always, #67027 · 936facd1
      Johannes Rieken 提交于
      936facd1
    • S
      Workbench Grid Layout Behind flag (#63066) · c45d91d9
      SteVen Batten 提交于
      * partially functioning grid view
      
      * lots of toggling behavior and editor restore
      
      * dimension changes
      
      * restore layout and fix titlebar
      
      * fix view dimensions on toggle/move
      
      * increase timeout for debug config
      
      * undo unnecessary changes to CSS
      
      * put grid layout behind setting
      
      * fix strict null checks
      
      * address code comments from @bpasero
      
      * changing key name
      c45d91d9
  23. 17 1月, 2019 1 次提交
  24. 11 1月, 2019 1 次提交
  25. 09 1月, 2019 3 次提交
    • M
      Don't allow passing `infinite=false` to progressService · 8a3cae3e
      Matt Bierner 提交于
      This state is currently unused and make no sense. Update the signature to  prevent ever trying to go into this state
      8a3cae3e
    • M
      Use const enum and namespace · 4d29f5d2
      Matt Bierner 提交于
      4d29f5d2
    • M
      Switch to use more state machine like state management in progressService · c723a054
      Matt Bierner 提交于
      **Problem**
      In progress service, the `ProgressState` object is quite difficult to understand. Only a subset of fields are active at a given time so the state is really more like a state machine.
      
      When enabling strict null checks, the existing pattern is also a pain because it is not clear which subset of fields go to gether and will not be undefined
      
      **Fix**
      I've been experimenting with writing states much explicitly. This has two main points:
      
      - Encapsulating all state in a single state object (which the progress service already does)
      - Encoding each valid state very explicitly in a state machine like manner
      
      For progress service, the encoding breaks the `ProgressState` object up into five different states that the progress service transitions between.
      c723a054
  26. 08 1月, 2019 2 次提交
  27. 04 1月, 2019 1 次提交
  28. 28 12月, 2018 1 次提交
    • J
      Converted another ~70 test files to strictNullChecks (#65672) · 373b4411
      Josh Goldberg 提交于
      * Converted another ~70 test files to strictNullChecks
      
      These are the remaining test files that didn't require any changes to non-test file types. I'll send those in separately.
      
      Most changes were automatic and small (`!`s).
      The only non-trival change is that `extHostSearch.ts` needs an interface for its test data.
      
      Again used [TypeStat](https://github.com/JoshuaKGoldberg/TypeStat) when possible per #65581. I'm happy to split this up into smaller PRs if you'd prefer!
      
      * Added missing `!`s to `commands.test.ts`
      373b4411