remove suggest range highlighter, https://github.com/microsoft/vscode/issues/91104

src/vs/editor/common/config/editorOptions.ts

@@ -2716,10 +2716,6 @@ export interface ISuggestOptions {
 	 * Overwrite word ends on accept. Default to false.
 	 */
 	insertMode?: 'insert' | 'replace';
-	/**
-	 * Show a highlight when suggestion replaces or keep text after the cursor. Defaults to false.
-	 */
-	insertHighlight?: boolean;
 	/**
 	 * Enable graceful matching. Defaults to true.
 	 */
@@ -2870,7 +2866,6 @@ class EditorSuggest extends BaseEditorOption<EditorOption.suggest, InternalSugge
 	constructor() {
 		const defaults: InternalSuggestOptions = {
 			insertMode: 'insert',
-			insertHighlight: true,
 			filterGraceful: true,
 			snippetsPreventQuickSuggestions: true,
 			localityBonus: false,
@@ -2921,11 +2916,6 @@ class EditorSuggest extends BaseEditorOption<EditorOption.suggest, InternalSugge
 					default: defaults.insertMode,
 					description: nls.localize('suggest.insertMode', "Controls whether words are overwritten when accepting completions. Note that this depends on extensions opting into this feature.")
 				},
-				'editor.suggest.insertHighlight': {
-					type: 'boolean',
-					default: defaults.insertHighlight,
-					description: nls.localize('suggest.insertHighlight', "Controls whether unexpected text modifications while accepting completions should be highlighted, e.g `insertMode` is `replace` but the completion only supports `insert`.")
-				},
 				'editor.suggest.filterGraceful': {
 					type: 'boolean',
 					default: defaults.filterGraceful,
@@ -3118,7 +3108,6 @@ class EditorSuggest extends BaseEditorOption<EditorOption.suggest, InternalSugge
 		const input = _input as ISuggestOptions;
 		return {
 			insertMode: EditorStringEnumOption.stringSet(input.insertMode, this.defaultValue.insertMode, ['insert', 'replace']),
-			insertHighlight: EditorBooleanOption.boolean(input.insertHighlight, this.defaultValue.insertHighlight),
 			filterGraceful: EditorBooleanOption.boolean(input.filterGraceful, this.defaultValue.filterGraceful),
 			snippetsPreventQuickSuggestions: EditorBooleanOption.boolean(input.snippetsPreventQuickSuggestions, this.defaultValue.filterGraceful),
 			localityBonus: EditorBooleanOption.boolean(input.localityBonus, this.defaultValue.localityBonus),

src/vs/editor/contrib/suggest/suggestController.ts

@@ -37,7 +37,6 @@ import { IPosition, Position } from 'vs/editor/common/core/position';
 import { TrackedRangeStickiness, ITextModel } from 'vs/editor/common/model';
 import { EditorOption } from 'vs/editor/common/config/editorOptions';
 import * as platform from 'vs/base/common/platform';
-import { SuggestRangeHighlighter } from 'vs/editor/contrib/suggest/suggestRangeHighlighter';
 import { MenuRegistry } from 'vs/platform/actions/common/actions';
 
 // sticky suggest widget which doesn't disappear on focus out and such
@@ -233,9 +232,6 @@ export class SuggestController implements IEditorContribution {
 		};
 		this._toDispose.add(this.editor.onDidChangeConfiguration(() => updateFromConfig()));
 		updateFromConfig();
-
-		// create range highlighter
-		this._toDispose.add(new SuggestRangeHighlighter(this));
 	}
 
 	dispose(): void {

src/vs/editor/contrib/suggest/suggestRangeHighlighter.ts

-/*---------------------------------------------------------------------------------------------
- *  Copyright (c) Microsoft Corporation. All rights reserved.
- *  Licensed under the MIT License. See License.txt in the project root for license information.
- *--------------------------------------------------------------------------------------------*/
-
-import { DisposableStore, dispose, IDisposable } from 'vs/base/common/lifecycle';
-import { Range } from 'vs/editor/common/core/range';
-import { EditorOption } from 'vs/editor/common/config/editorOptions';
-import { CompletionItem } from 'vs/editor/contrib/suggest/suggest';
-import { IModelDeltaDecoration } from 'vs/editor/common/model';
-import { SuggestController } from 'vs/editor/contrib/suggest/suggestController';
-import { Emitter } from 'vs/base/common/event';
-import { domEvent } from 'vs/base/browser/event';
-import { domContentLoaded } from 'vs/base/browser/dom';
-
-export class SuggestRangeHighlighter {
-
-	private readonly _disposables = new DisposableStore();
-
-	private _decorations: string[] = [];
-	private _widgetListener?: IDisposable;
-	private _shiftKeyListener?: IDisposable;
-	private _currentItem?: CompletionItem;
-
-	constructor(private readonly _controller: SuggestController) {
-
-		this._disposables.add(_controller.model.onDidSuggest(e => {
-			if (!e.shy) {
-				const widget = this._controller.widget.getValue();
-				const focused = widget.getFocusedItem();
-				if (focused) {
-					this._highlight(focused.item);
-				}
-				if (!this._widgetListener) {
-					this._widgetListener = widget.onDidFocus(e => this._highlight(e.item));
-				}
-			}
-		}));
-
-		this._disposables.add(_controller.model.onDidCancel(() => {
-			this._reset();
-		}));
-	}
-
-	dispose(): void {
-		this._reset();
-		this._disposables.dispose();
-		dispose(this._widgetListener);
-		dispose(this._shiftKeyListener);
-	}
-
-	private _reset(): void {
-		this._decorations = this._controller.editor.deltaDecorations(this._decorations, []);
-		if (this._shiftKeyListener) {
-			this._shiftKeyListener.dispose();
-			this._shiftKeyListener = undefined;
-		}
-	}
-
-	private _highlight(item: CompletionItem) {
-
-		this._currentItem = item;
-		const opts = this._controller.editor.getOption(EditorOption.suggest);
-		let newDeco: IModelDeltaDecoration[] = [];
-
-		if (opts.insertHighlight) {
-			if (!this._shiftKeyListener) {
-				this._shiftKeyListener = shiftKey.event(() => this._highlight(this._currentItem!));
-			}
-
-			const info = this._controller.getOverwriteInfo(item, shiftKey.isPressed);
-			const position = this._controller.editor.getPosition()!;
-
-			if (opts.insertMode === 'insert' && info.overwriteAfter > 0) {
-				// wants inserts but got replace-mode -> highlight AFTER range
-				newDeco = [{
-					range: new Range(position.lineNumber, position.column, position.lineNumber, position.column + info.overwriteAfter),
-					options: { inlineClassName: 'suggest-insert-unexpected' }
-				}];
-
-			} else if (opts.insertMode === 'replace' && info.overwriteAfter === 0) {
-				// want replace but likely got insert -> highlight AFTER range
-				const wordInfo = this._controller.editor.getModel()?.getWordAtPosition(position);
-				if (wordInfo && wordInfo.endColumn > position.column) {
-					newDeco = [{
-						range: new Range(position.lineNumber, position.column, position.lineNumber, wordInfo.endColumn),
-						options: { inlineClassName: 'suggest-insert-unexpected' }
-					}];
-				}
-			}
-		}
-
-		// update editor decorations
-		this._decorations = this._controller.editor.deltaDecorations(this._decorations, newDeco);
-	}
-}
-
-const shiftKey = new class ShiftKey extends Emitter<boolean> {
-
-	private readonly _subscriptions = new DisposableStore();
-	private _isPressed: boolean = false;
-
-	constructor() {
-		super();
-		domContentLoaded().then(() => {
-			this._subscriptions.add(domEvent(document.body, 'keydown')(e => this.isPressed = e.shiftKey));
-			this._subscriptions.add(domEvent(document.body, 'keyup')(() => this.isPressed = false));
-			this._subscriptions.add(domEvent(document.body, 'mouseleave')(() => this.isPressed = false));
-			this._subscriptions.add(domEvent(document.body, 'blur')(() => this.isPressed = false));
-		});
-	}
-
-	get isPressed(): boolean {
-		return this._isPressed;
-	}
-
-	set isPressed(value: boolean) {
-		if (this._isPressed !== value) {
-			this._isPressed = value;
-			this.fire(value);
-		}
-	}
-
-	dispose() {
-		this._subscriptions.dispose();
-		super.dispose();
-	}
-};

src/vs/monaco.d.ts

@@ -3645,10 +3645,6 @@ declare namespace monaco.editor {
 		 * Overwrite word ends on accept. Default to false.
 		 */
 		insertMode?: 'insert' | 'replace';
-		/**
-		 * Show a highlight when suggestion replaces or keep text after the cursor. Defaults to false.
-		 */
-		insertHighlight?: boolean;
 		/**
 		 * Enable graceful matching. Defaults to true.
 		 */