remove/disable selected and onDidChangeSelection from new kernel world

this need further clarification. we might be able to fold this into the API for communicating with a renderer
上级 a1139fd8
......@@ -1472,10 +1472,13 @@ declare module 'vscode' {
// fit here, e.g:
// selectionHandler?: (notebook: NotebookDocument, selected: boolean) => void;
// is this kernel selected
readonly selected: boolean;
// fired when kernel is selected/unselected
readonly onDidChangeSelection: Event<boolean>;
// // is this kernel selected
// readonly selected: boolean;
// // fired when kernel is selected/unselected
// readonly onDidChangeSelection: Event<boolean>;
// kernels can establish IPC channels to (visible) notebook editors
// createNotebookCommunication(editor: vscode.NotebookEditor): vscode.NotebookCommunication;
// UI properties (get/set)
label: string;
......@@ -1490,9 +1493,6 @@ declare module 'vscode' {
// optional kernel interrupt command
interruptHandler?: (notebook: NotebookDocument) => void
// kernels can establish IPC channels to (visible) notebook editors
// createNotebookCommunication(editor: vscode.NotebookEditor): vscode.NotebookCommunication;
// remove kernel
dispose(): void;
}
......
......@@ -72,8 +72,8 @@ export class ExtHostNotebookKernels implements ExtHostNotebookKernelsShape {
return {
get id() { return data.id; },
get selector() { return data.selector; },
get selected() { return that._kernelData.get(handle)?.selected ?? false; },
onDidChangeSelection: emitter.event,
// get selected() { return that._kernelData.get(handle)?.selected ?? false; },
// onDidChangeSelection: emitter.event,
get label() {
return data.label;
},
......
Markdown is supported
0% .
You are about to add 0 people to the discussion. Proceed with caution.
先完成此消息的编辑!
想要评论请 注册