Start strict null checking some test files

Start pinning some tests with strict null checks to catch potential regressions

src/tsconfig.strictNullChecks.json

@@ -85,18 +85,49 @@
 		"./vs/base/parts/ipc/node/ipc.electron.ts",
 		"./vs/base/parts/ipc/node/ipc.net.ts",
 		"./vs/base/parts/ipc/node/ipc.ts",
+		"./vs/base/parts/ipc/test/node/ipc.cp.test.ts",
 		"./vs/base/parts/ipc/test/node/testApp.ts",
 		"./vs/base/parts/ipc/test/node/testService.ts",
 		"./vs/base/parts/quickopen/common/quickOpen.ts",
 		"./vs/base/parts/quickopen/common/quickOpenScorer.ts",
+		"./vs/base/test/browser/browser.test.ts",
+		"./vs/base/test/browser/progressBar.test.ts",
+		"./vs/base/test/browser/ui/contextview/contextview.test.ts",
 		"./vs/base/test/browser/ui/grid/util.ts",
+		"./vs/base/test/browser/ui/list/listView.test.ts",
+		"./vs/base/test/browser/ui/list/rangeMap.test.ts",
+		"./vs/base/test/browser/ui/scrollbar/scrollableElement.test.ts",
+		"./vs/base/test/browser/ui/scrollbar/scrollbarState.test.ts",
+		"./vs/base/test/browser/ui/tree/indexTreeModel.test.ts",
+		"./vs/base/test/browser/ui/tree/objectTreeModel.test.ts",
+		"./vs/base/test/common/assert.test.ts",
+		"./vs/base/test/common/cache.test.ts",
+		"./vs/base/test/common/cancellation.test.ts",
+		"./vs/base/test/common/charCode.test.ts",
+		"./vs/base/test/common/collections.test.ts",
+		"./vs/base/test/common/errors.test.ts",
+		"./vs/base/test/common/hash.test.ts",
 		"./vs/base/test/common/json.test.ts",
 		"./vs/base/test/common/jsonEdit.test.ts",
 		"./vs/base/test/common/jsonFormatter.test.ts",
+		"./vs/base/test/common/lifecycle.test.ts",
+		"./vs/base/test/common/linkedList.test.ts",
+		"./vs/base/test/common/marshalling.test.ts",
+		"./vs/base/test/common/mime.test.ts",
+		"./vs/base/test/common/objects.test.ts",
+		"./vs/base/test/common/paging.test.ts",
 		"./vs/base/test/common/paths.test.ts",
+		"./vs/base/test/common/scrollable.test.ts",
+		"./vs/base/test/common/types.test.ts",
 		"./vs/base/test/common/utils.ts",
+		"./vs/base/test/common/uuid.test.ts",
+		"./vs/base/test/common/winjs.promise.test.ts",
+		"./vs/base/test/node/decoder.test.ts",
+		"./vs/base/test/node/encoding/encoding.test.ts",
+		"./vs/base/test/node/id.test.ts",
 		"./vs/base/test/node/processes/fixtures/fork.ts",
 		"./vs/base/test/node/processes/fixtures/fork_large.ts",
+		"./vs/base/test/node/processes/processes.test.ts",
 		"./vs/base/test/node/uri.test.perf.ts",
 		"./vs/base/test/node/utils.ts",
 		"./vs/base/worker/defaultWorkerFactory.ts",
@@ -106,6 +137,7 @@
 		"./vs/code/electron-browser/issue/issueReporterModel.ts",
 		"./vs/code/electron-browser/issue/issueReporterPage.ts",
 		"./vs/code/electron-browser/issue/issueReporterUtil.ts",
+		"./vs/code/electron-browser/issue/test/testReporterModel.test.ts",
 		"./vs/code/electron-browser/processExplorer/processExplorerMain.ts",
 		"./vs/code/electron-browser/sharedProcess/contrib/contributions.ts",
 		"./vs/code/electron-browser/sharedProcess/contrib/languagePackCachedDataCleaner.ts",
@@ -121,6 +153,7 @@
 		"./vs/code/node/shellEnv.ts",
 		"./vs/code/node/wait.ts",
 		"./vs/code/node/windowsFinder.ts",
+		"./vs/code/test/node/argv.test.ts",
 		"./vs/editor/browser/config/charWidthReader.ts",
 		"./vs/editor/browser/config/configuration.ts",
 		"./vs/editor/browser/config/elementSizeObserver.ts",
@@ -294,6 +327,7 @@
 		"./vs/editor/contrib/comment/blockCommentCommand.ts",
 		"./vs/editor/contrib/comment/comment.ts",
 		"./vs/editor/contrib/comment/lineCommentCommand.ts",
+		"./vs/editor/contrib/comment/test/blockCommentCommand.test.ts",
 		"./vs/editor/contrib/cursorUndo/cursorUndo.ts",
 		"./vs/editor/contrib/dnd/dnd.ts",
 		"./vs/editor/contrib/dnd/dragAndDropCommand.ts",
@@ -305,6 +339,7 @@
 		"./vs/editor/contrib/find/replaceAllCommand.ts",
 		"./vs/editor/contrib/find/replacePattern.ts",
 		"./vs/editor/contrib/find/simpleFindWidget.ts",
+		"./vs/editor/contrib/find/test/replacePattern.test.ts",
 		"./vs/editor/contrib/folding/folding.ts",
 		"./vs/editor/contrib/folding/foldingDecorations.ts",
 		"./vs/editor/contrib/folding/foldingModel.ts",
@@ -356,6 +391,7 @@
 		"./vs/editor/contrib/snippet/snippetVariables.ts",
 		"./vs/editor/contrib/suggest/completionModel.ts",
 		"./vs/editor/contrib/suggest/suggest.ts",
+		"./vs/editor/contrib/suggest/test/suggest.test.ts",
 		"./vs/editor/contrib/suggest/wordContextKey.ts",
 		"./vs/editor/contrib/suggest/wordDistance.ts",
 		"./vs/editor/contrib/toggleTabFocusMode/toggleTabFocusMode.ts",
@@ -383,7 +419,13 @@
 		"./vs/editor/test/browser/testCodeEditor.ts",
 		"./vs/editor/test/browser/testCommand.ts",
 		"./vs/editor/test/browser/view/minimapFontCreator.ts",
+		"./vs/editor/test/browser/view/viewLayer.test.ts",
 		"./vs/editor/test/common/commentMode.ts",
+		"./vs/editor/test/common/config/commonEditorConfig.test.ts",
+		"./vs/editor/test/common/controller/cursorMoveHelper.test.ts",
+		"./vs/editor/test/common/core/characterClassifier.test.ts",
+		"./vs/editor/test/common/core/lineTokens.test.ts",
+		"./vs/editor/test/common/core/range.test.ts",
 		"./vs/editor/test/common/core/viewLineToken.ts",
 		"./vs/editor/test/common/editorTestUtils.ts",
 		"./vs/editor/test/common/mocks/mockMode.ts",
@@ -394,11 +436,23 @@
 		"./vs/editor/test/common/model/benchmark/operations.benchmark.ts",
 		"./vs/editor/test/common/model/benchmark/searchNReplace.benchmark.ts",
 		"./vs/editor/test/common/model/editableTextModelTestUtils.ts",
+		"./vs/editor/test/common/model/linesTextBuffer/linesTextBufferBuilder.test.ts",
 		"./vs/editor/test/common/model/linesTextBuffer/textBufferAutoTestUtils.ts",
+		"./vs/editor/test/common/modes/languageConfiguration.test.ts",
+		"./vs/editor/test/common/modes/supports/characterPair.test.ts",
 		"./vs/editor/test/common/modes/supports/javascriptOnEnterRules.ts",
+		"./vs/editor/test/common/modes/supports/tokenization.test.ts",
 		"./vs/editor/test/common/modesTestUtils.ts",
 		"./vs/editor/test/common/view/minimapCharRendererFactory.ts",
+		"./vs/editor/test/common/view/overviewZoneManager.test.ts",
+		"./vs/editor/test/common/viewLayout/editorLayoutProvider.test.ts",
+		"./vs/editor/test/common/viewLayout/lineDecorations.test.ts",
+		"./vs/editor/test/common/viewLayout/viewLineRenderer.test.ts",
+		"./vs/editor/test/common/viewLayout/whitespaceComputer.test.ts",
+		"./vs/editor/test/common/viewModel/prefixSumComputer.test.ts",
 		"./vs/editor/test/common/viewModel/testViewModel.ts",
+		"./vs/editor/test/common/viewModel/viewModelDecorations.test.ts",
+		"./vs/editor/test/common/viewModel/viewModelImpl.test.ts",
 		"./vs/monaco.d.ts",
 		"./vs/nls.d.ts",
 		"./vs/nls.mock.ts",
@@ -406,6 +460,7 @@
 		"./vs/platform/actions/common/actions.ts",
 		"./vs/platform/actions/common/menu.ts",
 		"./vs/platform/actions/common/menuService.ts",
+		"./vs/platform/actions/test/common/menuService.test.ts",
 		"./vs/platform/backup/common/backup.ts",
 		"./vs/platform/backup/electron-main/backupMainService.ts",
 		"./vs/platform/broadcast/electron-browser/broadcastService.ts",
@@ -417,11 +472,14 @@
 		"./vs/platform/configuration/common/configurationRegistry.ts",
 		"./vs/platform/configuration/node/configuration.ts",
 		"./vs/platform/configuration/node/configurationService.ts",
+		"./vs/platform/configuration/test/common/configuration.test.ts",
 		"./vs/platform/configuration/test/common/testConfigurationService.ts",
+		"./vs/platform/configuration/test/node/configurationService.test.ts",
 		"./vs/platform/contextkey/browser/contextKeyService.ts",
 		"./vs/platform/contextkey/common/contextkey.ts",
 		"./vs/platform/contextview/browser/contextView.ts",
 		"./vs/platform/contextview/browser/contextViewService.ts",
+		"./vs/platform/credentials/test/node/keytar.test.ts",
 		"./vs/platform/diagnostics/electron-main/diagnosticsService.ts",
 		"./vs/platform/dialogs/common/dialogs.ts",
 		"./vs/platform/dialogs/node/dialogIpc.ts",
@@ -435,6 +493,7 @@
 		"./vs/platform/environment/common/environment.ts",
 		"./vs/platform/environment/node/argv.ts",
 		"./vs/platform/environment/node/environmentService.ts",
+		"./vs/platform/environment/test/node/environmentService.test.ts",
 		"./vs/platform/extensionManagement/common/extensionEnablementService.ts",
 		"./vs/platform/extensionManagement/common/extensionManagement.ts",
 		"./vs/platform/extensionManagement/common/extensionManagementUtil.ts",
@@ -443,6 +502,7 @@
 		"./vs/platform/extensionManagement/node/extensionManagementIpc.ts",
 		"./vs/platform/extensionManagement/node/extensionManagementUtil.ts",
 		"./vs/platform/extensionManagement/node/extensionsManifestCache.ts",
+		"./vs/platform/extensionManagement/test/electron-browser/extensionManagement.test.ts",
 		"./vs/platform/extensions/common/extensionHost.ts",
 		"./vs/platform/extensions/common/extensions.ts",
 		"./vs/platform/extensions/node/extensionValidator.ts",
@@ -457,6 +517,7 @@
 		"./vs/platform/instantiation/common/instantiationService.ts",
 		"./vs/platform/instantiation/common/serviceCollection.ts",
 		"./vs/platform/instantiation/node/instantiationService.ts",
+		"./vs/platform/instantiation/test/common/graph.test.ts",
 		"./vs/platform/instantiation/test/common/instantiationServiceMock.ts",
 		"./vs/platform/integrity/common/integrity.ts",
 		"./vs/platform/integrity/node/integrityServiceImpl.ts",
@@ -492,6 +553,7 @@
 		"./vs/platform/node/minimalTranslations.ts",
 		"./vs/platform/node/package.ts",
 		"./vs/platform/node/product.ts",
+		"./vs/platform/node/test/zip.test.ts",
 		"./vs/platform/node/zip.ts",
 		"./vs/platform/notification/common/notification.ts",
 		"./vs/platform/notification/test/common/testNotificationService.ts",
@@ -501,6 +563,7 @@
 		"./vs/platform/quickOpen/common/quickOpen.ts",
 		"./vs/platform/quickinput/common/quickInput.ts",
 		"./vs/platform/registry/common/platform.ts",
+		"./vs/platform/registry/test/common/platform.test.ts",
 		"./vs/platform/remote/common/remoteAuthorityResolver.ts",
 		"./vs/platform/remote/common/remoteHosts.ts",
 		"./vs/platform/remote/electron-browser/remoteAuthorityResolverService.ts",
@@ -513,6 +576,7 @@
 		"./vs/platform/search/common/replace.ts",
 		"./vs/platform/search/common/search.ts",
 		"./vs/platform/search/test/common/replace.test.ts",
+		"./vs/platform/search/test/common/search.test.ts",
 		"./vs/platform/state/common/state.ts",
 		"./vs/platform/state/node/stateService.ts",
 		"./vs/platform/statusbar/common/statusbar.ts",
@@ -553,6 +617,7 @@
 		"./vs/platform/workbench/common/contextkeys.ts",
 		"./vs/platform/workspace/common/workspace.ts",
 		"./vs/platform/workspace/test/common/testWorkspace.ts",
+		"./vs/platform/workspace/test/common/workspace.test.ts",
 		"./vs/platform/workspaces/common/workspaces.ts",
 		"./vs/platform/workspaces/electron-main/workspacesMainService.ts",
 		"./vs/platform/workspaces/node/workspaces.ts",
@@ -616,11 +681,13 @@
 		"./vs/workbench/parts/execution/common/execution.ts",
 		"./vs/workbench/parts/execution/electron-browser/terminal.ts",
 		"./vs/workbench/parts/execution/electron-browser/terminalService.ts",
+		"./vs/workbench/parts/execution/test/electron-browser/terminalService.test.ts",
 		"./vs/workbench/parts/extensions/common/extensionQuery.ts",
 		"./vs/workbench/parts/extensions/common/extensions.ts",
 		"./vs/workbench/parts/extensions/common/extensionsFileTemplate.ts",
 		"./vs/workbench/parts/extensions/electron-browser/extensionsActivationProgress.ts",
 		"./vs/workbench/parts/extensions/electron-browser/extensionsUtils.ts",
+		"./vs/workbench/parts/extensions/test/common/extensionQuery.test.ts",
 		"./vs/workbench/parts/logs/common/logConstants.ts",
 		"./vs/workbench/parts/logs/electron-browser/logs.contribution.ts",
 		"./vs/workbench/parts/logs/electron-browser/logsActions.ts",
@@ -636,6 +703,7 @@
 		"./vs/workbench/parts/output/common/outputLinkProvider.ts",
 		"./vs/workbench/parts/performance/electron-browser/stats.ts",
 		"./vs/workbench/parts/preferences/common/smartSnippetInserter.ts",
+		"./vs/workbench/parts/preferences/test/common/smartSnippetInserter.test.ts",
 		"./vs/workbench/parts/relauncher/electron-browser/relauncher.contribution.ts",
 		"./vs/workbench/parts/scm/common/scm.ts",
 		"./vs/workbench/parts/scm/electron-browser/scmMenus.ts",
@@ -648,6 +716,8 @@
 		"./vs/workbench/parts/snippets/electron-browser/snippets.contribution.ts",
 		"./vs/workbench/parts/snippets/electron-browser/snippetsFile.ts",
 		"./vs/workbench/parts/snippets/electron-browser/snippetsService.ts",
+		"./vs/workbench/parts/snippets/test/electron-browser/snippetsRegistry.test.ts",
+		"./vs/workbench/parts/snippets/test/electron-browser/snippetsRewrite.test.ts",
 		"./vs/workbench/parts/surveys/electron-browser/nps.contribution.ts",
 		"./vs/workbench/parts/tasks/common/problemCollectors.ts",
 		"./vs/workbench/parts/tasks/common/problemMatcher.ts",
@@ -659,6 +729,7 @@
 		"./vs/workbench/parts/tasks/electron-browser/jsonSchemaCommon.ts",
 		"./vs/workbench/parts/tasks/electron-browser/runAutomaticTasks.ts",
 		"./vs/workbench/parts/tasks/node/tasks.ts",
+		"./vs/workbench/parts/tasks/test/common/problemMatcher.test.ts",
 		"./vs/workbench/parts/terminal/browser/terminalTab.ts",
 		"./vs/workbench/parts/terminal/browser/terminalWidgetManager.ts",
 		"./vs/workbench/parts/terminal/common/terminal.ts",
@@ -673,9 +744,11 @@
 		"./vs/workbench/parts/terminal/node/terminalProcess.ts",
 		"./vs/workbench/parts/terminal/node/terminalProcessExtHostProxy.ts",
 		"./vs/workbench/parts/terminal/node/windowsShellHelper.ts",
+		"./vs/workbench/parts/terminal/test/node/terminalCommandTracker.test.ts",
 		"./vs/workbench/parts/url/electron-browser/url.contribution.ts",
 		"./vs/workbench/parts/webview/electron-browser/webviewProtocols.ts",
 		"./vs/workbench/parts/welcome/gettingStarted/electron-browser/gettingStarted.ts",
+		"./vs/workbench/parts/welcome/gettingStarted/test/common/gettingStarted.test.ts",
 		"./vs/workbench/parts/welcome/page/electron-browser/vs_code_welcome_page.ts",
 		"./vs/workbench/parts/welcome/walkThrough/node/walkThroughUtils.ts",
 		"./vs/workbench/services/actions/electron-browser/menusExtensionPoint.ts",
@@ -708,6 +781,7 @@
 		"./vs/workbench/services/files/electron-browser/encoding.ts",
 		"./vs/workbench/services/files/node/watcher/common.ts",
 		"./vs/workbench/services/files/node/watcher/nsfw/nsfwWatcherService.ts",
+		"./vs/workbench/services/files/node/watcher/nsfw/test/nsfwWatcherService.test.ts",
 		"./vs/workbench/services/files/node/watcher/nsfw/watcher.ts",
 		"./vs/workbench/services/files/node/watcher/nsfw/watcherApp.ts",
 		"./vs/workbench/services/files/node/watcher/nsfw/watcherIpc.ts",
@@ -720,6 +794,7 @@
 		"./vs/workbench/services/files/node/watcher/win32/csharpWatcherService.ts",
 		"./vs/workbench/services/files/node/watcher/win32/watcherService.ts",
 		"./vs/workbench/services/files/test/electron-browser/utils.ts",
+		"./vs/workbench/services/files/test/electron-browser/watcher.test.ts",
 		"./vs/workbench/services/hash/common/hashService.ts",
 		"./vs/workbench/services/hash/node/hashService.ts",
 		"./vs/workbench/services/issue/common/issue.ts",
@@ -753,6 +828,8 @@
 		"./vs/workbench/services/search/node/searchIpc.ts",
 		"./vs/workbench/services/search/node/textSearchAdapter.ts",
 		"./vs/workbench/services/search/node/textSearchManager.ts",
+		"./vs/workbench/services/search/test/common/searchHelpers.test.ts",
+		"./vs/workbench/services/search/test/node/ripgrepFileSearch.test.ts",
 		"./vs/workbench/services/search/test/node/ripgrepTextSearchEngine.test.ts",
 		"./vs/workbench/services/search/test/node/textSearchManager.test.ts",
 		"./vs/workbench/services/textMate/electron-browser/TMGrammars.ts",

src/vs/base/parts/ipc/test/node/ipc.cp.test.ts

@@ -39,7 +39,7 @@ suite('IPC, Child Process', () => {
 			service.onMarco(({ answer }) => {
 				try {
 					assert.equal(answer, 'polo');
-					c(null);
+					c(void 0);
 				} catch (err) {
 					e(err);
 				}