Skip to content
体验新版
项目
组织
正在加载...
登录
切换导航
打开侧边栏
掘金者说
vscode
提交
dad8b644
V
vscode
项目概览
掘金者说
/
vscode
与 Fork 源项目一致
从无法访问的项目Fork
通知
1
Star
0
Fork
0
代码
文件
提交
分支
Tags
贡献者
分支图
Diff
Issue
0
列表
看板
标记
里程碑
合并请求
0
DevOps
流水线
流水线任务
计划
Wiki
0
Wiki
分析
仓库
DevOps
项目成员
Pages
V
vscode
项目概览
项目概览
详情
发布
仓库
仓库
文件
提交
分支
标签
贡献者
分支图
比较
Issue
0
Issue
0
列表
看板
标记
里程碑
合并请求
0
合并请求
0
Pages
DevOps
DevOps
流水线
流水线任务
计划
分析
分析
仓库分析
DevOps
Wiki
0
Wiki
成员
成员
收起侧边栏
关闭侧边栏
动态
分支图
创建新Issue
流水线任务
提交
Issue看板
体验新版 GitCode,发现更多精彩内容 >>
提交
dad8b644
编写于
12月 10, 2018
作者:
B
Benjamin Pasero
浏览文件
操作
浏览文件
下载
电子邮件补丁
差异文件
debt - dispose action items that are pulled from actionbar
上级
5c298d1f
变更
1
隐藏空白更改
内联
并排
Showing
1 changed file
with
10 addition
and
11 deletion
+10
-11
src/vs/base/browser/ui/actionbar/actionbar.ts
src/vs/base/browser/ui/actionbar/actionbar.ts
+10
-11
未找到文件。
src/vs/base/browser/ui/actionbar/actionbar.ts
浏览文件 @
dad8b644
...
...
@@ -376,7 +376,7 @@ export interface IActionBarOptions {
triggerKeys
?:
ActionTrigger
;
}
le
t
defaultOptions
:
IActionBarOptions
=
{
cons
t
defaultOptions
:
IActionBarOptions
=
{
orientation
:
ActionsOrientation
.
HORIZONTAL
,
context
:
null
,
triggerKeys
:
{
...
...
@@ -473,7 +473,7 @@ export class ActionBar extends Disposable implements IActionRunner {
}
this
.
_register
(
DOM
.
addDisposableListener
(
this
.
domNode
,
DOM
.
EventType
.
KEY_DOWN
,
e
=>
{
le
t
event
=
new
StandardKeyboardEvent
(
e
);
cons
t
event
=
new
StandardKeyboardEvent
(
e
);
let
eventHandled
=
true
;
if
(
event
.
equals
(
previousKey
))
{
...
...
@@ -498,7 +498,7 @@ export class ActionBar extends Disposable implements IActionRunner {
}));
this
.
_register
(
DOM
.
addDisposableListener
(
this
.
domNode
,
DOM
.
EventType
.
KEY_UP
,
e
=>
{
le
t
event
=
new
StandardKeyboardEvent
(
e
);
cons
t
event
=
new
StandardKeyboardEvent
(
e
);
// Run action on Enter/Space
if
(
this
.
isTriggerKeyEvent
(
event
))
{
...
...
@@ -560,7 +560,7 @@ export class ActionBar extends Disposable implements IActionRunner {
private
updateFocusedItem
():
void
{
for
(
let
i
=
0
;
i
<
this
.
actionsList
.
children
.
length
;
i
++
)
{
le
t
elem
=
this
.
actionsList
.
children
[
i
];
cons
t
elem
=
this
.
actionsList
.
children
[
i
];
if
(
DOM
.
isAncestor
(
document
.
activeElement
,
elem
))
{
this
.
focusedItem
=
i
;
break
;
...
...
@@ -657,8 +657,8 @@ export class ActionBar extends Disposable implements IActionRunner {
pull
(
index
:
number
):
void
{
if
(
index
>=
0
&&
index
<
this
.
items
.
length
)
{
this
.
items
.
splice
(
index
,
1
);
this
.
actionsList
.
removeChild
(
this
.
actionsList
.
childNodes
[
index
]);
dispose
(
this
.
items
.
splice
(
index
,
1
));
}
}
...
...
@@ -706,7 +706,7 @@ export class ActionBar extends Disposable implements IActionRunner {
this
.
focusedItem
=
this
.
items
.
length
-
1
;
}
le
t
startIndex
=
this
.
focusedItem
;
cons
t
startIndex
=
this
.
focusedItem
;
let
item
:
IActionItem
;
do
{
...
...
@@ -726,7 +726,7 @@ export class ActionBar extends Disposable implements IActionRunner {
this
.
focusedItem
=
0
;
}
le
t
startIndex
=
this
.
focusedItem
;
cons
t
startIndex
=
this
.
focusedItem
;
let
item
:
IActionItem
;
do
{
...
...
@@ -752,9 +752,8 @@ export class ActionBar extends Disposable implements IActionRunner {
}
for
(
let
i
=
0
;
i
<
this
.
items
.
length
;
i
++
)
{
let
item
=
this
.
items
[
i
];
let
actionItem
=
item
;
const
item
=
this
.
items
[
i
];
const
actionItem
=
item
;
if
(
i
===
this
.
focusedItem
)
{
if
(
types
.
isFunction
(
actionItem
.
isEnabled
))
{
...
...
@@ -778,7 +777,7 @@ export class ActionBar extends Disposable implements IActionRunner {
}
// trigger action
le
t
actionItem
=
this
.
items
[
this
.
focusedItem
];
cons
t
actionItem
=
this
.
items
[
this
.
focusedItem
];
if
(
actionItem
instanceof
BaseActionItem
)
{
const
context
=
(
actionItem
.
_context
===
null
||
actionItem
.
_context
===
undefined
)
?
event
:
actionItem
.
_context
;
this
.
run
(
actionItem
.
_action
,
context
);
...
...
编辑
预览
Markdown
is supported
0%
请重试
或
添加新附件
.
添加附件
取消
You are about to add
0
people
to the discussion. Proceed with caution.
先完成此消息的编辑!
取消
想要评论请
注册
或
登录