Don't await profiles for custom ptys, ensure createTerminal returns

Fixes #132519
Fixes microsoft/vscode-remote-release#5556

src/vs/workbench/api/browser/mainThreadTerminalService.ts

@@ -140,13 +140,15 @@ export class MainThreadTerminalService implements MainThreadTerminalServiceShape
 			isExtensionOwnedTerminal: launchConfig.isExtensionOwnedTerminal,
 			useShellEnvironment: launchConfig.useShellEnvironment,
 		};
-		this._extHostTerminals.set(extHostTerminalId, new Promise(async r => {
+		const terminal = new Promise<ITerminalInstance>(async r => {
 			const terminal = await this._terminalService.createTerminal({
 				config: shellLaunchConfig,
 				location: await this._deserializeParentTerminal(launchConfig.location)
 			});
 			r(terminal);
-		}));
+		});
+		this._extHostTerminals.set(extHostTerminalId, terminal);
+		await terminal;
 	}
 
 	private async _deserializeParentTerminal(location?: TerminalLocation | TerminalEditorLocationOptions | { parentTerminal: ExtHostTerminalIdentifier } | { splitActiveTerminal: boolean, location?: TerminalLocation }): Promise<TerminalLocation | TerminalEditorLocationOptions | { parentTerminal: ITerminalInstance } | { splitActiveTerminal: boolean } | undefined> {

src/vs/workbench/contrib/terminal/browser/terminalService.ts

@@ -1155,7 +1155,8 @@ export class TerminalService implements ITerminalService {
 
 
 	async createTerminal(options?: ICreateTerminalOptions): Promise<ITerminalInstance> {
-		if (!this._availableProfiles) {
+		const isPtyTerminal = options?.config && 'customPtyImplementation' in options.config;
+		if (!isPtyTerminal && !this._availableProfiles) {
 			await this._refreshAvailableProfilesNow();
 		}
 		const config = options?.config || this._availableProfiles?.find(p => p.profileName === this._defaultProfileName);