#28538 Let Configuration object gets the root given the resource from workspace

src/vs/platform/configuration/common/configuration.ts

@@ -301,10 +301,27 @@ export class Configuration<T> {
 	}
 
 	private getConfigurationModel<C>(overrides: IConfigurationOverrides): ConfigurationModel<any> {
-		let configurationModel = overrides.resource ? this._foldersConsolidatedConfigurations.get(overrides.resource) || this._workspaceConfiguration : this._workspaceConfiguration;
+		let configurationModel = this.getConfigurationForResource(overrides);
 		return overrides.language ? configurationModel.override<T>(overrides.language) : configurationModel;
 	}
 
+	private getConfigurationForResource({ resource }: IConfigurationOverrides): ConfigurationModel<any> {
+		if (!this.workspace) {
+			return this._globalConfiguration;
+		}
+
+		if (!resource) {
+			return this._workspaceConfiguration;
+		}
+
+		const root = this._workspace.getRoot(resource);
+		if (!root) {
+			return this._workspaceConfiguration;
+		}
+
+		return this._foldersConsolidatedConfigurations.get(root) || this._workspaceConfiguration;
+	}
+
 	public toData(): IConfigurationData<any> {
 		return {
 			defaults: {

src/vs/workbench/services/configuration/node/configuration.ts

@@ -161,7 +161,6 @@ export class WorkspaceConfigurationService extends Disposable implements IWorksp
 	}
 
 	public getConfiguration<C>(section?: string, overrides?: IConfigurationOverrides): C {
-		overrides = overrides && overrides.resource ? { ...overrides, resource: this.getRoot(overrides.resource) } : overrides;
 		return this._configuration.getValue<C>(section, overrides);
 	}