Skip to content
体验新版
项目
组织
正在加载...
登录
切换导航
打开侧边栏
掘金者说
vscode
提交
b76d3f01
V
vscode
项目概览
掘金者说
/
vscode
与 Fork 源项目一致
从无法访问的项目Fork
通知
1
Star
0
Fork
0
代码
文件
提交
分支
Tags
贡献者
分支图
Diff
Issue
0
列表
看板
标记
里程碑
合并请求
0
DevOps
流水线
流水线任务
计划
Wiki
0
Wiki
分析
仓库
DevOps
项目成员
Pages
V
vscode
项目概览
项目概览
详情
发布
仓库
仓库
文件
提交
分支
标签
贡献者
分支图
比较
Issue
0
Issue
0
列表
看板
标记
里程碑
合并请求
0
合并请求
0
Pages
DevOps
DevOps
流水线
流水线任务
计划
分析
分析
仓库分析
DevOps
Wiki
0
Wiki
成员
成员
收起侧边栏
关闭侧边栏
动态
分支图
创建新Issue
流水线任务
提交
Issue看板
体验新版 GitCode,发现更多精彩内容 >>
提交
b76d3f01
编写于
3月 04, 2020
作者:
C
Connor Peet
浏览文件
操作
浏览文件
下载
电子邮件补丁
差异文件
experiments: rename to action2 for new experiments
上级
4c59cdd2
变更
2
隐藏空白更改
内联
并排
Showing
2 changed file
with
31 addition
and
5 deletion
+31
-5
src/vs/workbench/contrib/experiments/common/experimentService.ts
...workbench/contrib/experiments/common/experimentService.ts
+7
-5
src/vs/workbench/contrib/experiments/test/electron-browser/experimentService.test.ts
...periments/test/electron-browser/experimentService.test.ts
+24
-0
未找到文件。
src/vs/workbench/contrib/experiments/common/experimentService.ts
浏览文件 @
b76d3f01
...
...
@@ -93,7 +93,7 @@ interface IExperimentStorageState {
* be incremented when adding a condition, otherwise experiments might activate
* on older versions of VS Code where not intended.
*/
export
const
currentSchemaVersion
=
2
;
export
const
currentSchemaVersion
=
3
;
interface
IRawExperiment
{
id
:
string
;
...
...
@@ -128,6 +128,7 @@ interface IRawExperiment {
userProbability
?:
number
;
};
action
?:
IExperimentAction
;
action2
?:
IExperimentAction
;
}
interface
IActivationEventRecord
{
...
...
@@ -310,10 +311,11 @@ export class ExperimentService extends Disposable implements IExperimentService
state
:
!!
experiment
.
enabled
?
ExperimentState
.
Evaluating
:
ExperimentState
.
NoRun
};
if
(
experiment
.
action
)
{
const
action
=
experiment
.
action2
||
experiment
.
action
;
if
(
action
)
{
processedExperiment
.
action
=
{
type
:
ExperimentActionType
[
experiment
.
action
.
type
]
||
ExperimentActionType
.
Custom
,
properties
:
experiment
.
action
.
properties
type
:
ExperimentActionType
[
action
.
type
]
||
ExperimentActionType
.
Custom
,
properties
:
action
.
properties
};
if
(
processedExperiment
.
action
.
type
===
ExperimentActionType
.
Prompt
)
{
((
<
IExperimentActionPromptProperties
>
processedExperiment
.
action
.
properties
).
commands
||
[]).
forEach
(
x
=>
{
...
...
@@ -557,7 +559,7 @@ export class ExperimentService extends Disposable implements IExperimentService
if
(
typeof
latestExperimentState
.
editCount
===
'
number
'
&&
latestExperimentState
.
editCount
>=
fileEdits
.
minEditCount
)
{
processedExperiment
.
state
=
latestExperimentState
.
state
=
(
typeof
condition
.
userProbability
===
'
number
'
&&
Math
.
random
()
<
condition
.
userProbability
&&
this
.
checkExperimentDependencies
(
experiment
))
?
ExperimentState
.
Run
:
ExperimentState
.
NoRun
;
this
.
storageService
.
store
(
storageKey
,
JSON
.
stringify
(
latestExperimentState
),
StorageScope
.
GLOBAL
);
if
(
latestExperimentState
.
state
===
ExperimentState
.
Run
&&
experiment
.
action
&&
ExperimentActionType
[
e
xperiment
.
action
.
type
]
===
ExperimentActionType
.
Prompt
)
{
if
(
latestExperimentState
.
state
===
ExperimentState
.
Run
&&
processedExperiment
.
action
&&
ExperimentActionType
[
processedE
xperiment
.
action
.
type
]
===
ExperimentActionType
.
Prompt
)
{
this
.
fireRunExperiment
(
processedExperiment
);
}
}
...
...
src/vs/workbench/contrib/experiments/test/electron-browser/experimentService.test.ts
浏览文件 @
b76d3f01
...
...
@@ -768,6 +768,7 @@ suite('Experiment Service', () => {
testObject
=
instantiationService
.
createInstance
(
TestExperimentService
);
return
testObject
.
getExperimentById
(
'
experiment1
'
).
then
(
result
=>
{
assert
.
equal
(
result
.
enabled
,
false
);
assert
.
equal
(
result
.
action
?.
type
,
'
Prompt
'
);
assert
.
equal
(
result
.
state
,
ExperimentState
.
NoRun
);
return
testObject
.
getCuratedExtensionsList
(
curatedExtensionsKey
).
then
(
curatedList
=>
{
assert
.
equal
(
curatedList
.
length
,
0
);
...
...
@@ -775,6 +776,29 @@ suite('Experiment Service', () => {
});
});
test
(
'
Maps action2 to action.
'
,
()
=>
{
experimentData
=
{
experiments
:
[
{
id
:
'
experiment1
'
,
enabled
:
false
,
action2
:
{
type
:
'
Prompt
'
,
properties
:
{
promptText
:
'
Hello world
'
,
commands
:
[]
}
}
}
]
};
testObject
=
instantiationService
.
createInstance
(
TestExperimentService
);
return
testObject
.
getExperimentById
(
'
experiment1
'
).
then
(
result
=>
{
assert
.
equal
(
result
.
action
?.
type
,
'
Prompt
'
);
});
});
test
(
'
Experiment that is disabled or deleted should be removed from storage
'
,
()
=>
{
experimentData
=
{
experiments
:
[
...
...
编辑
预览
Markdown
is supported
0%
请重试
或
添加新附件
.
添加附件
取消
You are about to add
0
people
to the discussion. Proceed with caution.
先完成此消息的编辑!
取消
想要评论请
注册
或
登录