提交 ad7fd5c5 编写于 作者: P Pine Wu

Drop alwaysRevealInlineDetails

上级 7f8018fb
......@@ -2495,10 +2495,6 @@ export interface ISuggestOptions {
* Max suggestions to show in suggestions. Defaults to 12.
*/
maxVisibleSuggestions?: number;
/**
* Always show inline details
*/
alwaysRevealInlineDetails?: boolean;
/**
* Show method-suggestions.
*/
......@@ -2618,7 +2614,6 @@ class EditorSuggest extends BaseEditorOption<EditorOption.suggest, InternalSugge
shareSuggestSelections: false,
showIcons: true,
maxVisibleSuggestions: 12,
alwaysRevealInlineDetails: false,
showMethods: true,
showFunctions: true,
showConstructors: true,
......@@ -2695,11 +2690,6 @@ class EditorSuggest extends BaseEditorOption<EditorOption.suggest, InternalSugge
maximum: 15,
description: nls.localize('suggest.maxVisibleSuggestions', "Controls how many suggestions IntelliSense will show before showing a scrollbar (maximum 15).")
},
'editor.suggest.alwaysRevealInlineDetails': {
type: 'boolean',
default: defaults.alwaysRevealInlineDetails,
description: nls.localize('suggest.alwaysRevealInlineDetails', "Controls whether to always show inline details")
},
'editor.suggest.filteredTypes': {
type: 'object',
deprecationMessage: nls.localize('deprecated', "This setting is deprecated, please use separate settings like 'editor.suggest.showKeywords' or 'editor.suggest.showSnippets' instead.")
......@@ -2852,7 +2842,6 @@ class EditorSuggest extends BaseEditorOption<EditorOption.suggest, InternalSugge
shareSuggestSelections: EditorBooleanOption.boolean(input.shareSuggestSelections, this.defaultValue.shareSuggestSelections),
showIcons: EditorBooleanOption.boolean(input.showIcons, this.defaultValue.showIcons),
maxVisibleSuggestions: EditorIntOption.clampedInt(input.maxVisibleSuggestions, this.defaultValue.maxVisibleSuggestions, 1, 15),
alwaysRevealInlineDetails: EditorBooleanOption.boolean(input.alwaysRevealInlineDetails, this.defaultValue.alwaysRevealInlineDetails),
showMethods: EditorBooleanOption.boolean(input.showMethods, this.defaultValue.showMethods),
showFunctions: EditorBooleanOption.boolean(input.showFunctions, this.defaultValue.showFunctions),
showConstructors: EditorBooleanOption.boolean(input.showConstructors, this.defaultValue.showConstructors),
......
......@@ -526,9 +526,7 @@ export class SuggestWidget implements IContentWidget, IListVirtualDelegate<Compl
this.details = instantiationService.createInstance(SuggestionDetails, this.element, this, this.editor, markdownRenderer, triggerKeybindingLabel);
const applyIconStyle = () => toggleClass(this.element, 'no-icons', !this.editor.getOption(EditorOption.suggest).showIcons);
const applyAlwaysRevealInlineDetailsStyle = () => toggleClass(this.element, 'always-reveal-inline-details', this.editor.getOption(EditorOption.suggest).alwaysRevealInlineDetails);
applyIconStyle();
applyAlwaysRevealInlineDetailsStyle();
let renderer = instantiationService.createInstance(Renderer, this, this.editor, triggerKeybindingLabel);
......@@ -552,7 +550,6 @@ export class SuggestWidget implements IContentWidget, IListVirtualDelegate<Compl
this.toDispose.add(this.editor.onDidChangeConfiguration(e => {
if (e.hasChanged(EditorOption.suggest)) {
applyIconStyle();
applyAlwaysRevealInlineDetailsStyle();
}
}));
......
......@@ -41,7 +41,6 @@ suite('CompletionModel', function () {
shareSuggestSelections: false,
showIcons: true,
maxVisibleSuggestions: 12,
alwaysRevealInlineDetails: false,
showMethods: true,
showFunctions: true,
showConstructors: true,
......
......@@ -3381,10 +3381,6 @@ declare namespace monaco.editor {
* Max suggestions to show in suggestions. Defaults to 12.
*/
maxVisibleSuggestions?: number;
/**
* Always show inline details
*/
alwaysRevealInlineDetails?: boolean;
/**
* Show method-suggestions.
*/
......
Markdown is supported
0% .
You are about to add 0 people to the discussion. Proceed with caution.
先完成此消息的编辑!
想要评论请 注册