Add support for terminal.integrated.enableBold back

Fixes #35666

src/vs/workbench/parts/terminal/common/terminal.ts

@@ -58,7 +58,7 @@ export interface ITerminalConfiguration {
 		osx: string[];
 		windows: string[];
 	};
-	// enableBold: boolean;
+	enableBold: boolean;
 	rightClickCopyPaste: boolean;
 	cursorBlinking: boolean;
 	cursorStyle: string;

src/vs/workbench/parts/terminal/electron-browser/terminal.contribution.ts

@@ -140,11 +140,11 @@ configurationRegistry.registerConfiguration({
 			'type': 'number',
 			'default': 1
 		},
-		// 'terminal.integrated.enableBold': {
-		// 	'type': 'boolean',
-		// 	'description': nls.localize('terminal.integrated.enableBold', "Whether to enable bold text within the terminal, this requires support from the terminal shell."),
-		// 	'default': true
-		// },
+		'terminal.integrated.enableBold': {
+			'type': 'boolean',
+			'description': nls.localize('terminal.integrated.enableBold', "Whether to enable bold text within the terminal, note that this requires support from the terminal shell."),
+			'default': true
+		},
 		'terminal.integrated.cursorBlinking': {
 			'description': nls.localize('terminal.integrated.cursorBlinking', "Controls whether the terminal cursor blinks."),
 			'type': 'boolean',

src/vs/workbench/parts/terminal/electron-browser/terminalInstance.ts

@@ -266,7 +266,8 @@ export class TerminalInstance implements ITerminalInstance {
 			theme: this._getXtermTheme(),
 			fontFamily: font.fontFamily,
 			fontSize: font.fontSize,
-			lineHeight: font.lineHeight
+			lineHeight: font.lineHeight,
+			enableBold: this._configHelper.config.enableBold
 		});
 		if (this._shellLaunchConfig.initialText) {
 			this._xterm.writeln(this._shellLaunchConfig.initialText);
@@ -923,6 +924,9 @@ export class TerminalInstance implements ITerminalInstance {
 			if (this._xterm.getOption('fontFamily') !== font.fontFamily) {
 				this._xterm.setOption('fontFamily', font.fontFamily);
 			}
+			if (this._xterm.getOption('enableBold') !== this._configHelper.config.enableBold) {
+				this._xterm.setOption('enableBold', this._configHelper.config.enableBold);
+			}
 
 			this._xterm.resize(this._cols, this._rows);
 			this._xterm.element.style.width = terminalWidth + 'px';

src/vs/workbench/parts/terminal/electron-browser/terminalPanel.ts

@@ -302,8 +302,6 @@ export class TerminalPanel extends Panel {
 		this._font = this._terminalService.configHelper.getFont();
 		// TODO: Can we support ligatures?
 		// dom.toggleClass(this._parentDomElement, 'enable-ligatures', this._terminalService.configHelper.config.fontLigatures);
-		// TODO: How to handle Disable bold?
-		// dom.toggleClass(this._parentDomElement, 'disable-bold', !this._terminalService.configHelper.config.enableBold);
 		this.layout(new Dimension(this._parentDomElement.offsetWidth, this._parentDomElement.offsetHeight));
 	}