Skip to content
体验新版
项目
组织
正在加载...
登录
切换导航
打开侧边栏
掘金者说
vscode
提交
a234f13c
V
vscode
项目概览
掘金者说
/
vscode
与 Fork 源项目一致
从无法访问的项目Fork
通知
1
Star
0
Fork
0
代码
文件
提交
分支
Tags
贡献者
分支图
Diff
Issue
0
列表
看板
标记
里程碑
合并请求
0
DevOps
流水线
流水线任务
计划
Wiki
0
Wiki
分析
仓库
DevOps
项目成员
Pages
V
vscode
项目概览
项目概览
详情
发布
仓库
仓库
文件
提交
分支
标签
贡献者
分支图
比较
Issue
0
Issue
0
列表
看板
标记
里程碑
合并请求
0
合并请求
0
Pages
DevOps
DevOps
流水线
流水线任务
计划
分析
分析
仓库分析
DevOps
Wiki
0
Wiki
成员
成员
收起侧边栏
关闭侧边栏
动态
分支图
创建新Issue
流水线任务
提交
Issue看板
体验新版 GitCode,发现更多精彩内容 >>
未验证
提交
a234f13c
编写于
1月 18, 2020
作者:
A
Alex Dima
浏览文件
操作
浏览文件
下载
电子邮件补丁
差异文件
Fixes #40127: Render separate <span>s for before and after decorations in empty line case
上级
c6bf931b
变更
3
隐藏空白更改
内联
并排
Showing
3 changed file
with
18 addition
and
7 deletion
+18
-7
src/vs/editor/browser/viewParts/lines/viewLine.ts
src/vs/editor/browser/viewParts/lines/viewLine.ts
+8
-1
src/vs/editor/common/viewLayout/viewLineRenderer.ts
src/vs/editor/common/viewLayout/viewLineRenderer.ts
+7
-4
src/vs/editor/test/common/viewLayout/viewLineRenderer.test.ts
...vs/editor/test/common/viewLayout/viewLineRenderer.test.ts
+3
-2
未找到文件。
src/vs/editor/browser/viewParts/lines/viewLine.ts
浏览文件 @
a234f13c
...
...
@@ -514,9 +514,16 @@ class RenderedViewLine implements IRenderedViewLine {
return
0
;
}
if
(
this
.
_containsForeignElements
===
ForeignElementType
.
Before
)
{
// We have foreign element before the (empty) line
// We have foreign element
s
before the (empty) line
return
this
.
getWidth
();
}
// We have foreign elements before & after the (empty) line
const
readingTarget
=
this
.
_getReadingTarget
(
domNode
);
if
(
readingTarget
.
firstChild
)
{
return
(
<
HTMLSpanElement
>
readingTarget
.
firstChild
).
offsetWidth
;
}
else
{
return
0
;
}
}
if
(
this
.
_pixelOffsetCache
!==
null
)
{
...
...
src/vs/editor/common/viewLayout/viewLineRenderer.ts
浏览文件 @
a234f13c
...
...
@@ -318,21 +318,24 @@ export function renderViewLine(input: RenderLineInput, sb: IStringBuilder): Rend
if
(
input
.
lineDecorations
.
length
>
0
)
{
// This line is empty, but it contains inline decorations
let
classNames
:
string
[]
=
[];
const
beforeClassNames
:
string
[]
=
[];
const
afterClassNames
:
string
[]
=
[];
for
(
let
i
=
0
,
len
=
input
.
lineDecorations
.
length
;
i
<
len
;
i
++
)
{
const
lineDecoration
=
input
.
lineDecorations
[
i
];
if
(
lineDecoration
.
type
===
InlineDecorationType
.
Before
)
{
c
lassNames
.
push
(
input
.
lineDecorations
[
i
].
className
);
beforeC
lassNames
.
push
(
input
.
lineDecorations
[
i
].
className
);
containsForeignElements
|=
ForeignElementType
.
Before
;
}
if
(
lineDecoration
.
type
===
InlineDecorationType
.
After
)
{
c
lassNames
.
push
(
input
.
lineDecorations
[
i
].
className
);
afterC
lassNames
.
push
(
input
.
lineDecorations
[
i
].
className
);
containsForeignElements
|=
ForeignElementType
.
After
;
}
}
if
(
containsForeignElements
!==
ForeignElementType
.
None
)
{
content
=
`<span><span class="
${
classNames
.
join
(
'
'
)}
"></span></span>`
;
const
beforeSpan
=
(
beforeClassNames
.
length
>
0
?
`<span class="
${
beforeClassNames
.
join
(
'
'
)}
"></span>`
:
``
);
const
afterSpan
=
(
afterClassNames
.
length
>
0
?
`<span class="
${
afterClassNames
.
join
(
'
'
)}
"></span>`
:
``
);
content
=
`<span>
${
beforeSpan
}${
afterSpan
}
</span>`
;
}
}
...
...
src/vs/editor/test/common/viewLayout/viewLineRenderer.test.ts
浏览文件 @
a234f13c
...
...
@@ -1385,7 +1385,7 @@ suite('viewLineRenderer.renderLine 2', () => {
assert
.
deepEqual
(
actual
.
html
,
expected
);
});
test
(
'
issue #37401: Allow both before and after decorations on empty line
'
,
()
=>
{
test
(
'
issue #37401
#40127
: Allow both before and after decorations on empty line
'
,
()
=>
{
let
actual
=
renderViewLine
(
new
RenderLineInput
(
true
,
...
...
@@ -1412,7 +1412,8 @@ suite('viewLineRenderer.renderLine 2', () => {
let
expected
=
[
'
<span>
'
,
'
<span class="before after"></span>
'
,
'
<span class="before"></span>
'
,
'
<span class="after"></span>
'
,
'
</span>
'
].
join
(
''
);
...
...
编辑
预览
Markdown
is supported
0%
请重试
或
添加新附件
.
添加附件
取消
You are about to add
0
people
to the discussion. Proceed with caution.
先完成此消息的编辑!
取消
想要评论请
注册
或
登录