Remove moveCursorWhenScrolling for now from stand-up feedback

src/vs/editor/common/config/commonEditorConfig.ts

@@ -166,7 +166,6 @@ class InternalEditorOptionsHelper {
 			outlineMarkers: toBoolean(opts.outlineMarkers),
 			referenceInfos: toBoolean(opts.referenceInfos),
 			renderWhitespace: toBoolean(opts.renderWhitespace),
-			moveCursorWhenScrolling: toBoolean(opts.moveCursorWhenScrolling),
 
 			layoutInfo: layoutInfo,
 			stylingInfo: {
@@ -818,11 +817,6 @@ configurationRegistry.registerConfiguration({
 			'default': DefaultConfig.editor.referenceInfos,
 			'description': nls.localize('referenceInfos', "Controls if the editor shows reference information for the modes that support it")
 		},
-		'editor.moveCursorWhenScrolling' : {
-			'type': 'boolean',
-			'default': DefaultConfig.editor.moveCursorWhenScrolling,
-			'description': nls.localize('moveCursorWhenScrolling', "Controls if the edition cursor moves when the user scrolls the editor line by line")
-		},
 		'diffEditor.renderSideBySide' : {
 			'type': 'boolean',
 			'default': true,

src/vs/editor/common/config/defaultConfig.ts

@@ -62,7 +62,6 @@ class ConfigClass implements IConfiguration {
 			outlineMarkers: false,
 			referenceInfos: true,
 			renderWhitespace: false,
-			moveCursorWhenScrolling: false,
 
 			tabSize: 4,
 			insertSpaces: true,

src/vs/editor/common/controller/cursor.ts

@@ -1322,18 +1322,10 @@ export class Cursor extends EventEmitter {
 	}
 
 	private _scrollUp(isPaged: boolean, ctx: IMultipleCursorOperationContext): boolean {
-		if (this.configuration.editor.moveCursorWhenScrolling) {
-			if (!this._moveUp(false, isPaged, ctx)) {
-				return false;
-			}
-		}
 		ctx.requestScrollDeltaLines = isPaged ? -this.configuration.editor.pageSize : -1;
 	}
 
 	private _scrollDown(isPaged: boolean, ctx: IMultipleCursorOperationContext): boolean {
-		if (this.configuration.editor.moveCursorWhenScrolling) {
-			if (!this._moveDown(false, isPaged, ctx)) return false;
-		}
 		ctx.requestScrollDeltaLines = isPaged ? this.configuration.editor.pageSize : 1;
 	}
 

src/vs/editor/common/editorCommon.ts

@@ -482,11 +482,6 @@ export interface ICommonEditorOptions {
 	 * Defaults to false.
 	 */
 	renderWhitespace?: boolean;
-	/**
-	 * Make the cursor move with scrolling.
-	 * Defaults to false.
-	 */
-	moveCursorWhenScrolling?: boolean;
 }
 
 /**
@@ -615,7 +610,6 @@ export interface IInternalEditorOptions {
 	outlineMarkers: boolean;
 	referenceInfos: boolean;
 	renderWhitespace: boolean;
-	moveCursorWhenScrolling: boolean;
 
 	// ---- Options that are computed