Skip to content
体验新版
项目
组织
正在加载...
登录
切换导航
打开侧边栏
掘金者说
vscode
提交
914c6d96
V
vscode
项目概览
掘金者说
/
vscode
与 Fork 源项目一致
从无法访问的项目Fork
通知
1
Star
0
Fork
0
代码
文件
提交
分支
Tags
贡献者
分支图
Diff
Issue
0
列表
看板
标记
里程碑
合并请求
0
DevOps
流水线
流水线任务
计划
Wiki
0
Wiki
分析
仓库
DevOps
项目成员
Pages
V
vscode
项目概览
项目概览
详情
发布
仓库
仓库
文件
提交
分支
标签
贡献者
分支图
比较
Issue
0
Issue
0
列表
看板
标记
里程碑
合并请求
0
合并请求
0
Pages
DevOps
DevOps
流水线
流水线任务
计划
分析
分析
仓库分析
DevOps
Wiki
0
Wiki
成员
成员
收起侧边栏
关闭侧边栏
动态
分支图
创建新Issue
流水线任务
提交
Issue看板
体验新版 GitCode,发现更多精彩内容 >>
提交
914c6d96
编写于
11月 09, 2018
作者:
A
Alex Dima
浏览文件
操作
浏览文件
下载
电子邮件补丁
差异文件
More native promise adoption
上级
cc785ad4
变更
2
隐藏空白更改
内联
并排
Showing
2 changed file
with
7 addition
and
9 deletion
+7
-9
src/vs/workbench/services/extensions/node/rpcProtocol.ts
src/vs/workbench/services/extensions/node/rpcProtocol.ts
+4
-5
src/vs/workbench/services/extensions/test/node/rpcProtocol.test.ts
...rkbench/services/extensions/test/node/rpcProtocol.test.ts
+3
-4
未找到文件。
src/vs/workbench/services/extensions/node/rpcProtocol.ts
浏览文件 @
914c6d96
...
...
@@ -12,7 +12,6 @@ import { Disposable } from 'vs/base/common/lifecycle';
import
{
MarshalledObject
}
from
'
vs/base/common/marshalling
'
;
import
{
URI
}
from
'
vs/base/common/uri
'
;
import
{
IURITransformer
}
from
'
vs/base/common/uriIpc
'
;
import
{
TPromise
}
from
'
vs/base/common/winjs.base
'
;
import
{
IMessagePassingProtocol
}
from
'
vs/base/parts/ipc/node/ipc
'
;
import
{
LazyPromise
}
from
'
vs/workbench/services/extensions/node/lazyPromise
'
;
import
{
IRPCProtocol
,
ProxyIdentifier
,
getStringIdentifierForProxy
}
from
'
vs/workbench/services/extensions/node/proxyIdentifier
'
;
...
...
@@ -444,9 +443,9 @@ export class RPCProtocol extends Disposable implements IRPCProtocol {
private
_invokeHandler
(
rpcId
:
number
,
methodName
:
string
,
args
:
any
[]):
Thenable
<
any
>
{
try
{
return
TPromise
.
as
(
this
.
_doInvokeHandler
(
rpcId
,
methodName
,
args
));
return
Promise
.
resolve
(
this
.
_doInvokeHandler
(
rpcId
,
methodName
,
args
));
}
catch
(
err
)
{
return
TPromise
.
wrapError
(
err
);
return
Promise
.
reject
(
err
);
}
}
...
...
@@ -464,7 +463,7 @@ export class RPCProtocol extends Disposable implements IRPCProtocol {
private
_remoteCall
(
rpcId
:
number
,
methodName
:
string
,
args
:
any
[]):
Thenable
<
any
>
{
if
(
this
.
_isDisposed
)
{
return
TPromise
.
wrapError
<
any
>
(
errors
.
canceled
());
return
Promise
.
reject
<
any
>
(
errors
.
canceled
());
}
let
cancellationToken
:
CancellationToken
|
null
=
null
;
if
(
args
.
length
>
0
&&
CancellationToken
.
isCancellationToken
(
args
[
args
.
length
-
1
]))
{
...
...
@@ -473,7 +472,7 @@ export class RPCProtocol extends Disposable implements IRPCProtocol {
if
(
cancellationToken
&&
cancellationToken
.
isCancellationRequested
)
{
// No need to do anything...
return
TPromise
.
wrapError
<
any
>
(
errors
.
canceled
());
return
Promise
.
reject
<
any
>
(
errors
.
canceled
());
}
const
req
=
++
this
.
_lastMessageId
;
...
...
src/vs/workbench/services/extensions/test/node/rpcProtocol.test.ts
浏览文件 @
914c6d96
...
...
@@ -6,7 +6,6 @@
import
*
as
assert
from
'
assert
'
;
import
{
CancellationToken
,
CancellationTokenSource
}
from
'
vs/base/common/cancellation
'
;
import
{
Emitter
,
Event
}
from
'
vs/base/common/event
'
;
import
{
TPromise
}
from
'
vs/base/common/winjs.base
'
;
import
{
IMessagePassingProtocol
}
from
'
vs/base/parts/ipc/node/ipc
'
;
import
{
ProxyIdentifier
}
from
'
vs/workbench/services/extensions/node/proxyIdentifier
'
;
import
{
RPCProtocol
}
from
'
vs/workbench/services/extensions/node/rpcProtocol
'
;
...
...
@@ -34,7 +33,7 @@ suite('RPCProtocol', () => {
let
bProxy
:
BClass
;
class
BClass
{
$m
(
a1
:
any
,
a2
:
any
):
Thenable
<
any
>
{
return
TPromise
.
as
(
delegate
.
call
(
null
,
a1
,
a2
));
return
Promise
.
resolve
(
delegate
.
call
(
null
,
a1
,
a2
));
}
}
...
...
@@ -131,7 +130,7 @@ suite('RPCProtocol', () => {
test
(
'
cancelling a call via CancellationToken quickly
'
,
function
(
done
)
{
// this is an implementation which, when cancellation is triggered, will return 7
delegate
=
(
a1
:
number
,
token
:
CancellationToken
)
=>
{
return
new
T
Promise
((
resolve
,
reject
)
=>
{
return
new
Promise
((
resolve
,
reject
)
=>
{
token
.
onCancellationRequested
((
e
)
=>
{
resolve
(
7
);
});
...
...
@@ -164,7 +163,7 @@ suite('RPCProtocol', () => {
test
(
'
error promise
'
,
function
(
done
)
{
delegate
=
(
a1
:
number
,
a2
:
number
)
=>
{
return
TPromise
.
wrapError
(
undefined
);
return
Promise
.
reject
(
undefined
);
};
bProxy
.
$m
(
4
,
1
).
then
((
res
)
=>
{
assert
.
fail
(
'
unexpected
'
);
...
...
编辑
预览
Markdown
is supported
0%
请重试
或
添加新附件
.
添加附件
取消
You are about to add
0
people
to the discussion. Proceed with caution.
先完成此消息的编辑!
取消
想要评论请
注册
或
登录