Skip to content
体验新版
项目
组织
正在加载...
登录
切换导航
打开侧边栏
掘金者说
vscode
提交
86972072
V
vscode
项目概览
掘金者说
/
vscode
与 Fork 源项目一致
从无法访问的项目Fork
通知
1
Star
0
Fork
0
代码
文件
提交
分支
Tags
贡献者
分支图
Diff
Issue
0
列表
看板
标记
里程碑
合并请求
0
DevOps
流水线
流水线任务
计划
Wiki
0
Wiki
分析
仓库
DevOps
项目成员
Pages
V
vscode
项目概览
项目概览
详情
发布
仓库
仓库
文件
提交
分支
标签
贡献者
分支图
比较
Issue
0
Issue
0
列表
看板
标记
里程碑
合并请求
0
合并请求
0
Pages
DevOps
DevOps
流水线
流水线任务
计划
分析
分析
仓库分析
DevOps
Wiki
0
Wiki
成员
成员
收起侧边栏
关闭侧边栏
动态
分支图
创建新Issue
流水线任务
提交
Issue看板
体验新版 GitCode,发现更多精彩内容 >>
提交
86972072
编写于
12月 07, 2018
作者:
R
Rob Lourens
浏览文件
操作
浏览文件
下载
电子邮件补丁
差异文件
Remove TPromise#wrap calls #64596
上级
9c653ada
变更
3
隐藏空白更改
内联
并排
Showing
3 changed file
with
10 addition
and
10 deletion
+10
-10
src/vs/workbench/parts/experiments/node/experimentService.ts
src/vs/workbench/parts/experiments/node/experimentService.ts
+8
-8
src/vs/workbench/parts/experiments/test/electron-browser/experimentService.test.ts
...periments/test/electron-browser/experimentService.test.ts
+1
-1
src/vs/workbench/test/electron-browser/quickopen.perf.integrationTest.ts
...h/test/electron-browser/quickopen.perf.integrationTest.ts
+1
-1
未找到文件。
src/vs/workbench/parts/experiments/node/experimentService.ts
浏览文件 @
86972072
...
...
@@ -130,7 +130,7 @@ export class ExperimentService extends Disposable implements IExperimentService
)
{
super
();
this
.
_loadExperimentsPromise
=
TPromise
.
wrap
(
this
.
lifecycleService
.
when
(
LifecyclePhase
.
Eventually
)).
then
(()
=>
this
.
loadExperiments
());
this
.
_loadExperimentsPromise
=
Promise
.
resolve
(
this
.
lifecycleService
.
when
(
LifecyclePhase
.
Eventually
)).
then
(()
=>
this
.
loadExperiments
());
}
public
getExperimentById
(
id
:
string
):
TPromise
<
IExperiment
>
{
...
...
@@ -316,29 +316,29 @@ export class ExperimentService extends Disposable implements IExperimentService
private
shouldRunExperiment
(
experiment
:
IRawExperiment
,
processedExperiment
:
IExperiment
):
TPromise
<
ExperimentState
>
{
if
(
processedExperiment
.
state
!==
ExperimentState
.
Evaluating
)
{
return
TPromise
.
wrap
(
processedExperiment
.
state
);
return
Promise
.
resolve
(
processedExperiment
.
state
);
}
if
(
!
experiment
.
enabled
)
{
return
TPromise
.
wrap
(
ExperimentState
.
NoRun
);
return
Promise
.
resolve
(
ExperimentState
.
NoRun
);
}
if
(
!
experiment
.
condition
)
{
return
TPromise
.
wrap
(
ExperimentState
.
Run
);
return
Promise
.
resolve
(
ExperimentState
.
Run
);
}
if
(
!
this
.
checkExperimentDependencies
(
experiment
))
{
return
TPromise
.
wrap
(
ExperimentState
.
NoRun
);
return
Promise
.
resolve
(
ExperimentState
.
NoRun
);
}
if
(
this
.
environmentService
.
appQuality
===
'
stable
'
&&
experiment
.
condition
.
insidersOnly
===
true
)
{
return
TPromise
.
wrap
(
ExperimentState
.
NoRun
);
return
Promise
.
resolve
(
ExperimentState
.
NoRun
);
}
const
isNewUser
=
!
this
.
storageService
.
get
(
lastSessionDateStorageKey
,
StorageScope
.
GLOBAL
);
if
((
experiment
.
condition
.
newUser
===
true
&&
!
isNewUser
)
||
(
experiment
.
condition
.
newUser
===
false
&&
isNewUser
))
{
return
TPromise
.
wrap
(
ExperimentState
.
NoRun
);
return
Promise
.
resolve
(
ExperimentState
.
NoRun
);
}
if
(
typeof
experiment
.
condition
.
displayLanguage
===
'
string
'
)
{
...
...
@@ -355,7 +355,7 @@ export class ExperimentService extends Disposable implements IExperimentService
localeToCheck
=
localeToCheck
.
substr
(
0
,
b
);
}
if
(
displayLanguage
!==
localeToCheck
)
{
return
TPromise
.
wrap
(
ExperimentState
.
NoRun
);
return
Promise
.
resolve
(
ExperimentState
.
NoRun
);
}
}
}
...
...
src/vs/workbench/parts/experiments/test/electron-browser/experimentService.test.ts
浏览文件 @
86972072
...
...
@@ -45,7 +45,7 @@ function aLocalExtension(name: string = 'someext', manifest: any = {}, propertie
export
class
TestExperimentService
extends
ExperimentService
{
public
getExperiments
():
TPromise
<
any
[]
>
{
return
TPromise
.
wrap
(
experimentData
.
experiments
);
return
Promise
.
resolve
(
experimentData
.
experiments
);
}
}
...
...
src/vs/workbench/test/electron-browser/quickopen.perf.integrationTest.ts
浏览文件 @
86972072
...
...
@@ -167,7 +167,7 @@ class TestTelemetryService implements ITelemetryService {
public
publicLog
(
eventName
:
string
,
data
?:
any
):
TPromise
<
void
>
{
this
.
events
.
push
({
name
:
eventName
,
data
:
data
});
return
TPromise
.
wrap
<
void
>
(
null
);
return
Promise
.
resolve
(
null
);
}
public
getTelemetryInfo
():
TPromise
<
ITelemetryInfo
>
{
...
...
编辑
预览
Markdown
is supported
0%
请重试
或
添加新附件
.
添加附件
取消
You are about to add
0
people
to the discussion. Proceed with caution.
先完成此消息的编辑!
取消
想要评论请
注册
或
登录