Fix #19554

src/vs/workbench/parts/extensions/browser/extensionsActions.ts

@@ -332,7 +332,7 @@ export class ManageExtensionAction extends Action {
 	static ID = 'extensions.manage';
 
 	private static Class = 'extension-action manage';
-	private static NoExtensionClass = `${ManageExtensionAction.Class} no-extension`;
+	private static HideManageExtensionClass = `${ManageExtensionAction.Class} hide`;
 
 	private _actionItem: DropDownMenuActionItem;
 	get actionItem(): IActionItem { return this._actionItem; }
@@ -370,13 +370,13 @@ export class ManageExtensionAction extends Action {
 	}
 
 	private update(): void {
-		this.class = ManageExtensionAction.NoExtensionClass;
+		this.class = ManageExtensionAction.HideManageExtensionClass;
 		this.tooltip = '';
 		this.enabled = false;
-		if (this.extension) {
+		if (this.extension && this.extension.type === LocalExtensionType.User) {
 			const state = this.extension.state;
 			this.enabled = state === ExtensionState.Installed;
-			this.class = this.enabled || state === ExtensionState.Uninstalling ? ManageExtensionAction.Class : ManageExtensionAction.NoExtensionClass;
+			this.class = this.enabled || state === ExtensionState.Uninstalling ? ManageExtensionAction.Class : ManageExtensionAction.HideManageExtensionClass;
 			this.tooltip = state === ExtensionState.Uninstalling ? localize('ManageExtensionAction.uninstallingTooltip', "Uninstalling") : '';
 		}
 	}

src/vs/workbench/parts/extensions/browser/media/extensionActions.css

@@ -108,22 +108,22 @@
 	font-style: italic;
 }
 
-.extension-editor > .header > .details > .actions > .monaco-action-bar .action-item .action-label.extension-action.built-in-status {
+.extension-editor>.header>.details>.actions>.monaco-action-bar .action-item .action-label.extension-action.built-in-status {
 	font-weight: normal;
 }
 
-.extensions-viewlet > .extensions .extension > .details > .footer > .monaco-action-bar .action-item .action-label.extension-action.manage.no-extension {
+.extensions-viewlet>.extensions .extension>.details>.footer>.monaco-action-bar .action-item .action-label.extension-action.manage.hide {
 	display: none;
 }
 
-.extensions-viewlet > .extensions .extension > .details > .footer > .monaco-action-bar .action-item .action-label.extension-action.manage {
+.extensions-viewlet>.extensions .extension>.details>.footer>.monaco-action-bar .action-item .action-label.extension-action.manage {
 	height: 18px;
 	width: 10px;
 	border: none;
 	background: url('manage.svg') center center no-repeat;
 }
 
-.hc-black .extensions-viewlet > .extensions .extension > .details > .footer > .monaco-action-bar .action-item .action-label.extension-action.manage,
-.vs-dark .extensions-viewlet > .extensions .extension > .details > .footer > .monaco-action-bar .action-item .action-label.extension-action.manage {
+.hc-black .extensions-viewlet>.extensions .extension>.details>.footer>.monaco-action-bar .action-item .action-label.extension-action.manage,
+.vs-dark .extensions-viewlet>.extensions .extension>.details>.footer>.monaco-action-bar .action-item .action-label.extension-action.manage {
 	background: url('manage-inverse.svg') center center no-repeat;
 }
\ No newline at end of file

src/vs/workbench/parts/extensions/test/electron-browser/extensionsActions.test.ts

@@ -414,7 +414,7 @@ suite('ExtensionsActions Test', () => {
 		instantiationService.get(IExtensionsWorkbenchService).queryGallery().done(page => {
 			testObject.extension = page.firstPage[0];
 			assert.ok(!testObject.enabled);
-			assert.equal('extension-action manage no-extension', testObject.class);
+			assert.equal('extension-action manage hide', testObject.class);
 			assert.equal('', testObject.tooltip);
 
 			done();
@@ -431,7 +431,22 @@ suite('ExtensionsActions Test', () => {
 
 			installEvent.fire({ id: gallery.id, gallery });
 			assert.ok(!testObject.enabled);
-			assert.equal('extension-action manage no-extension', testObject.class);
+			assert.equal('extension-action manage hide', testObject.class);
+			assert.equal('', testObject.tooltip);
+
+			done();
+		});
+	});
+
+	test('Test ManageExtensionAction when extension is system extension', (done) => {
+		const testObject: ExtensionsActions.ManageExtensionAction = instantiationService.createInstance(ExtensionsActions.ManageExtensionAction);
+		const local = aLocalExtension('a', {}, { type: LocalExtensionType.System });
+		instantiationService.stubPromise(IExtensionManagementService, 'getInstalled', [local]);
+
+		instantiationService.get(IExtensionsWorkbenchService).queryLocal().done(extensions => {
+			testObject.extension = extensions[0];
+			assert.ok(!testObject.enabled);
+			assert.equal('extension-action manage hide', testObject.class);
 			assert.equal('', testObject.tooltip);
 
 			done();