💄 symbols upload

build/lib/compilation.js

@@ -22,7 +22,7 @@ var rootDir = path.join(__dirname, '../../src');
 var options = require('../../src/tsconfig.json').compilerOptions;
 options.verbose = false;
 options.sourceMap = true;
-if (process.env['VSCODE_NO_SOURCEMAP']) { // To be used by developers in a hurry
+if (process.env['VSCODE_NO_SOURCEMAP']) {
     options.sourceMap = false;
 }
 options.rootDir = rootDir;

build/lib/i18n.js

@@ -1083,7 +1083,7 @@ function prepareI18nPackFiles(externalExtensions, resultingTranslationPaths, pse
                         extPack = extensionsPacks[resource] = { version: i18nPackVersion, contents: {} };
                     }
                     var externalId = externalExtensions[resource];
-                    if (!externalId) { // internal extension: remove 'extensions/extensionId/' segnent
+                    if (!externalId) {
                         var secondSlash = path.indexOf('/', firstSlash + 1);
                         extPack.contents[path.substr(secondSlash + 1)] = file.messages;
                     }

build/lib/nls.js

@@ -150,16 +150,13 @@ function isImportNode(node) {
             .filter(function (d) { return d.importClause.namedBindings.kind === ts.SyntaxKind.NamespaceImport; })
             .map(function (d) { return d.importClause.namedBindings.name; })
             .concat(importEqualsDeclarations.map(function (d) { return d.name; }))
-            // find read-only references to `nls`
             .map(function (n) { return service.getReferencesAtPosition(filename, n.pos + 1); })
             .flatten()
             .filter(function (r) { return !r.isWriteAccess; })
-            // find the deepest call expressions AST nodes that contain those references
             .map(function (r) { return collect(sourceFile, function (n) { return isCallExpressionWithinTextSpanCollectStep(r.textSpan, n); }); })
             .map(function (a) { return lazy(a).last(); })
             .filter(function (n) { return !!n; })
             .map(function (n) { return n; })
-            // only `localize` calls
             .filter(function (n) { return n.expression.kind === ts.SyntaxKind.PropertyAccessExpression && n.expression.name.getText() === 'localize'; });
         // `localize` named imports
         var allLocalizeImportDeclarations = importDeclarations

build/tfs/common/symbols.ts

@@ -136,6 +136,7 @@ async function downloadAsset(repository, assetName: string, targetPath: string,
 }
 
 interface IOptions {
+	repository: string;
 	platform: Platform;
 	versions: { code: string; insiders: boolean; electron: string; };
 	access: { hockeyAppToken: string; hockeyAppId: string; githubToken: string };
@@ -147,7 +148,7 @@ async function ensureVersionAndSymbols(options: IOptions) {
 	console.log(`HockeyApp: checking for existing version ${options.versions.code} (${options.platform})`);
 	const versions = await getVersions({ accessToken: options.access.hockeyAppToken, appId: options.access.hockeyAppId });
 	if (versions.app_versions.some(v => v.version === options.versions.code)) {
-		console.log(`Returning without uploading symbols because version ${options.versions.code} (${options.platform}) was already found`);
+		console.log(`HockeyApp: Returning without uploading symbols because version ${options.versions.code} (${options.platform}) was already found`);
 		return;
 	}
 
@@ -155,7 +156,7 @@ async function ensureVersionAndSymbols(options: IOptions) {
 	const symbolsName = symbolsZipName(options.platform, options.versions.electron, options.versions.insiders);
 	const symbolsPath = await tmpFile('symbols.zip');
 	console.log(`HockeyApp: downloading symbols ${symbolsName} for electron ${options.versions.electron} (${options.platform}) into ${symbolsPath}`);
-	await downloadAsset(new github({ repo: 'Microsoft/vscode-electron-prebuilt', token: options.access.githubToken }), symbolsName, symbolsPath, options.versions.electron);
+	await downloadAsset(new github({ repo: options.repository, token: options.access.githubToken }), symbolsName, symbolsPath, options.versions.electron);
 
 	// Create version
 	console.log(`HockeyApp: creating new version ${options.versions.code} (${options.platform})`);
@@ -172,6 +173,7 @@ async function ensureVersionAndSymbols(options: IOptions) {
 // Environment
 const pakage = require('../../../package.json');
 const product = require('../../../product.json');
+const repository = product.electronRepository;
 const codeVersion = pakage.version;
 const electronVersion = require('../../lib/electron').getElectronVersion();
 const insiders = product.quality !== 'stable';
@@ -190,20 +192,25 @@ if (process.platform === 'darwin') {
 }
 
 // Create version and upload symbols in HockeyApp
-ensureVersionAndSymbols({
-	platform,
-	versions: {
-		code: codeVersion,
-		insiders,
-		electron: electronVersion
-	},
-	access: {
-		githubToken,
-		hockeyAppToken,
-		hockeyAppId
-	}
-}).then(() => {
-	console.log('HockeyApp: done');
-}, error => {
-	console.error(`HockeyApp: error (${error})`);
-});
\ No newline at end of file
+if (repository && codeVersion && electronVersion) {
+	ensureVersionAndSymbols({
+		repository,
+		platform,
+		versions: {
+			code: codeVersion,
+			insiders,
+			electron: electronVersion
+		},
+		access: {
+			githubToken,
+			hockeyAppToken,
+			hockeyAppId
+		}
+	}).then(() => {
+		console.log('HockeyApp: done');
+	}, error => {
+		console.error(`HockeyApp: error (${error})`);
+	});
+} else {
+	console.log(`HockeyApp: skipping due to insufficient context (repository: ${repository}, codeVersion: ${codeVersion}, electronVersion: ${electronVersion})`);
+}
\ No newline at end of file