Skip to content
体验新版
项目
组织
正在加载...
登录
切换导航
打开侧边栏
掘金者说
vscode
提交
54ad623f
V
vscode
项目概览
掘金者说
/
vscode
与 Fork 源项目一致
从无法访问的项目Fork
通知
1
Star
0
Fork
0
代码
文件
提交
分支
Tags
贡献者
分支图
Diff
Issue
0
列表
看板
标记
里程碑
合并请求
0
DevOps
流水线
流水线任务
计划
Wiki
0
Wiki
分析
仓库
DevOps
项目成员
Pages
V
vscode
项目概览
项目概览
详情
发布
仓库
仓库
文件
提交
分支
标签
贡献者
分支图
比较
Issue
0
Issue
0
列表
看板
标记
里程碑
合并请求
0
合并请求
0
Pages
DevOps
DevOps
流水线
流水线任务
计划
分析
分析
仓库分析
DevOps
Wiki
0
Wiki
成员
成员
收起侧边栏
关闭侧边栏
动态
分支图
创建新Issue
流水线任务
提交
Issue看板
体验新版 GitCode,发现更多精彩内容 >>
提交
54ad623f
编写于
6月 06, 2019
作者:
I
isidor
浏览文件
操作
浏览文件
下载
电子邮件补丁
差异文件
compositePart use Map
#74948
上级
20ea43ca
变更
1
隐藏空白更改
内联
并排
Showing
1 changed file
with
17 addition
and
17 deletion
+17
-17
src/vs/workbench/browser/parts/compositePart.ts
src/vs/workbench/browser/parts/compositePart.ts
+17
-17
未找到文件。
src/vs/workbench/browser/parts/compositePart.ts
浏览文件 @
54ad623f
...
...
@@ -60,8 +60,8 @@ export abstract class CompositePart<T extends Composite> extends Part {
protected
toolBar
:
ToolBar
;
private
mapCompositeToCompositeContainer
:
{
[
compositeId
:
string
]:
HTMLElement
;
}
;
private
mapActionsBindingToComposite
:
{
[
compositeId
:
string
]:
()
=>
void
;
}
;
private
mapCompositeToCompositeContainer
=
new
Map
<
string
,
HTMLElement
>
()
;
private
mapActionsBindingToComposite
=
new
Map
<
string
,
()
=>
void
>
()
;
private
activeComposite
:
Composite
|
null
;
private
lastActiveCompositeId
:
string
;
private
instantiatedCompositeItems
:
Map
<
string
,
CompositeItem
>
;
...
...
@@ -91,8 +91,6 @@ export abstract class CompositePart<T extends Composite> extends Part {
)
{
super
(
id
,
options
,
themeService
,
storageService
,
layoutService
);
this
.
mapCompositeToCompositeContainer
=
{};
this
.
mapActionsBindingToComposite
=
{};
this
.
activeComposite
=
null
;
this
.
instantiatedCompositeItems
=
new
Map
<
string
,
CompositeItem
>
();
this
.
lastActiveCompositeId
=
storageService
.
get
(
activeCompositeSettingsKey
,
StorageScope
.
WORKSPACE
,
this
.
defaultCompositeId
);
...
...
@@ -206,7 +204,7 @@ export abstract class CompositePart<T extends Composite> extends Part {
this
.
lastActiveCompositeId
=
this
.
activeComposite
.
getId
();
// Composites created for the first time
let
compositeContainer
=
this
.
mapCompositeToCompositeContainer
[
composite
.
getId
()]
;
let
compositeContainer
=
this
.
mapCompositeToCompositeContainer
.
get
(
composite
.
getId
())
;
if
(
!
compositeContainer
)
{
// Build Container off-DOM
...
...
@@ -218,7 +216,7 @@ export abstract class CompositePart<T extends Composite> extends Part {
composite
.
updateStyles
();
// Remember composite container
this
.
mapCompositeToCompositeContainer
[
composite
.
getId
()]
=
compositeContainer
;
this
.
mapCompositeToCompositeContainer
.
set
(
composite
.
getId
(),
compositeContainer
)
;
}
// Fill Content and Actions
...
...
@@ -244,10 +242,10 @@ export abstract class CompositePart<T extends Composite> extends Part {
}
// Handle Composite Actions
let
actionsBinding
=
this
.
mapActionsBindingToComposite
[
composite
.
getId
()]
;
let
actionsBinding
=
this
.
mapActionsBindingToComposite
.
get
(
composite
.
getId
())
;
if
(
!
actionsBinding
)
{
actionsBinding
=
this
.
collectCompositeActions
(
composite
);
this
.
mapActionsBindingToComposite
[
composite
.
getId
()]
=
actionsBinding
;
this
.
mapActionsBindingToComposite
.
set
(
composite
.
getId
(),
actionsBinding
)
;
}
actionsBinding
();
...
...
@@ -300,13 +298,13 @@ export abstract class CompositePart<T extends Composite> extends Part {
// Actions
const
actionsBinding
=
this
.
collectCompositeActions
(
this
.
activeComposite
);
this
.
mapActionsBindingToComposite
[
this
.
activeComposite
.
getId
()]
=
actionsBinding
;
this
.
mapActionsBindingToComposite
.
set
(
this
.
activeComposite
.
getId
(),
actionsBinding
)
;
actionsBinding
();
}
// Otherwise invalidate actions binding for next time when the composite becomes visible
else
{
delete
this
.
mapActionsBindingToComposite
[
compositeId
]
;
this
.
mapActionsBindingToComposite
.
delete
(
compositeId
)
;
}
}
...
...
@@ -360,14 +358,16 @@ export abstract class CompositePart<T extends Composite> extends Part {
const
composite
=
this
.
activeComposite
;
this
.
activeComposite
=
null
;
const
compositeContainer
=
this
.
mapCompositeToCompositeContainer
[
composite
.
getId
()]
;
const
compositeContainer
=
this
.
mapCompositeToCompositeContainer
.
get
(
composite
.
getId
())
;
// Indicate to Composite
composite
.
setVisible
(
false
);
// Take Container Off-DOM and hide
compositeContainer
.
remove
();
hide
(
compositeContainer
);
if
(
compositeContainer
)
{
compositeContainer
.
remove
();
hide
(
compositeContainer
);
}
// Clear any running Progress
this
.
progressBar
.
stop
().
hide
();
...
...
@@ -490,8 +490,8 @@ export abstract class CompositePart<T extends Composite> extends Part {
return
false
;
// do not remove active composite
}
delete
this
.
mapCompositeToCompositeContainer
[
compositeId
]
;
delete
this
.
mapActionsBindingToComposite
[
compositeId
]
;
this
.
mapCompositeToCompositeContainer
.
delete
(
compositeId
)
;
this
.
mapActionsBindingToComposite
.
delete
(
compositeId
)
;
const
compositeItem
=
this
.
instantiatedCompositeItems
.
get
(
compositeId
);
if
(
compositeItem
)
{
compositeItem
.
composite
.
dispose
();
...
...
@@ -503,8 +503,8 @@ export abstract class CompositePart<T extends Composite> extends Part {
}
dispose
():
void
{
this
.
mapCompositeToCompositeContainer
=
null
!
;
// StrictNullOverride: nulling out ok in dispose
this
.
mapActionsBindingToComposite
=
null
!
;
// StrictNullOverride: nulling out ok in dispose
this
.
mapCompositeToCompositeContainer
.
clear
();
this
.
mapActionsBindingToComposite
.
clear
();
this
.
instantiatedCompositeItems
.
forEach
(
compositeItem
=>
{
compositeItem
.
composite
.
dispose
();
...
...
编辑
预览
Markdown
is supported
0%
请重试
或
添加新附件
.
添加附件
取消
You are about to add
0
people
to the discussion. Proceed with caution.
先完成此消息的编辑!
取消
想要评论请
注册
或
登录