提交 47b7320c 编写于 作者: D Daniel Imms

Show tab prefix before icon is ready

上级 a31d9ca6
...@@ -273,11 +273,11 @@ class TerminalTabsRenderer implements IListRenderer<ITerminalInstance, ITerminal ...@@ -273,11 +273,11 @@ class TerminalTabsRenderer implements IListRenderer<ITerminalInstance, ITerminal
} }
} else { } else {
this.fillActionBar(instance, template); this.fillActionBar(instance, template);
label = prefix;
// Only add the title if the icon is set, this prevents the title jumping around for // Only add the title if the icon is set, this prevents the title jumping around for
// example when launching with a ShellLaunchConfig.name and no icon // example when launching with a ShellLaunchConfig.name and no icon
if (instance.icon) { if (instance.icon) {
label = `${prefix}$(${iconId})`; label += `$(${iconId}) ${instance.title}`;
label += ` ${instance.title}`;
} }
} }
......
...@@ -526,10 +526,11 @@ class TerminalThemeIconStyle extends Themable { ...@@ -526,10 +526,11 @@ class TerminalThemeIconStyle extends Themable {
override updateStyles(): void { override updateStyles(): void {
super.updateStyles(); super.updateStyles();
let css = '';
// TODO add a rule collector to avoid duplication
const colorTheme = this._themeService.getColorTheme(); const colorTheme = this._themeService.getColorTheme();
// TODO add a rule collector to avoid duplication
let css = '';
// Add icons // Add icons
for (const instance of this._terminalService.terminalInstances) { for (const instance of this._terminalService.terminalInstances) {
const icon = instance.icon; const icon = instance.icon;
...@@ -557,8 +558,6 @@ class TerminalThemeIconStyle extends Themable { ...@@ -557,8 +558,6 @@ class TerminalThemeIconStyle extends Themable {
} }
const color = colorTheme.getColor(instance.color); const color = colorTheme.getColor(instance.color);
if (color) { if (color) {
// TODO: Show all colors in change color picker
// TODO: Use .terminal-color-...
// exclude status icons (file-icon) and inline action icons (trashcan and horizontalSplit) // exclude status icons (file-icon) and inline action icons (trashcan and horizontalSplit)
css += `.monaco-workbench .${colorClass} .codicon:not(.codicon-split-horizontal):not(.codicon-trashcan):not(.file-icon) { color: ${color} !important; }`; css += `.monaco-workbench .${colorClass} .codicon:not(.codicon-split-horizontal):not(.codicon-trashcan):not(.file-icon) { color: ${color} !important; }`;
} }
......
Markdown is supported
0% .
You are about to add 0 people to the discussion. Proceed with caution.
先完成此消息的编辑!
想要评论请 注册