Skip to content
体验新版
项目
组织
正在加载...
登录
切换导航
打开侧边栏
掘金者说
vscode
提交
2da43c7d
V
vscode
项目概览
掘金者说
/
vscode
与 Fork 源项目一致
从无法访问的项目Fork
通知
1
Star
0
Fork
0
代码
文件
提交
分支
Tags
贡献者
分支图
Diff
Issue
0
列表
看板
标记
里程碑
合并请求
0
DevOps
流水线
流水线任务
计划
Wiki
0
Wiki
分析
仓库
DevOps
项目成员
Pages
V
vscode
项目概览
项目概览
详情
发布
仓库
仓库
文件
提交
分支
标签
贡献者
分支图
比较
Issue
0
Issue
0
列表
看板
标记
里程碑
合并请求
0
合并请求
0
Pages
DevOps
DevOps
流水线
流水线任务
计划
分析
分析
仓库分析
DevOps
Wiki
0
Wiki
成员
成员
收起侧边栏
关闭侧边栏
动态
分支图
创建新Issue
流水线任务
提交
Issue看板
体验新版 GitCode,发现更多精彩内容 >>
提交
2da43c7d
编写于
6月 08, 2020
作者:
R
rebornix
浏览文件
操作
浏览文件
下载
电子邮件补丁
差异文件
menu event listener are disposed later than list view itself.
上级
9c7e230f
变更
4
隐藏空白更改
内联
并排
Showing
4 changed file
with
21 addition
and
0 deletion
+21
-0
src/vs/workbench/contrib/notebook/browser/notebookBrowser.ts
src/vs/workbench/contrib/notebook/browser/notebookBrowser.ts
+2
-0
src/vs/workbench/contrib/notebook/browser/notebookEditorWidget.ts
...orkbench/contrib/notebook/browser/notebookEditorWidget.ts
+4
-0
src/vs/workbench/contrib/notebook/browser/view/renderers/cellRenderer.ts
...h/contrib/notebook/browser/view/renderers/cellRenderer.ts
+6
-0
src/vs/workbench/contrib/notebook/test/testNotebookEditor.ts
src/vs/workbench/contrib/notebook/test/testNotebookEditor.ts
+9
-0
未找到文件。
src/vs/workbench/contrib/notebook/browser/notebookBrowser.ts
浏览文件 @
2da43c7d
...
...
@@ -159,6 +159,8 @@ export interface INotebookEditor extends IEditor {
activeKernel
:
INotebookKernelInfo
|
undefined
;
readonly
onDidChangeKernel
:
Event
<
void
>
;
isDisposed
:
boolean
;
getId
():
string
;
getDomNode
():
HTMLElement
;
getInnerWebview
():
Webview
|
undefined
;
...
...
src/vs/workbench/contrib/notebook/browser/notebookEditorWidget.ts
浏览文件 @
2da43c7d
...
...
@@ -97,6 +97,10 @@ export class NotebookEditorWidget extends Disposable implements INotebookEditor
private
readonly
_onDidFocusWidget
=
this
.
_register
(
new
Emitter
<
void
>
());
public
get
onDidFocus
():
Event
<
any
>
{
return
this
.
_onDidFocusWidget
.
event
;
}
get
isDisposed
()
{
return
this
.
_isDisposed
;
}
constructor
(
@
IInstantiationService
private
readonly
instantiationService
:
IInstantiationService
,
@
IStorageService
storageService
:
IStorageService
,
...
...
src/vs/workbench/contrib/notebook/browser/view/renderers/cellRenderer.ts
浏览文件 @
2da43c7d
...
...
@@ -317,6 +317,10 @@ abstract class AbstractCellRenderer {
updateActions
();
disposables
.
add
(
menu
.
onDidChange
(()
=>
{
if
(
this
.
notebookEditor
.
isDisposed
)
{
return
;
}
updateActions
();
}));
}
...
...
@@ -490,10 +494,12 @@ export class MarkdownCellRenderer extends AbstractCellRenderer implements IListR
}
disposeTemplate
(
templateData
:
MarkdownCellRenderTemplate
):
void
{
console
.
log
(
'
dispose templateData
'
);
templateData
.
disposables
.
clear
();
}
disposeElement
(
element
:
ICellViewModel
,
index
:
number
,
templateData
:
MarkdownCellRenderTemplate
,
height
:
number
|
undefined
):
void
{
console
.
log
(
'
dispose element
'
);
if
(
height
)
{
templateData
.
elementDisposables
.
clear
();
}
...
...
src/vs/workbench/contrib/notebook/test/testNotebookEditor.ts
浏览文件 @
2da43c7d
...
...
@@ -37,6 +37,11 @@ export class TestCell extends NotebookCellTextModel {
}
export
class
TestNotebookEditor
implements
INotebookEditor
{
private
_isDisposed
=
false
;
get
isDisposed
()
{
return
this
.
_isDisposed
;
}
get
viewModel
()
{
return
undefined
;
...
...
@@ -216,6 +221,10 @@ export class TestNotebookEditor implements INotebookEditor {
changeDecorations
(
callback
:
(
changeAccessor
:
IModelDecorationsChangeAccessor
)
=>
any
):
any
{
throw
new
Error
(
'
Method not implemented.
'
);
}
dispose
()
{
this
.
_isDisposed
=
true
;
}
}
// export function createTestCellViewModel(instantiationService: IInstantiationService, viewType: string, notebookHandle: number, cellhandle: number, source: string[], language: string, cellKind: CellKind, outputs: IOutput[]) {
...
...
编辑
预览
Markdown
is supported
0%
请重试
或
添加新附件
.
添加附件
取消
You are about to add
0
people
to the discussion. Proceed with caution.
先完成此消息的编辑!
取消
想要评论请
注册
或
登录