Skip to content
体验新版
项目
组织
正在加载...
登录
切换导航
打开侧边栏
掘金者说
vscode
提交
1bd7cf9e
V
vscode
项目概览
掘金者说
/
vscode
与 Fork 源项目一致
从无法访问的项目Fork
通知
1
Star
0
Fork
0
代码
文件
提交
分支
Tags
贡献者
分支图
Diff
Issue
0
列表
看板
标记
里程碑
合并请求
0
DevOps
流水线
流水线任务
计划
Wiki
0
Wiki
分析
仓库
DevOps
项目成员
Pages
V
vscode
项目概览
项目概览
详情
发布
仓库
仓库
文件
提交
分支
标签
贡献者
分支图
比较
Issue
0
Issue
0
列表
看板
标记
里程碑
合并请求
0
合并请求
0
Pages
DevOps
DevOps
流水线
流水线任务
计划
分析
分析
仓库分析
DevOps
Wiki
0
Wiki
成员
成员
收起侧边栏
关闭侧边栏
动态
分支图
创建新Issue
流水线任务
提交
Issue看板
体验新版 GitCode,发现更多精彩内容 >>
提交
1bd7cf9e
编写于
11月 02, 2020
作者:
J
Johannes Rieken
浏览文件
操作
浏览文件
下载
电子邮件补丁
差异文件
use gh username for todo-tags, nuke some todo-tags
上级
ab942342
变更
13
隐藏空白更改
内联
并排
Showing
13 changed file
with
16 addition
and
19 deletion
+16
-19
build/lib/eslint/code-no-unexternalized-strings.ts
build/lib/eslint/code-no-unexternalized-strings.ts
+2
-3
src/vs/base/common/uuid.ts
src/vs/base/common/uuid.ts
+3
-2
src/vs/editor/browser/services/openerService.ts
src/vs/editor/browser/services/openerService.ts
+1
-1
src/vs/editor/contrib/rename/rename.ts
src/vs/editor/contrib/rename/rename.ts
+1
-1
src/vs/workbench/api/browser/mainThreadCodeInsets.ts
src/vs/workbench/api/browser/mainThreadCodeInsets.ts
+2
-2
src/vs/workbench/api/common/extHost.protocol.ts
src/vs/workbench/api/common/extHost.protocol.ts
+1
-1
src/vs/workbench/browser/parts/editor/breadcrumbsPicker.ts
src/vs/workbench/browser/parts/editor/breadcrumbsPicker.ts
+0
-1
src/vs/workbench/browser/parts/editor/media/breadcrumbscontrol.css
...rkbench/browser/parts/editor/media/breadcrumbscontrol.css
+1
-1
src/vs/workbench/contrib/notebook/common/model/notebookTextModel.ts
...kbench/contrib/notebook/common/model/notebookTextModel.ts
+2
-2
src/vs/workbench/contrib/outline/browser/outlinePane.ts
src/vs/workbench/contrib/outline/browser/outlinePane.ts
+1
-1
src/vs/workbench/contrib/search/browser/searchWidget.ts
src/vs/workbench/contrib/search/browser/searchWidget.ts
+1
-1
src/vs/workbench/contrib/views/browser/treeView.ts
src/vs/workbench/contrib/views/browser/treeView.ts
+1
-1
src/vs/workbench/services/extensions/common/extensionHostMain.ts
...workbench/services/extensions/common/extensionHostMain.ts
+0
-2
未找到文件。
build/lib/eslint/code-no-unexternalized-strings.ts
浏览文件 @
1bd7cf9e
...
...
@@ -47,7 +47,7 @@ export = new class NoUnexternalizedStrings implements eslint.Rule.RuleModule {
// extract key so that it can be checked later
let
key
:
string
|
undefined
;
if
(
isStringLiteral
(
keyNode
))
{
doubleQuotedStringLiterals
.
delete
(
keyNode
);
//todo@joh reconsider
doubleQuotedStringLiterals
.
delete
(
keyNode
);
key
=
keyNode
.
value
;
}
else
if
(
keyNode
.
type
===
AST_NODE_TYPES
.
ObjectExpression
)
{
...
...
@@ -55,7 +55,7 @@ export = new class NoUnexternalizedStrings implements eslint.Rule.RuleModule {
if
(
property
.
type
===
AST_NODE_TYPES
.
Property
&&
!
property
.
computed
)
{
if
(
property
.
key
.
type
===
AST_NODE_TYPES
.
Identifier
&&
property
.
key
.
name
===
'
key
'
)
{
if
(
isStringLiteral
(
property
.
value
))
{
doubleQuotedStringLiterals
.
delete
(
property
.
value
);
//todo@joh reconsider
doubleQuotedStringLiterals
.
delete
(
property
.
value
);
key
=
property
.
value
.
value
;
break
;
}
...
...
@@ -123,4 +123,3 @@ export = new class NoUnexternalizedStrings implements eslint.Rule.RuleModule {
};
}
};
src/vs/base/common/uuid.ts
浏览文件 @
1bd7cf9e
...
...
@@ -17,8 +17,9 @@ for (let i = 0; i < 256; i++) {
_hex
.
push
(
i
.
toString
(
16
).
padStart
(
2
,
'
0
'
));
}
// todo@joh node nodejs use `crypto#randomBytes`, see: https://nodejs.org/docs/latest/api/crypto.html#crypto_crypto_randombytes_size_callback
// todo@joh use browser-crypto
// todo@jrieken
// 1. node nodejs use`crypto#randomBytes`, see: https://nodejs.org/docs/latest/api/crypto.html#crypto_crypto_randombytes_size_callback
// 2. use browser-crypto
const
_fillRandomValues
=
function
(
bucket
:
Uint8Array
):
Uint8Array
{
for
(
let
i
=
0
;
i
<
bucket
.
length
;
i
++
)
{
bucket
[
i
]
=
Math
.
floor
(
Math
.
random
()
*
256
);
...
...
src/vs/editor/browser/services/openerService.ts
浏览文件 @
1bd7cf9e
...
...
@@ -180,7 +180,7 @@ export class OpenerService implements IOpenerService {
private
async
_doOpenExternal
(
resource
:
URI
|
string
,
options
:
OpenOptions
|
undefined
):
Promise
<
boolean
>
{
//todo@j
oh
IExternalUriResolver should support `uri: URI | string`
//todo@j
rieken
IExternalUriResolver should support `uri: URI | string`
const
uri
=
typeof
resource
===
'
string
'
?
URI
.
parse
(
resource
)
:
resource
;
const
{
resolved
}
=
await
this
.
resolveExternalUri
(
uri
,
options
);
...
...
src/vs/editor/contrib/rename/rename.ts
浏览文件 @
1bd7cf9e
...
...
@@ -358,7 +358,7 @@ registerModelAndPositionCommand('_executeDocumentRenameProvider', function (mode
});
//todo@j
oh
use editor options world
//todo@j
rieken
use editor options world
Registry
.
as
<
IConfigurationRegistry
>
(
Extensions
.
Configuration
).
registerConfiguration
({
id
:
'
editor
'
,
properties
:
{
...
...
src/vs/workbench/api/browser/mainThreadCodeInsets.ts
浏览文件 @
1bd7cf9e
...
...
@@ -14,7 +14,7 @@ import { IActiveCodeEditor, IViewZone } from 'vs/editor/browser/editorBrowser';
import
{
ExtensionIdentifier
}
from
'
vs/platform/extensions/common/extensions
'
;
import
{
isEqual
}
from
'
vs/base/common/resources
'
;
// todo@j
oh
move these things back into something like contrib/insets
// todo@j
rieken
move these things back into something like contrib/insets
class
EditorWebviewZone
implements
IViewZone
{
readonly
domNode
:
HTMLElement
;
...
...
@@ -73,7 +73,7 @@ export class MainThreadEditorInsets implements MainThreadEditorInsetsShape {
async
$createEditorInset
(
handle
:
number
,
id
:
string
,
uri
:
UriComponents
,
line
:
number
,
height
:
number
,
options
:
modes
.
IWebviewOptions
,
extensionId
:
ExtensionIdentifier
,
extensionLocation
:
UriComponents
):
Promise
<
void
>
{
let
editor
:
IActiveCodeEditor
|
undefined
;
id
=
id
.
substr
(
0
,
id
.
indexOf
(
'
,
'
));
//todo@j
oh
HACK
id
=
id
.
substr
(
0
,
id
.
indexOf
(
'
,
'
));
//todo@j
rieken
HACK
for
(
const
candidate
of
this
.
_editorService
.
listCodeEditors
())
{
if
(
candidate
.
getId
()
===
id
&&
candidate
.
hasModel
()
&&
isEqual
(
candidate
.
getModel
().
uri
,
URI
.
revive
(
uri
)))
{
...
...
src/vs/workbench/api/common/extHost.protocol.ts
浏览文件 @
1bd7cf9e
...
...
@@ -1307,7 +1307,7 @@ export interface IWorkspaceCellEditDto {
export
interface
IWorkspaceEditDto
{
edits
:
Array
<
IWorkspaceFileEditDto
|
IWorkspaceTextEditDto
|
IWorkspaceCellEditDto
>
;
// todo@j
oh
reject should go into rename
// todo@j
rieken
reject should go into rename
rejectReason
?:
string
;
}
...
...
src/vs/workbench/browser/parts/editor/breadcrumbsPicker.ts
浏览文件 @
1bd7cf9e
...
...
@@ -436,7 +436,6 @@ export class BreadcrumbsFilePicker extends BreadcrumbsPicker {
}
protected
_getTargetFromEvent
(
element
:
any
):
any
|
undefined
{
// todo@joh
if
(
element
&&
!
IWorkspaceFolder
.
isIWorkspaceFolder
(
element
)
&&
!
(
element
as
IFileStat
).
isDirectory
)
{
return
new
FileElement
((
element
as
IFileStat
).
resource
,
FileKind
.
FILE
);
}
...
...
src/vs/workbench/browser/parts/editor/media/breadcrumbscontrol.css
浏览文件 @
1bd7cf9e
...
...
@@ -21,7 +21,7 @@
padding-right
:
6px
;
}
/*
todo@joh move somewhere els
e */
/*
breadcrumbs-picker-styl
e */
.monaco-workbench
.monaco-breadcrumbs-picker
.arrow
{
position
:
absolute
;
...
...
src/vs/workbench/contrib/notebook/common/model/notebookTextModel.ts
浏览文件 @
1bd7cf9e
...
...
@@ -337,14 +337,14 @@ export class NotebookTextModel extends Disposable implements INotebookTextModel
this
.
_replaceCells
(
edit
.
index
,
edit
.
count
,
edit
.
cells
,
synchronous
,
computeUndoRedo
);
break
;
case
CellEditType
.
Output
:
//TODO@j
oh
,@rebornix no event, no undo stop (?)
//TODO@j
rieken
,@rebornix no event, no undo stop (?)
this
.
_assertIndex
(
edit
.
index
);
const
cell
=
this
.
_cells
[
edit
.
index
];
this
.
_spliceNotebookCellOutputs2
(
cell
.
handle
,
edit
.
outputs
,
computeUndoRedo
);
break
;
case
CellEditType
.
OutputsSplice
:
{
//TODO@j
oh
,@rebornix no event, no undo stop (?)
//TODO@j
rieken
,@rebornix no event, no undo stop (?)
this
.
_assertIndex
(
edit
.
index
);
const
cell
=
this
.
_cells
[
edit
.
index
];
this
.
_spliceNotebookCellOutputs
(
cell
.
handle
,
edit
.
splices
,
computeUndoRedo
);
...
...
src/vs/workbench/contrib/outline/browser/outlinePane.ts
浏览文件 @
1bd7cf9e
...
...
@@ -425,7 +425,7 @@ export class OutlinePane extends ViewPane {
private
_onDidChangeUserState
(
e
:
{
followCursor
?:
boolean
,
sortBy
?:
boolean
,
filterOnType
?:
boolean
})
{
this
.
_outlineViewState
.
persist
(
this
.
_storageService
);
if
(
e
.
followCursor
)
{
// todo@j
oh
update immediately
// todo@j
rieken
update immediately
}
if
(
e
.
sortBy
)
{
this
.
_treeComparator
.
type
=
this
.
_outlineViewState
.
sortBy
;
...
...
src/vs/workbench/contrib/search/browser/searchWidget.ts
浏览文件 @
1bd7cf9e
...
...
@@ -295,7 +295,7 @@ export class SearchWidget extends Widget {
this
.
toggleReplaceButton
.
element
.
setAttribute
(
'
aria-expanded
'
,
'
false
'
);
this
.
toggleReplaceButton
.
element
.
classList
.
add
(...
searchHideReplaceIcon
.
classNamesArray
);
this
.
toggleReplaceButton
.
icon
=
'
toggle-replace-button
'
;
// TODO@jo
h
need to dispose this listener eventually
// TODO@jo
ao
need to dispose this listener eventually
this
.
toggleReplaceButton
.
onDidClick
(()
=>
this
.
onToggleReplaceButton
());
this
.
toggleReplaceButton
.
element
.
title
=
nls
.
localize
(
'
search.replace.toggle.button.title
'
,
"
Toggle Replace
"
);
}
...
...
src/vs/workbench/contrib/views/browser/treeView.ts
浏览文件 @
1bd7cf9e
...
...
@@ -684,7 +684,7 @@ class TreeDataSource implements IAsyncDataSource<ITreeItem, ITreeItem> {
}
}
// todo@j
oh
,sandy make this proper and contributable from extensions
// todo@j
rieken
,sandy make this proper and contributable from extensions
registerThemingParticipant
((
theme
,
collector
)
=>
{
const
matchBackgroundColor
=
theme
.
getColor
(
listFilterMatchHighlight
);
...
...
src/vs/workbench/services/extensions/common/extensionHostMain.ts
浏览文件 @
1bd7cf9e
...
...
@@ -60,7 +60,6 @@ export class ExtensionHostMain {
const
instaService
:
IInstantiationService
=
new
InstantiationService
(
services
,
true
);
// todo@joh
// ugly self - inject
const
terminalService
=
instaService
.
invokeFunction
(
accessor
=>
accessor
.
get
(
IExtHostTerminalService
));
this
.
_disposables
.
add
(
terminalService
);
...
...
@@ -71,7 +70,6 @@ export class ExtensionHostMain {
logService
.
info
(
'
extension host started
'
);
logService
.
trace
(
'
initData
'
,
initData
);
// todo@joh
// ugly self - inject
// must call initialize *after* creating the extension service
// because `initialize` itself creates instances that depend on it
...
...
编辑
预览
Markdown
is supported
0%
请重试
或
添加新附件
.
添加附件
取消
You are about to add
0
people
to the discussion. Proceed with caution.
先完成此消息的编辑!
取消
想要评论请
注册
或
登录