Skip to content
体验新版
项目
组织
正在加载...
登录
切换导航
打开侧边栏
掘金者说
vscode
提交
0b8e2084
V
vscode
项目概览
掘金者说
/
vscode
与 Fork 源项目一致
从无法访问的项目Fork
通知
1
Star
0
Fork
0
代码
文件
提交
分支
Tags
贡献者
分支图
Diff
Issue
0
列表
看板
标记
里程碑
合并请求
0
DevOps
流水线
流水线任务
计划
Wiki
0
Wiki
分析
仓库
DevOps
项目成员
Pages
V
vscode
项目概览
项目概览
详情
发布
仓库
仓库
文件
提交
分支
标签
贡献者
分支图
比较
Issue
0
Issue
0
列表
看板
标记
里程碑
合并请求
0
合并请求
0
Pages
DevOps
DevOps
流水线
流水线任务
计划
分析
分析
仓库分析
DevOps
Wiki
0
Wiki
成员
成员
收起侧边栏
关闭侧边栏
动态
分支图
创建新Issue
流水线任务
提交
Issue看板
体验新版 GitCode,发现更多精彩内容 >>
提交
0b8e2084
编写于
8月 17, 2018
作者:
R
Rob Lourens
浏览文件
操作
浏览文件
下载
电子邮件补丁
差异文件
#54140 - add keyboard shortcut for setting context menu
上级
a19a0a6c
变更
6
隐藏空白更改
内联
并排
Showing
6 changed file
with
93 addition
and
24 deletion
+93
-24
src/vs/workbench/parts/preferences/browser/media/settingsEditor2.css
...bench/parts/preferences/browser/media/settingsEditor2.css
+4
-0
src/vs/workbench/parts/preferences/browser/settingsEditor2.ts
...vs/workbench/parts/preferences/browser/settingsEditor2.ts
+23
-8
src/vs/workbench/parts/preferences/browser/settingsTree.ts
src/vs/workbench/parts/preferences/browser/settingsTree.ts
+47
-14
src/vs/workbench/parts/preferences/browser/settingsTreeModels.ts
...workbench/parts/preferences/browser/settingsTreeModels.ts
+1
-1
src/vs/workbench/parts/preferences/common/preferences.ts
src/vs/workbench/parts/preferences/common/preferences.ts
+1
-0
src/vs/workbench/parts/preferences/electron-browser/preferences.contribution.ts
.../preferences/electron-browser/preferences.contribution.ts
+17
-1
未找到文件。
src/vs/workbench/parts/preferences/browser/media/settingsEditor2.css
浏览文件 @
0b8e2084
...
...
@@ -160,6 +160,10 @@
display
:
flex
;
}
.settings-editor
>
.settings-body
.settings-tree-container
.monaco-tree-row
.setting-item.focused
.monaco-toolbar
{
display
:
flex
;
}
.settings-editor
>
.settings-body
.settings-tree-container
.monaco-toolbar
.toolbar-toggle-more
{
display
:
block
;
width
:
22px
;
...
...
src/vs/workbench/parts/preferences/browser/settingsEditor2.ts
浏览文件 @
0b8e2084
...
...
@@ -186,6 +186,23 @@ export class SettingsEditor2 extends BaseEditor {
}
}
showContextMenu
():
void
{
const
settingDOMElement
=
this
.
settingsTreeRenderer
.
getSettingDOMElementForDOMElement
(
<
HTMLElement
>
document
.
activeElement
);
if
(
!
settingDOMElement
)
{
return
;
}
const
focusedKey
=
this
.
settingsTreeRenderer
.
getKeyForDOMElementInSetting
(
settingDOMElement
);
if
(
!
focusedKey
)
{
return
;
}
const
elements
=
this
.
currentSettingsModel
.
getElementsByName
(
focusedKey
);
if
(
elements
&&
elements
[
0
])
{
this
.
settingsTreeRenderer
.
showContextMenu
(
elements
[
0
],
settingDOMElement
);
}
}
focusSearch
():
void
{
this
.
searchWidget
.
focus
();
}
...
...
@@ -275,12 +292,8 @@ export class SettingsEditor2 extends BaseEditor {
this
.
toolbar
.
context
=
<
ISettingsToolbarContext
>
{
target
:
this
.
settingsTargetsWidget
.
settingsTarget
};
}
private
getElementsByKey
(
settingKey
:
string
):
SettingsTreeSettingElement
[]
|
null
{
return
this
.
currentSettingsModel
.
getElementByName
(
settingKey
);
}
private
revealSettingByKey
(
settingKey
:
string
):
void
{
const
elements
=
this
.
getElementsByKey
(
settingKey
);
const
elements
=
this
.
currentSettingsModel
.
getElementsByName
(
settingKey
);
if
(
elements
&&
elements
[
0
])
{
this
.
settingsTree
.
reveal
(
elements
[
0
]);
...
...
@@ -413,7 +426,9 @@ export class SettingsEditor2 extends BaseEditor {
});
}));
this
.
_register
(
this
.
settingsTreeRenderer
.
onDidClickSettingLink
(
settingName
=>
this
.
revealSettingByKey
(
settingName
)));
this
.
_register
(
this
.
settingsTreeRenderer
.
onDidFocusSetting
(
element
=>
this
.
settingsTree
.
reveal
(
element
)));
this
.
_register
(
this
.
settingsTreeRenderer
.
onDidFocusSetting
(
element
=>
{
this
.
settingsTree
.
reveal
(
element
);
}));
this
.
settingsTree
=
this
.
_register
(
this
.
instantiationService
.
createInstance
(
SettingsTree
,
this
.
settingsTreeContainer
,
...
...
@@ -696,7 +711,7 @@ export class SettingsEditor2 extends BaseEditor {
let
refreshP
:
TPromise
<
any
>
;
if
(
key
)
{
const
elements
=
this
.
getElementsByKey
(
key
);
const
elements
=
this
.
currentSettingsModel
.
getElementsByName
(
key
);
if
(
elements
&&
elements
.
length
)
{
refreshP
=
TPromise
.
join
(
elements
.
map
(
e
=>
this
.
settingsTree
.
refresh
(
e
)));
}
else
{
...
...
@@ -714,7 +729,7 @@ export class SettingsEditor2 extends BaseEditor {
}
private
updateModifiedLabelForKey
(
key
:
string
):
void
{
const
dataElements
=
this
.
getElementsByKey
(
key
);
const
dataElements
=
this
.
currentSettingsModel
.
getElementsByName
(
key
);
const
isModified
=
dataElements
&&
dataElements
[
0
]
&&
dataElements
[
0
].
isConfigured
;
// all elements are either configured or not
const
elements
=
this
.
settingsTreeRenderer
.
getDOMElementsForSettingKey
(
this
.
settingsTree
.
getHTMLElement
(),
key
);
if
(
elements
&&
elements
[
0
])
{
...
...
src/vs/workbench/parts/preferences/browser/settingsTree.ts
浏览文件 @
0b8e2084
...
...
@@ -7,10 +7,13 @@ import * as DOM from 'vs/base/browser/dom';
import
{
renderMarkdown
}
from
'
vs/base/browser/htmlContentRenderer
'
;
import
{
StandardKeyboardEvent
}
from
'
vs/base/browser/keyboardEvent
'
;
import
{
IMouseEvent
}
from
'
vs/base/browser/mouseEvent
'
;
import
{
alert
as
ariaAlert
}
from
'
vs/base/browser/ui/aria/aria
'
;
import
{
Button
}
from
'
vs/base/browser/ui/button/button
'
;
import
{
Checkbox
}
from
'
vs/base/browser/ui/checkbox/checkbox
'
;
import
{
InputBox
}
from
'
vs/base/browser/ui/inputbox/inputBox
'
;
import
{
SelectBox
}
from
'
vs/base/browser/ui/selectBox/selectBox
'
;
import
{
ToolBar
}
from
'
vs/base/browser/ui/toolbar/toolbar
'
;
import
{
Action
,
IAction
}
from
'
vs/base/common/actions
'
;
import
*
as
arrays
from
'
vs/base/common/arrays
'
;
import
{
Color
,
RGBA
}
from
'
vs/base/common/color
'
;
import
{
onUnexpectedError
}
from
'
vs/base/common/errors
'
;
...
...
@@ -25,23 +28,20 @@ import { IAccessibilityProvider, IDataSource, IFilter, IRenderer as ITreeRendere
import
{
DefaultTreestyler
}
from
'
vs/base/parts/tree/browser/treeDefaults
'
;
import
{
Tree
}
from
'
vs/base/parts/tree/browser/treeImpl
'
;
import
{
localize
}
from
'
vs/nls
'
;
import
{
IClipboardService
}
from
'
vs/platform/clipboard/common/clipboardService
'
;
import
{
ICommandService
}
from
'
vs/platform/commands/common/commands
'
;
import
{
IConfigurationService
}
from
'
vs/platform/configuration/common/configuration
'
;
import
{
IContext
ViewService
,
IContextMenu
Service
}
from
'
vs/platform/contextview/browser/contextView
'
;
import
{
IContext
MenuService
,
IContextView
Service
}
from
'
vs/platform/contextview/browser/contextView
'
;
import
{
IInstantiationService
}
from
'
vs/platform/instantiation/common/instantiation
'
;
import
{
WorkbenchTreeController
}
from
'
vs/platform/list/browser/listService
'
;
import
{
IOpenerService
}
from
'
vs/platform/opener/common/opener
'
;
import
{
editorBackground
,
focusBorder
,
foreground
,
errorF
oreground
,
inputValidationErrorBackground
,
inputValidationErrorBorder
}
from
'
vs/platform/theme/common/colorRegistry
'
;
import
{
editorBackground
,
errorForeground
,
focusBorder
,
f
oreground
,
inputValidationErrorBackground
,
inputValidationErrorBorder
}
from
'
vs/platform/theme/common/colorRegistry
'
;
import
{
attachButtonStyler
,
attachInputBoxStyler
,
attachSelectBoxStyler
,
attachStyler
}
from
'
vs/platform/theme/common/styler
'
;
import
{
ICssStyleCollector
,
ITheme
,
IThemeService
,
registerThemingParticipant
}
from
'
vs/platform/theme/common/themeService
'
;
import
{
ITOCEntry
}
from
'
vs/workbench/parts/preferences/browser/settingsLayout
'
;
import
{
ISettingsEditorViewState
,
isExcludeSetting
,
SettingsTreeElement
,
SettingsTreeGroupElement
,
SettingsTreeNewExtensionsElement
,
SettingsTreeSettingElement
}
from
'
vs/workbench/parts/preferences/browser/settingsTreeModels
'
;
import
{
ExcludeSettingWidget
,
IExcludeDataItem
,
settingsHeaderForeground
,
settingsNumberInputBackground
,
settingsNumberInputBorder
,
settingsNumberInputForeground
,
settingsSelectBackground
,
settingsSelectBorder
,
settingsSelectForeground
,
settingsTextInputBackground
,
settingsTextInputBorder
,
settingsTextInputForeground
}
from
'
vs/workbench/parts/preferences/browser/settingsWidgets
'
;
import
{
ISetting
,
ISettingsGroup
}
from
'
vs/workbench/services/preferences/common/preferences
'
;
import
{
alert
as
ariaAlert
}
from
'
vs/base/browser/ui/aria/aria
'
;
import
{
ToolBar
}
from
'
vs/base/browser/ui/toolbar/toolbar
'
;
import
{
Action
,
IAction
}
from
'
vs/base/common/actions
'
;
import
{
IClipboardService
}
from
'
vs/platform/clipboard/common/clipboardService
'
;
const
$
=
DOM
.
$
;
...
...
@@ -328,6 +328,17 @@ export class SettingsRenderer implements ITreeRenderer {
];
}
showContextMenu
(
element
:
SettingsTreeSettingElement
,
settingDOMElement
:
HTMLElement
):
void
{
const
toolbarElement
:
HTMLElement
=
settingDOMElement
.
querySelector
(
'
.toolbar-toggle-more
'
);
if
(
toolbarElement
)
{
this
.
contextMenuService
.
showContextMenu
({
getActions
:
()
=>
TPromise
.
wrap
(
this
.
settingActions
),
getAnchor
:
()
=>
toolbarElement
,
getActionsContext
:
()
=>
element
});
}
}
updateWidth
(
width
:
number
):
void
{
if
(
this
.
lastRenderedWidth
!==
width
)
{
this
.
rowHeightCache
=
new
Map
<
string
,
number
>
();
...
...
@@ -514,9 +525,7 @@ export class SettingsRenderer implements ITreeRenderer {
const
toDispose
=
[];
const
toolbar
=
new
ToolBar
(
container
,
this
.
contextMenuService
,
{});
toolbar
.
setActions
([],
this
.
settingActions
)();
toDispose
.
push
(
toolbar
);
const
toolbar
=
this
.
renderSettingToolbar
(
container
);
const
template
:
ISettingItemTemplate
=
{
toDispose
,
...
...
@@ -545,11 +554,21 @@ export class SettingsRenderer implements ITreeRenderer {
}
private
addSettingElementFocusHandler
(
template
:
ISettingItemTemplate
):
void
{
template
.
toDispose
.
push
(
DOM
.
addDisposableListener
(
template
.
containerElement
,
'
focus
'
,
e
=>
{
const
focusTracker
=
DOM
.
trackFocus
(
template
.
containerElement
);
template
.
toDispose
.
push
(
focusTracker
);
focusTracker
.
onDidBlur
(()
=>
{
if
(
template
.
containerElement
.
classList
.
contains
(
'
focused
'
))
{
template
.
containerElement
.
classList
.
remove
(
'
focused
'
);
}
});
focusTracker
.
onDidFocus
(()
=>
{
template
.
containerElement
.
classList
.
add
(
'
focused
'
);
if
(
template
.
context
)
{
this
.
_onDidFocusSetting
.
fire
(
template
.
context
);
}
}
,
true
)
);
});
}
private
renderSettingTextTemplate
(
tree
:
ITree
,
container
:
HTMLElement
,
type
=
'
text
'
):
ISettingTextItemTemplate
{
...
...
@@ -614,6 +633,17 @@ export class SettingsRenderer implements ITreeRenderer {
return
template
;
}
private
renderSettingToolbar
(
container
:
HTMLElement
):
ToolBar
{
const
toolbar
=
new
ToolBar
(
container
,
this
.
contextMenuService
,
{});
toolbar
.
setActions
([],
this
.
settingActions
)();
const
button
=
container
.
querySelector
(
'
.toolbar-toggle-more
'
);
if
(
button
)
{
(
<
HTMLElement
>
button
).
tabIndex
=
-
1
;
}
return
toolbar
;
}
private
renderSettingBoolTemplate
(
tree
:
ITree
,
container
:
HTMLElement
):
ISettingBoolItemTemplate
{
DOM
.
addClass
(
container
,
'
setting-item
'
);
DOM
.
addClass
(
container
,
'
setting-item-bool
'
);
...
...
@@ -639,9 +669,7 @@ export class SettingsRenderer implements ITreeRenderer {
}
}));
checkbox
.
domNode
.
classList
.
add
(
SettingsRenderer
.
CONTROL_CLASS
);
const
toolbar
=
new
ToolBar
(
container
,
this
.
contextMenuService
,
{});
toolbar
.
setActions
([],
this
.
settingActions
)();
const
toolbar
=
this
.
renderSettingToolbar
(
container
);
toDispose
.
push
(
toolbar
);
const
template
:
ISettingBoolItemTemplate
=
{
...
...
@@ -853,6 +881,11 @@ export class SettingsRenderer implements ITreeRenderer {
return
treeContainer
.
querySelectorAll
(
`[
${
SettingsRenderer
.
SETTING_KEY_ATTR
}
="
${
key
}
"]`
);
}
public
getKeyForDOMElementInSetting
(
element
:
HTMLElement
):
string
{
const
settingElement
=
this
.
getSettingDOMElementForDOMElement
(
element
);
return
settingElement
&&
settingElement
.
getAttribute
(
SettingsRenderer
.
SETTING_KEY_ATTR
);
}
private
renderSettingElement
(
tree
:
ITree
,
element
:
SettingsTreeSettingElement
,
templateId
:
string
,
template
:
ISettingItemTemplate
|
ISettingBoolItemTemplate
):
void
{
template
.
context
=
element
;
template
.
toolbar
.
context
=
element
;
...
...
src/vs/workbench/parts/preferences/browser/settingsTreeModels.ts
浏览文件 @
0b8e2084
...
...
@@ -210,7 +210,7 @@ export class SettingsTreeModel {
return
this
.
_treeElementsById
.
get
(
id
);
}
getElementByName
(
name
:
string
):
SettingsTreeSettingElement
[]
{
getElement
s
ByName
(
name
:
string
):
SettingsTreeSettingElement
[]
{
return
this
.
_treeElementsBySettingName
.
get
(
name
);
}
...
...
src/vs/workbench/parts/preferences/common/preferences.ts
浏览文件 @
0b8e2084
...
...
@@ -75,6 +75,7 @@ export const SETTINGS_EDITOR_COMMAND_FOCUS_FILE = 'settings.action.focusSettings
export
const
SETTINGS_EDITOR_COMMAND_EDIT_FOCUSED_SETTING
=
'
settings.action.editFocusedSetting
'
;
export
const
SETTINGS_EDITOR_COMMAND_FOCUS_SETTINGS_FROM_SEARCH
=
'
settings.action.focusSettingsFromSearch
'
;
export
const
SETTINGS_EDITOR_COMMAND_FOCUS_SETTINGS_LIST
=
'
settings.action.focusSettingsList
'
;
export
const
SETTINGS_EDITOR_COMMAND_SHOW_CONTEXT_MENU
=
'
settings.action.showContextMenu
'
;
export
const
KEYBINDINGS_EDITOR_COMMAND_SEARCH
=
'
keybindings.editor.searchKeybindings
'
;
export
const
KEYBINDINGS_EDITOR_COMMAND_CLEAR_SEARCH_RESULTS
=
'
keybindings.editor.clearSearchResults
'
;
...
...
src/vs/workbench/parts/preferences/electron-browser/preferences.contribution.ts
浏览文件 @
0b8e2084
...
...
@@ -22,7 +22,7 @@ import { KeybindingsEditor } from 'vs/workbench/parts/preferences/browser/keybin
import
{
OpenDefaultKeybindingsFileAction
,
OpenRawDefaultSettingsAction
,
OpenSettingsAction
,
OpenGlobalSettingsAction
,
OpenGlobalKeybindingsFileAction
,
OpenWorkspaceSettingsAction
,
OpenFolderSettingsAction
,
ConfigureLanguageBasedSettingsAction
,
OPEN_FOLDER_SETTINGS_COMMAND
,
OpenGlobalKeybindingsAction
,
OpenSettings2Action
,
OpenSettingsJsonAction
}
from
'
vs/workbench/parts/preferences/browser/preferencesActions
'
;
import
{
IKeybindingsEditor
,
IPreferencesSearchService
,
CONTEXT_KEYBINDING_FOCUS
,
CONTEXT_KEYBINDINGS_EDITOR
,
CONTEXT_KEYBINDINGS_SEARCH_FOCUS
,
KEYBINDINGS_EDITOR_COMMAND_DEFINE
,
KEYBINDINGS_EDITOR_COMMAND_REMOVE
,
KEYBINDINGS_EDITOR_COMMAND_SEARCH
,
KEYBINDINGS_EDITOR_COMMAND_COPY
,
KEYBINDINGS_EDITOR_COMMAND_RESET
,
KEYBINDINGS_EDITOR_COMMAND_COPY_COMMAND
,
KEYBINDINGS_EDITOR_COMMAND_SHOW_SIMILAR
,
KEYBINDINGS_EDITOR_COMMAND_FOCUS_KEYBINDINGS
,
KEYBINDINGS_EDITOR_COMMAND_CLEAR_SEARCH_RESULTS
,
SETTINGS_EDITOR_COMMAND_SEARCH
,
CONTEXT_SETTINGS_EDITOR
,
SETTINGS_EDITOR_COMMAND_FOCUS_FILE
,
CONTEXT_SETTINGS_SEARCH_FOCUS
,
SETTINGS_EDITOR_COMMAND_CLEAR_SEARCH_RESULTS
,
SETTINGS_EDITOR_COMMAND_FOCUS_NEXT_SETTING
,
SETTINGS_EDITOR_COMMAND_FOCUS_PREVIOUS_SETTING
,
SETTINGS_EDITOR_COMMAND_EDIT_FOCUSED_SETTING
,
SETTINGS_EDITOR_COMMAND_FOCUS_SETTINGS_FROM_SEARCH
,
CONTEXT_TOC_ROW_FOCUS
,
SETTINGS_EDITOR_COMMAND_FOCUS_SETTINGS_LIST
KEYBINDINGS_EDITOR_COMMAND_COPY
,
KEYBINDINGS_EDITOR_COMMAND_RESET
,
KEYBINDINGS_EDITOR_COMMAND_COPY_COMMAND
,
KEYBINDINGS_EDITOR_COMMAND_SHOW_SIMILAR
,
KEYBINDINGS_EDITOR_COMMAND_FOCUS_KEYBINDINGS
,
KEYBINDINGS_EDITOR_COMMAND_CLEAR_SEARCH_RESULTS
,
SETTINGS_EDITOR_COMMAND_SEARCH
,
CONTEXT_SETTINGS_EDITOR
,
SETTINGS_EDITOR_COMMAND_FOCUS_FILE
,
CONTEXT_SETTINGS_SEARCH_FOCUS
,
SETTINGS_EDITOR_COMMAND_CLEAR_SEARCH_RESULTS
,
SETTINGS_EDITOR_COMMAND_FOCUS_NEXT_SETTING
,
SETTINGS_EDITOR_COMMAND_FOCUS_PREVIOUS_SETTING
,
SETTINGS_EDITOR_COMMAND_EDIT_FOCUSED_SETTING
,
SETTINGS_EDITOR_COMMAND_FOCUS_SETTINGS_FROM_SEARCH
,
CONTEXT_TOC_ROW_FOCUS
,
SETTINGS_EDITOR_COMMAND_FOCUS_SETTINGS_LIST
,
SETTINGS_EDITOR_COMMAND_SHOW_CONTEXT_MENU
}
from
'
vs/workbench/parts/preferences/common/preferences
'
;
import
{
IInstantiationService
,
ServicesAccessor
}
from
'
vs/platform/instantiation/common/instantiation
'
;
import
{
IWorkbenchContributionsRegistry
,
Extensions
as
WorkbenchExtensions
}
from
'
vs/workbench/common/contributions
'
;
...
...
@@ -470,6 +470,22 @@ const focusSettingsListCommand = new FocusSettingsListCommand({
});
focusSettingsListCommand
.
register
();
class
ShowContextMenuCommand
extends
SettingsCommand
{
public
runCommand
(
accessor
:
ServicesAccessor
,
args
:
any
):
void
{
const
preferencesEditor
=
this
.
getPreferencesEditor
(
accessor
);
if
(
preferencesEditor
instanceof
SettingsEditor2
)
{
preferencesEditor
.
showContextMenu
();
}
}
}
const
showContextMenuCommand
=
new
ShowContextMenuCommand
({
id
:
SETTINGS_EDITOR_COMMAND_SHOW_CONTEXT_MENU
,
precondition
:
ContextKeyExpr
.
and
(
CONTEXT_SETTINGS_EDITOR
),
kbOpts
:
{
primary
:
KeyMod
.
Shift
|
KeyCode
.
F9
,
weight
:
KeybindingWeight
.
WorkbenchContrib
}
});
showContextMenuCommand
.
register
();
// Preferences menu
MenuRegistry
.
appendMenuItem
(
MenuId
.
MenubarPreferencesMenu
,
{
...
...
编辑
预览
Markdown
is supported
0%
请重试
或
添加新附件
.
添加附件
取消
You are about to add
0
people
to the discussion. Proceed with caution.
先完成此消息的编辑!
取消
想要评论请
注册
或
登录