Rename to SymbolSorrtOrder for clarity

outlineSort is now symbolSortOrder

src/vs/platform/telemetry/common/telemetryUtils.ts

@@ -157,7 +157,7 @@ const configurationValueWhitelist = [
 	'breadcrumbs.enabled',
 	'breadcrumbs.filePath',
 	'breadcrumbs.symbolPath',
-	'breadcrumbs.outlineSort',
+	'breadcrumbs.symbolSortOrder',
 	'breadcrumbs.useQuickPick',
 	'explorer.openEditors.visible',
 	'extensions.autoUpdate',

src/vs/workbench/browser/parts/editor/breadcrumbs.ts

@@ -70,7 +70,7 @@ export abstract class BreadcrumbsConfig<T> {
 	static UseQuickPick = BreadcrumbsConfig._stub<boolean>('breadcrumbs.useQuickPick');
 	static FilePath = BreadcrumbsConfig._stub<'on' | 'off' | 'last'>('breadcrumbs.filePath');
 	static SymbolPath = BreadcrumbsConfig._stub<'on' | 'off' | 'last'>('breadcrumbs.symbolPath');
-	static OutlineSort = BreadcrumbsConfig._stub<'position' | 'name' | 'type'>('breadcrumbs.outlineSort');
+	static SymbolSortOrder = BreadcrumbsConfig._stub<'position' | 'name' | 'type'>('breadcrumbs.symbolSortOrder');
 	static FilterOnType = BreadcrumbsConfig._stub<boolean>('breadcrumbs.filterOnType');
 
 	static FileExcludes = BreadcrumbsConfig._stub<glob.IExpression>('files.exclude');
@@ -143,15 +143,15 @@ Registry.as<IConfigurationRegistry>(Extensions.Configuration).registerConfigurat
 				localize('symbolpath.last', "Only show the current symbol in the breadcrumbs view."),
 			]
 		},
-		'breadcrumbs.outlineSort': {
-			description: localize('outlineSort', "Controls how symbols are sorted in the breadcrumbs outline view."),
+		'breadcrumbs.symbolSortOrder': {
+			description: localize('symbolSortOrder', "Controls how symbols are sorted in the breadcrumbs outline view."),
 			type: 'string',
 			default: 'position',
 			enum: ['position', 'name', 'type'],
 			enumDescriptions: [
-				localize('outlineSort.position', "Show symbol outline in file position order."),
-				localize('outlineSort.name', "Show symbol outline in alphabetical order."),
-				localize('outlineSort.type', "Show symbol outline in symbol type order."),
+				localize('symbolSortOrder.position', "Show symbol outline in file position order."),
+				localize('symbolSortOrder.name', "Show symbol outline in alphabetical order."),
+				localize('symbolSortOrder.type', "Show symbol outline in symbol type order."),
 			]
 		},
 		// 'breadcrumbs.filterOnType': {

src/vs/workbench/browser/parts/editor/breadcrumbsPicker.ts

@@ -52,7 +52,7 @@ export abstract class BreadcrumbsPicker {
 	protected readonly _treeContainer: HTMLDivElement;
 	protected readonly _tree: HighlightingWorkbenchTree;
 	protected readonly _focus: dom.IFocusTracker;
-	protected readonly _outlineSort: BreadcrumbsConfig<'position' | 'name' | 'type'>;
+	protected readonly _symbolSortOrder: BreadcrumbsConfig<'position' | 'name' | 'type'>;
 	private _layoutInfo: ILayoutInfo;
 
 	private readonly _onDidPickElement = new Emitter<{ target: any, payload: any }>();
@@ -89,7 +89,7 @@ export abstract class BreadcrumbsPicker {
 		this._treeContainer.style.boxShadow = `0px 5px 8px ${this._themeService.getTheme().getColor(widgetShadow)}`;
 		this._domNode.appendChild(this._treeContainer);
 
-		this._outlineSort = BreadcrumbsConfig.OutlineSort.bindTo(this._configurationService);
+		this._symbolSortOrder = BreadcrumbsConfig.SymbolSortOrder.bindTo(this._configurationService);
 
 		const filterConfig = BreadcrumbsConfig.FilterOnType.bindTo(this._configurationService);
 		this._disposables.push(filterConfig);
@@ -147,7 +147,7 @@ export abstract class BreadcrumbsPicker {
 		this._onDidPickElement.dispose();
 		this._tree.dispose();
 		this._focus.dispose();
-		this._outlineSort.dispose();
+		this._symbolSortOrder.dispose();
 	}
 
 	setInput(input: any, maxHeight: number, width: number, arrowSize: number, arrowOffset: number): void {
@@ -483,7 +483,7 @@ export class BreadcrumbsOutlinePicker extends BreadcrumbsPicker {
 	}
 
 	private _getOutlineItemComparator(): OutlineItemCompareType {
-		switch (this._outlineSort.getValue()) {
+		switch (this._symbolSortOrder.getValue()) {
 			case 'name':
 				return OutlineItemCompareType.ByName;
 			case 'type':