fix(tdb/page): remove n^2 implementation of page defragment

source/libs/tdb/src/db/tdbPage.c

@@ -418,7 +418,6 @@ static int32_t tCellIdxCmprFn(const void *p1, const void *p2) {
   }
 }
 static int tdbPageDefragment(SPage *pPage) {
-#if 1
   int32_t nFree = TDB_PAGE_NFREE(pPage);
   int32_t nCell = TDB_PAGE_NCELLS(pPage);
 
@@ -449,62 +448,7 @@ static int tdbPageDefragment(SPage *pPage) {
   tdbOsFree(aCellIdx);
 
   ASSERT(pPage->pFreeEnd - pPage->pFreeStart == nFree);
-#else
-  int    nFree;
-  int    nCells;
-  SCell *pCell;
-  SCell *pNextCell;
-  SCell *pTCell;
-  int    szCell;
-  int    idx;
-  int    iCell;
-
-  nFree = TDB_PAGE_NFREE(pPage);
-  nCells = TDB_PAGE_NCELLS(pPage);
-
-  ASSERT(pPage->pFreeEnd - pPage->pFreeStart < nFree);
-
-  // Loop to compact the page content
-  // Here we use an O(n^2) algorithm to do the job since
-  // this is a low frequency job.
-  pNextCell = (u8 *)pPage->pPageFtr;
-  pCell = NULL;
-  for (iCell = 0;; iCell++) {
-    // compact over
-    if (iCell == nCells) {
-      pPage->pFreeEnd = pNextCell;
-      break;
-    }
 
-    for (int i = 0; i < nCells; i++) {
-      if (TDB_PAGE_CELL_OFFSET_AT(pPage, i) < pNextCell - pPage->pData) {
-        pTCell = TDB_PAGE_CELL_AT(pPage, i);
-        if (pCell == NULL || pCell < pTCell) {
-          pCell = pTCell;
-          idx = i;
-        }
-      } else {
-        continue;
-      }
-    }
-
-    ASSERT(pCell != NULL);
-
-    szCell = (*pPage->xCellSize)(pPage, pCell, 0, NULL, NULL);
-
-    ASSERT(pCell + szCell <= pNextCell);
-    if (pCell + szCell < pNextCell) {
-      memmove(pNextCell - szCell, pCell, szCell);
-    }
-
-    pCell = NULL;
-    pNextCell = pNextCell - szCell;
-    TDB_PAGE_CELL_OFFSET_AT_SET(pPage, idx, pNextCell - pPage->pData);
-  }
-
-  TDB_PAGE_CCELLS_SET(pPage, pPage->pFreeEnd - pPage->pData);
-  TDB_PAGE_FCELL_SET(pPage, 0);
-#endif
   return 0;
 }