Merge pull request #17561 from taosdata/szhou/fixbugs

fix: fix coverity scan errors

source/libs/function/src/functionMgt.c

@@ -330,7 +330,7 @@ static SFunctionNode* createFunction(const char* pName, SNodeList* pParameterLis
   if (NULL == pFunc) {
     return NULL;
   }
-  strcpy(pFunc->functionName, pName);
+  snprintf(pFunc->functionName, sizeof(pFunc->functionName), "%s", pName);
   pFunc->pParameterList = pParameterList;
   if (TSDB_CODE_SUCCESS != getFuncInfo(pFunc)) {
     pFunc->pParameterList = NULL;
@@ -408,10 +408,6 @@ static int32_t createMergeFunction(const SFunctionNode* pSrcFunc, const SFunctio
   if (TSDB_CODE_SUCCESS == code) {
     *pMergeFunc = pFunc;
   } else {
-    if (NULL != pFunc) {
-      pFunc->pParameterList = NULL;
-      nodesDestroyNode((SNode*)pFunc);
-    }
     nodesDestroyList(pParameterList);
   }
 

source/libs/function/src/tpercentile.c

@@ -96,16 +96,19 @@ double findOnlyResult(tMemBucket *pMemBucket) {
     }
 
     int32_t groupId = getGroupId(pMemBucket->numOfSlots, i, pMemBucket->times);
-    SArray *list = *(SArray **)taosHashGet(pMemBucket->groupPagesMap, &groupId, sizeof(groupId));
-    assert(list->size == 1);
+    SArray **pList = taosHashGet(pMemBucket->groupPagesMap, &groupId, sizeof(groupId));
+    if (pList != NULL)  {
+      SArray *list = *pList;
+      assert(list->size == 1);
 
-    int32_t   *pageId = taosArrayGet(list, 0);
-    SFilePage *pPage = getBufPage(pMemBucket->pBuffer, *pageId);
-    assert(pPage->num == 1);
+      int32_t   *pageId = taosArrayGet(list, 0);
+      SFilePage *pPage = getBufPage(pMemBucket->pBuffer, *pageId);
+      assert(pPage->num == 1);
 
-    double v = 0;
-    GET_TYPED_DATA(v, double, pMemBucket->type, pPage->data);
-    return v;
+      double v = 0;
+      GET_TYPED_DATA(v, double, pMemBucket->type, pPage->data);
+      return v;
+    }
   }
 
   return 0;