refactor: add modify schema logic in schemaless

source/client/src/clientSml.c

@@ -54,29 +54,31 @@ typedef enum {
 } ESchemaAction;
 
 typedef struct {
-  char sTableName[TSDB_TABLE_NAME_LEN];
-  SArray *tags;
-  SArray *fields;
+  const char    *sTableName;
+  int32_t       sTableNameLen;
+  SArray        *tags;
+  SArray        *fields;
 } SCreateSTableActionInfo;
 
 typedef struct {
-  char sTableName[TSDB_TABLE_NAME_LEN];
-  SSmlKv * field;
+  const char    *sTableName;
+  int32_t       sTableNameLen;
+  SSmlKv        *field;
 } SAlterSTableActionInfo;
 
 typedef struct {
-  ESchemaAction action;
+  ESchemaAction             action;
   union {
     SCreateSTableActionInfo createSTable;
-    SAlterSTableActionInfo alterSTable;
+    SAlterSTableActionInfo  alterSTable;
   };
 } SSchemaAction;
 
 typedef struct {
-  const char* measure;
-  const char* tags;
-  const char* cols;
-  const char* timestamp;
+  const char  *measure;
+  const char  *tags;
+  const char  *cols;
+  const char  *timestamp;
 
   int32_t measureLen;
   int32_t measureTagsLen;
@@ -189,47 +191,38 @@ static int32_t smlBuildInvalidDataMsg(SSmlMsgBuf* pBuf, const char *msg1, const
   return TSDB_CODE_SML_INVALID_DATA;
 }
 
-static int32_t smlGenerateSchemaAction(SSchema* pointColField, SHashObj* dbAttrHash, SArray* dbAttrArray, bool isTag, char sTableName[],
+static int32_t smlGenerateSchemaAction(SSchema* colField, SHashObj* colHash, SSmlKv* kv, bool isTag,
                                        SSchemaAction* action, bool* actionNeeded, SSmlHandle* info) {
-//  char fieldName[TSDB_COL_NAME_LEN] = {0};
-//  strcpy(fieldName, pointColField->name);
-//
-//  size_t* pDbIndex = taosHashGet(dbAttrHash, fieldName, strlen(fieldName));
-//  if (pDbIndex) {
-//    SSchema* dbAttr = taosArrayGet(dbAttrArray, *pDbIndex);
-//    assert(strcasecmp(dbAttr->name, pointColField->name) == 0);
-//    if (pointColField->type != dbAttr->type) {
-//      uError("SML:0x%"PRIx64" point type and db type mismatch. key: %s. point type: %d, db type: %d", info->id, pointColField->name,
-//               pointColField->type, dbAttr->type);
-//      return TSDB_CODE_TSC_INVALID_VALUE;
-//    }
-//
-//    if (IS_VAR_DATA_TYPE(pointColField->type) && (pointColField->bytes > dbAttr->bytes)) {
-//      if (isTag) {
-//        action->action = SCHEMA_ACTION_CHANGE_TAG_SIZE;
-//      } else {
-//        action->action = SCHEMA_ACTION_CHANGE_COLUMN_SIZE;
-//      }
-//      memset(&action->alterSTable, 0,  sizeof(SAlterSTableActionInfo));
-//      memcpy(action->alterSTable.sTableName, sTableName, TSDB_TABLE_NAME_LEN);
-//      action->alterSTable.field = pointColField;
-//      *actionNeeded = true;
-//    }
-//  } else {
-//    if (isTag) {
-//      action->action = SCHEMA_ACTION_ADD_TAG;
-//    } else {
-//      action->action = SCHEMA_ACTION_ADD_COLUMN;
-//    }
-//    memset(&action->alterSTable, 0, sizeof(SAlterSTableActionInfo));
-//    memcpy(action->alterSTable.sTableName, sTableName, TSDB_TABLE_NAME_LEN);
-//    action->alterSTable.field = pointColField;
-//    *actionNeeded = true;
-//  }
-//  if (*actionNeeded) {
-//    uDebug("SML:0x%" PRIx64 " generate schema action. column name: %s, action: %d", info->id, fieldName,
-//             action->action);
-//  }
+  uint16_t *index = taosHashGet(colHash, kv->key, kv->keyLen);
+  if (index) {
+    if (colField[*index].type != kv->type) {
+      uError("SML:0x%"PRIx64" point type and db type mismatch. key: %s. point type: %d, db type: %d", info->id, kv->key,
+             colField[*index].type, kv->type);
+      return TSDB_CODE_TSC_INVALID_VALUE;
+    }
+
+    if (IS_VAR_DATA_TYPE(colField[*index].type) && (colField[*index].bytes > kv->length)) {
+      if (isTag) {
+        action->action = SCHEMA_ACTION_CHANGE_TAG_SIZE;
+      } else {
+        action->action = SCHEMA_ACTION_CHANGE_COLUMN_SIZE;
+      }
+      action->alterSTable.field = kv;
+      *actionNeeded = true;
+    }
+  } else {
+    if (isTag) {
+      action->action = SCHEMA_ACTION_ADD_TAG;
+    } else {
+      action->action = SCHEMA_ACTION_ADD_COLUMN;
+    }
+    action->alterSTable.field = kv;
+    *actionNeeded = true;
+  }
+  if (*actionNeeded) {
+    uDebug("SML:0x%" PRIx64 " generate schema action. column name: %s, action: %d", info->id, colField->name,
+             action->action);
+  }
   return 0;
 }
 
@@ -240,7 +233,7 @@ static int32_t smlBuildColumnDescription(SSmlKv* field, char* buf, int32_t bufSi
   if (type == TSDB_DATA_TYPE_BINARY || type == TSDB_DATA_TYPE_NCHAR) {
     int32_t bytes = field->length;   // todo
     int out = snprintf(buf, bufSize,"`%s` %s(%d)",
-                       tname,tDataTypes[field->type].name, bytes);
+                       tname, tDataTypes[field->type].name, bytes);
     *outBytes = out;
   } else {
     int out = snprintf(buf, bufSize, "`%s` %s", tname, tDataTypes[type].name);
@@ -259,7 +252,7 @@ static int32_t smlApplySchemaAction(SSmlHandle* info, SSchemaAction* action) {
   uDebug("SML:0x%"PRIx64" apply schema action. action: %d", info->id, action->action);
   switch (action->action) {
     case SCHEMA_ACTION_ADD_COLUMN: {
-      int n = sprintf(result, "alter stable %s add column ", action->alterSTable.sTableName);
+      int n = snprintf(result, action->alterSTable.sTableNameLen + 1, "alter stable `%s` add column ", action->alterSTable.sTableName);
       smlBuildColumnDescription(action->alterSTable.field, result+n, capacity-n, &outBytes);
       TAOS_RES* res = taos_query(info->taos, result); //TODO async doAsyncQuery
       code = taos_errno(res);
@@ -282,7 +275,7 @@ static int32_t smlApplySchemaAction(SSmlHandle* info, SSchemaAction* action) {
       break;
     }
     case SCHEMA_ACTION_ADD_TAG: {
-      int n = sprintf(result, "alter stable %s add tag ", action->alterSTable.sTableName);
+      int n = snprintf(result, action->alterSTable.sTableNameLen + 1, "alter stable `%s` add tag ", action->alterSTable.sTableName);
       smlBuildColumnDescription(action->alterSTable.field,
                              result+n, capacity-n, &outBytes);
       TAOS_RES* res = taos_query(info->taos, result); //TODO async doAsyncQuery
@@ -306,7 +299,7 @@ static int32_t smlApplySchemaAction(SSmlHandle* info, SSchemaAction* action) {
       break;
     }
     case SCHEMA_ACTION_CHANGE_COLUMN_SIZE: {
-      int n = sprintf(result, "alter stable %s modify column ", action->alterSTable.sTableName);
+      int n = snprintf(result, action->alterSTable.sTableNameLen + 1, "alter stable `%s` modify column ", action->alterSTable.sTableName);
       smlBuildColumnDescription(action->alterSTable.field, result+n,
                              capacity-n, &outBytes);
       TAOS_RES* res = taos_query(info->taos, result); //TODO async doAsyncQuery
@@ -329,7 +322,7 @@ static int32_t smlApplySchemaAction(SSmlHandle* info, SSchemaAction* action) {
       break;
     }
     case SCHEMA_ACTION_CHANGE_TAG_SIZE: {
-      int n = sprintf(result, "alter stable %s modify tag ", action->alterSTable.sTableName);
+      int n = snprintf(result, action->alterSTable.sTableNameLen + 1, "alter stable `%s` modify tag ", action->alterSTable.sTableName);
       smlBuildColumnDescription(action->alterSTable.field, result+n,
                              capacity-n, &outBytes);
       TAOS_RES* res = taos_query(info->taos, result); //TODO async doAsyncQuery
@@ -352,7 +345,7 @@ static int32_t smlApplySchemaAction(SSmlHandle* info, SSchemaAction* action) {
       break;
     }
     case SCHEMA_ACTION_CREATE_STABLE: {
-      int n = sprintf(result, "create stable `%s` (", action->createSTable.sTableName);
+      int n = snprintf(result, action->createSTable.sTableNameLen + 1, "create stable `%s` (", action->createSTable.sTableName);
       char* pos = result + n; int freeBytes = capacity - n;
 
       SArray *cols = action->createSTable.fields;
@@ -408,6 +401,25 @@ static int32_t smlApplySchemaAction(SSmlHandle* info, SSchemaAction* action) {
   return code;
 }
 
+static int32_t smlProcessSchemaAction(SSmlHandle* info, SSchema* schemaField, SHashObj* schemaHash, SArray *cols, SSchemaAction* action, bool isTag){
+  int32_t code = TSDB_CODE_SUCCESS;
+  for (int j = 0; j < taosArrayGetSize(cols); ++j) {
+    SSmlKv* kv = taosArrayGet(cols, j);
+    bool actionNeeded = false;
+    code = smlGenerateSchemaAction(schemaField, schemaHash, kv, isTag, action, &actionNeeded, info);
+    if(code != TSDB_CODE_SUCCESS){
+      return code;
+    }
+    if (actionNeeded) {
+      code = smlApplySchemaAction(info, action);
+      if (code != TSDB_CODE_SUCCESS) {
+        return code;
+      }
+    }
+  }
+  return TSDB_CODE_SUCCESS;
+}
+
 static int32_t smlModifyDBSchemas(SSmlHandle* info) {
   int32_t code = 0;
 
@@ -427,27 +439,52 @@ static int32_t smlModifyDBSchemas(SSmlHandle* info) {
     code = catalogGetSTableMeta(info->pCatalog, info->taos->pAppInfo->pTransporter, &ep, &pName, &pTableMeta);
 
     if (code == TSDB_CODE_PAR_TABLE_NOT_EXIST || code == TSDB_CODE_MND_INVALID_STB) {
-      SSchemaAction schemaAction = { SCHEMA_ACTION_CREATE_STABLE, 0};
-      memcpy(schemaAction.createSTable.sTableName, superTable, superTableLen);
+      SSchemaAction schemaAction = { SCHEMA_ACTION_CREATE_STABLE, {0}};
+      schemaAction.createSTable.sTableName = superTable;
+      schemaAction.createSTable.sTableNameLen = superTableLen;
       schemaAction.createSTable.tags = sTableData->tags;
       schemaAction.createSTable.fields = sTableData->cols;
       code = smlApplySchemaAction(info, &schemaAction);
-      if (code != 0) {
+      if (code != TSDB_CODE_SUCCESS) {
         uError("SML:0x%"PRIx64" smlApplySchemaAction failed. can not create %s", info->id, schemaAction.createSTable.sTableName);
         return code;
       }
+      info->cost.numOfCreateSTables++;
+    }else if (code == TSDB_CODE_SUCCESS) {
+      SHashObj *hashTmp = taosHashInit(pTableMeta->tableInfo.numOfTags, taosGetDefaultHashFunction(TSDB_DATA_TYPE_BINARY), true, false);
+      for(uint16_t i = pTableMeta->tableInfo.numOfColumns; i < pTableMeta->tableInfo.numOfColumns + pTableMeta->tableInfo.numOfTags; i++){
+        taosHashPut(hashTmp, pTableMeta->schema[i].name, strlen(pTableMeta->schema[i].name), &i, SHORT_BYTES);
+      }
 
-      code = catalogGetSTableMeta(info->pCatalog, info->taos->pAppInfo->pTransporter, &ep, &pName, &pTableMeta);
-      if (code != 0) {
-        uError("SML:0x%"PRIx64" catalogGetSTableMeta failed. super table name %s", info->id, schemaAction.createSTable.sTableName);
+      SSchemaAction schemaAction = {0};
+      schemaAction.alterSTable.sTableName = superTable;
+      schemaAction.alterSTable.sTableNameLen = superTableLen;
+      code = smlProcessSchemaAction(info, pTableMeta->schema, hashTmp, sTableData->tags, &schemaAction, true);
+      if (code != TSDB_CODE_SUCCESS) {
+        taosHashCleanup(hashTmp);
+        return code;
+      }
+
+      taosHashClear(hashTmp);
+      for(uint16_t i = 0; i < pTableMeta->tableInfo.numOfColumns; i++){
+        taosHashPut(hashTmp, pTableMeta->schema[i].name, strlen(pTableMeta->schema[i].name), &i, SHORT_BYTES);
+      }
+      code = smlProcessSchemaAction(info, pTableMeta->schema, hashTmp, sTableData->cols, &schemaAction, false);
+      taosHashCleanup(hashTmp);
+      if (code != TSDB_CODE_SUCCESS) {
         return code;
       }
-      info->cost.numOfCreateSTables++;
-    }else if (code == TSDB_CODE_SUCCESS) {
     } else {
       uError("SML:0x%"PRIx64" load table meta error: %s", info->id, tstrerror(code));
       return code;
     }
+    if(pTableMeta) taosMemoryFree(pTableMeta);
+
+    code = catalogGetSTableMeta(info->pCatalog, info->taos->pAppInfo->pTransporter, &ep, &pName, &pTableMeta);
+    if (code != TSDB_CODE_SUCCESS) {
+      uError("SML:0x%"PRIx64" catalogGetSTableMeta failed. super table name %s", info->id, (char*)superTable);
+      return code;
+    }
     sTableData->tableMeta = pTableMeta;
 
     tableMetaSml = (SSmlSTableMeta**)taosHashIterate(info->superTables, tableMetaSml);

source/client/test/smlTest.cpp

@@ -505,6 +505,8 @@ TEST(testCase, smlProcess_influx_Test) {
   for (int i = 0; i < rowNum; ++i) {
     TAOS_ROW rows = taos_fetch_row(res);
   }
+  taos_free_result(res);
+  smlDestroyInfo(info);
 }
 
 // different types
@@ -530,245 +532,309 @@ TEST(testCase, smlParseLine_error_Test) {
   };
   int ret = smlProcess(info, (char **)sql, sizeof(sql)/sizeof(sql[0]));
   ASSERT_NE(ret, 0);
+  destroyRequest(request);
+  smlDestroyInfo(info);
 }
 
- TEST(testCase, smlGetTimestampLen_Test) {
-   uint8_t len = smlGetTimestampLen(0);
-   ASSERT_EQ(len, 1);
-
-   len = smlGetTimestampLen(1);
-   ASSERT_EQ(len, 1);
-
-   len = smlGetTimestampLen(10);
-   ASSERT_EQ(len, 2);
-
-   len = smlGetTimestampLen(390);
-   ASSERT_EQ(len, 3);
-
-   len = smlGetTimestampLen(-1);
-   ASSERT_EQ(len, 1);
-
-   len = smlGetTimestampLen(-10);
-   ASSERT_EQ(len, 2);
-
-   len = smlGetTimestampLen(-390);
-   ASSERT_EQ(len, 3);
- }
-
- TEST(testCase, smlProcess_telnet_Test) {
-   TAOS *taos = taos_connect("localhost", "root", "taosdata", NULL, 0);
-   ASSERT_NE(taos, nullptr);
-
-   TAOS_RES* pRes = taos_query(taos, "create database if not exists sml_db");
-   taos_free_result(pRes);
-
-   pRes = taos_query(taos, "use sml_db");
-   taos_free_result(pRes);
-
-   SRequestObj *request = (SRequestObj *)createRequest((STscObj*)taos, NULL, NULL, TSDB_SQL_INSERT);
-   ASSERT_NE(request, nullptr);
-
-   SSmlHandle *info = smlBuildSmlInfo(taos, request, TSDB_SML_TELNET_PROTOCOL, TSDB_SML_TIMESTAMP_NANO_SECONDS, true);
-   ASSERT_NE(info, nullptr);
-
-   const char *sql[4] = {
-       "sys.if.bytes.out 1479496100 1.3E0 host=web01 interface=eth0",
-       "sys.if.bytes.out 1479496101 1.3E1 interface=eth0 host=web01 ",
-       "sys.if.bytes.out 1479496102 1.3E3 network=tcp",
-       "sys.procs.running 1479496100 42 host=web01"
-   };
-   int ret = smlProcess(info, (char**)sql, sizeof(sql)/sizeof(sql[0]));
-   ASSERT_EQ(ret, 0);
-
-   TAOS_RES *res = taos_query(taos, "select * from t_8c30283b3c4131a071d1e16cf6d7094a");
-   ASSERT_NE(res, nullptr);
-   int fieldNum = taos_field_count(res);
-   ASSERT_EQ(fieldNum, 2);
-   int rowNum = taos_affected_rows(res);
-   ASSERT_EQ(rowNum, 1);
-   for (int i = 0; i < rowNum; ++i) {
-     TAOS_ROW rows = taos_fetch_row(res);
-   }
-
-   res = taos_query(taos, "select * from t_6931529054e5637ca92c78a1ad441961");
-   ASSERT_NE(res, nullptr);
-   fieldNum = taos_field_count(res);
-   ASSERT_EQ(fieldNum, 2);
-   rowNum = taos_affected_rows(res);
-   ASSERT_EQ(rowNum, 2);
-   for (int i = 0; i < rowNum; ++i) {
-     TAOS_ROW rows = taos_fetch_row(res);
-   }
- }
-
- TEST(testCase, smlProcess_json_Test) {
-   TAOS *taos = taos_connect("localhost", "root", "taosdata", NULL, 0);
-   ASSERT_NE(taos, nullptr);
-
-   TAOS_RES* pRes = taos_query(taos, "create database if not exists sml_db");
-   taos_free_result(pRes);
-
-   pRes = taos_query(taos, "use sml_db");
-   taos_free_result(pRes);
-
-   SRequestObj *request = (SRequestObj *)createRequest((STscObj*)taos, NULL, NULL, TSDB_SQL_INSERT);
-   ASSERT_NE(request, nullptr);
-
-   SSmlHandle *info = smlBuildSmlInfo(taos, request, TSDB_SML_JSON_PROTOCOL, TSDB_SML_TIMESTAMP_NANO_SECONDS, true);
-   ASSERT_NE(info, nullptr);
-
-   const char *sql = "[\n"
-       "    {\n"
-       "        \"metric\": \"sys.cpu.nice\",\n"
-       "        \"timestamp\": 1346846400,\n"
-       "        \"value\": 18,\n"
-       "        \"tags\": {\n"
-       "           \"host\": \"web01\",\n"
-       "           \"dc\": \"lga\"\n"
-       "        }\n"
-       "    },\n"
-       "    {\n"
-       "        \"metric\": \"sys.cpu.nice\",\n"
-       "        \"timestamp\": 1346846400,\n"
-       "        \"value\": 9,\n"
-       "        \"tags\": {\n"
-       "           \"host\": \"web02\",\n"
-       "           \"dc\": \"lga\"\n"
-       "        }\n"
-       "    }\n"
-       "]";
-   int ret = smlProcess(info, (char**)(&sql), -1);
-   ASSERT_EQ(ret, 0);
-
-   TAOS_RES *res = taos_query(taos, "select * from t_cb27a7198d637b4f1c6464bd73f756a7");
-   ASSERT_NE(res, nullptr);
-   int fieldNum = taos_field_count(res);
-   ASSERT_EQ(fieldNum, 2);
-//   int rowNum = taos_affected_rows(res);
-//   ASSERT_EQ(rowNum, 1);
-//   for (int i = 0; i < rowNum; ++i) {
-//     TAOS_ROW rows = taos_fetch_row(res);
-//   }
-
-   sql = "{\n"
-       "    \"metric\": \"meter_current\",\n"
-       "    \"timestamp\": {\n"
-       "        \"value\"  : 1346846400,\n"
-       "        \"type\"   : \"s\"\n"
-       "    },\n"
-       "    \"value\": {\n"
-       "         \"value\" : 10.3,\n"
-       "         \"type\"  : \"i64\"\n"
-       "    },\n"
-       "    \"tags\": {\n"
-       "       \"groupid\": { \n"
-       "           \"value\" : 2,\n"
-       "           \"type\"  : \"bigint\"\n"
-       "       },\n"
-       "       \"location\": { \n"
-       "           \"value\" : \"北京\",\n"
-       "           \"type\"  : \"binary\"\n"
-       "       },\n"
-       "       \"id\": \"d1001\"\n"
-       "    }\n"
-       "}";
-   ret = smlProcess(info, (char**)(&sql), -1);
-   ASSERT_EQ(ret, 0);
-
-   sql = "{\n"
-       "    \"metric\": \"meter_current\",\n"
-       "    \"timestamp\": {\n"
-       "        \"value\"  : 1346846400,\n"
-       "        \"type\"   : \"s\"\n"
-       "    },\n"
-       "    \"value\": {\n"
-       "         \"value\" : 10.3,\n"
-       "         \"type\"  : \"i64\"\n"
-       "    },\n"
-       "    \"tags\": {\n"
-       "       \"t1\": { \n"
-       "           \"value\" : 2,\n"
-       "           \"type\"  : \"bigint\"\n"
-       "       },\n"
-       "       \"t2\": { \n"
-       "           \"value\" : 2,\n"
-       "           \"type\"  : \"int\"\n"
-       "       },\n"
-       "       \"t3\": { \n"
-       "           \"value\" : 2,\n"
-       "           \"type\"  : \"i16\"\n"
-       "       },\n"
-       "       \"t4\": { \n"
-       "           \"value\" : 2,\n"
-       "           \"type\"  : \"i8\"\n"
-       "       },\n"
-       "       \"t5\": { \n"
-       "           \"value\" : 2,\n"
-       "           \"type\"  : \"f32\"\n"
-       "       },\n"
-       "       \"t6\": { \n"
-       "           \"value\" : 2,\n"
-       "           \"type\"  : \"double\"\n"
-       "       },\n"
-       "       \"t7\": { \n"
-       "           \"value\" : \"8323\",\n"
-       "           \"type\"  : \"binary\"\n"
-       "       },\n"
-       "       \"t8\": { \n"
-       "           \"value\" : \"北京\",\n"
-       "           \"type\"  : \"binary\"\n"
-       "       },\n"
-       "       \"t9\": { \n"
-       "           \"value\" : true,\n"
-       "           \"type\"  : \"bool\"\n"
-       "       },\n"
-       "       \"id\": \"d1001\"\n"
-       "    }\n"
-       "}";
-   ret = smlProcess(info, (char**)(&sql), -1);
-   ASSERT_EQ(ret, 0);
-
-   sql = "{\n"
-       "    \"metric\": \"meter_current\",\n"
-       "    \"timestamp\": {\n"
-       "        \"value\"  : 1346846400000,\n"
-       "        \"type\"   : \"ms\"\n"
-       "    },\n"
-       "    \"value\": \"ni\",\n"
-       "    \"tags\": {\n"
-       "       \"t1\": { \n"
-       "           \"value\" : 20,\n"
-       "           \"type\"  : \"i64\"\n"
-       "       },\n"
-       "       \"t2\": { \n"
-       "           \"value\" : 25,\n"
-       "           \"type\"  : \"i32\"\n"
-       "       },\n"
-       "       \"t3\": { \n"
-       "           \"value\" : 2,\n"
-       "           \"type\"  : \"smallint\"\n"
-       "       },\n"
-       "       \"t4\": { \n"
-       "           \"value\" : 2,\n"
-       "           \"type\"  : \"tinyint\"\n"
-       "       },\n"
-       "       \"t5\": { \n"
-       "           \"value\" : 2,\n"
-       "           \"type\"  : \"float\"\n"
-       "       },\n"
-       "       \"t6\": { \n"
-       "           \"value\" : 0.2,\n"
-       "           \"type\"  : \"f64\"\n"
-       "       },\n"
-       "       \"t7\": \"nsj\",\n"
-       "       \"t8\": { \n"
-       "           \"value\" : \"北京\",\n"
-       "           \"type\"  : \"binary\"\n"
-       "       },\n"
-       "       \"t9\": false,\n"
-       "       \"id\": \"d1001\"\n"
-       "    }\n"
-       "}";
-   ret = smlProcess(info, (char**)(&sql), -1);
-   ASSERT_EQ(ret, 0);
- }
+TEST(testCase, smlGetTimestampLen_Test) {
+  uint8_t len = smlGetTimestampLen(0);
+  ASSERT_EQ(len, 1);
+
+  len = smlGetTimestampLen(1);
+  ASSERT_EQ(len, 1);
+
+  len = smlGetTimestampLen(10);
+  ASSERT_EQ(len, 2);
+
+  len = smlGetTimestampLen(390);
+  ASSERT_EQ(len, 3);
+
+  len = smlGetTimestampLen(-1);
+  ASSERT_EQ(len, 1);
+
+  len = smlGetTimestampLen(-10);
+  ASSERT_EQ(len, 2);
+
+  len = smlGetTimestampLen(-390);
+  ASSERT_EQ(len, 3);
+}
+
+TEST(testCase, smlProcess_telnet_Test) {
+  TAOS *taos = taos_connect("localhost", "root", "taosdata", NULL, 0);
+  ASSERT_NE(taos, nullptr);
+
+  TAOS_RES* pRes = taos_query(taos, "create database if not exists sml_db");
+  taos_free_result(pRes);
+
+  pRes = taos_query(taos, "use sml_db");
+  taos_free_result(pRes);
+
+  SRequestObj *request = (SRequestObj *)createRequest((STscObj*)taos, NULL, NULL, TSDB_SQL_INSERT);
+  ASSERT_NE(request, nullptr);
+
+  SSmlHandle *info = smlBuildSmlInfo(taos, request, TSDB_SML_TELNET_PROTOCOL, TSDB_SML_TIMESTAMP_NANO_SECONDS, true);
+  ASSERT_NE(info, nullptr);
+
+  const char *sql[4] = {
+     "sys.if.bytes.out 1479496100 1.3E0 host=web01 interface=eth0",
+     "sys.if.bytes.out 1479496101 1.3E1 interface=eth0 host=web01 ",
+     "sys.if.bytes.out 1479496102 1.3E3 network=tcp",
+     "sys.procs.running 1479496100 42 host=web01"
+  };
+  int ret = smlProcess(info, (char**)sql, sizeof(sql)/sizeof(sql[0]));
+  ASSERT_EQ(ret, 0);
+
+  TAOS_RES *res = taos_query(taos, "select * from t_8c30283b3c4131a071d1e16cf6d7094a");
+  ASSERT_NE(res, nullptr);
+  int fieldNum = taos_field_count(res);
+  ASSERT_EQ(fieldNum, 2);
+  int rowNum = taos_affected_rows(res);
+  ASSERT_EQ(rowNum, 1);
+  for (int i = 0; i < rowNum; ++i) {
+   TAOS_ROW rows = taos_fetch_row(res);
+  }
+  taos_free_result(pRes);
+
+  res = taos_query(taos, "select * from t_6931529054e5637ca92c78a1ad441961");
+  ASSERT_NE(res, nullptr);
+  fieldNum = taos_field_count(res);
+  ASSERT_EQ(fieldNum, 2);
+  rowNum = taos_affected_rows(res);
+  ASSERT_EQ(rowNum, 2);
+  for (int i = 0; i < rowNum; ++i) {
+   TAOS_ROW rows = taos_fetch_row(res);
+  }
+  taos_free_result(pRes);
+  smlDestroyInfo(info);
+}
+
+TEST(testCase, smlProcess_json1_Test) {
+  TAOS *taos = taos_connect("localhost", "root", "taosdata", NULL, 0);
+  ASSERT_NE(taos, nullptr);
+
+  TAOS_RES *pRes = taos_query(taos, "create database if not exists sml_db");
+  taos_free_result(pRes);
+
+  pRes = taos_query(taos, "use sml_db");
+  taos_free_result(pRes);
+
+  SRequestObj *request = (SRequestObj *)createRequest((STscObj *)taos, NULL, NULL, TSDB_SQL_INSERT);
+  ASSERT_NE(request, nullptr);
+
+  SSmlHandle *info = smlBuildSmlInfo(taos, request, TSDB_SML_JSON_PROTOCOL, TSDB_SML_TIMESTAMP_NANO_SECONDS, true);
+  ASSERT_NE(info, nullptr);
+
+  const char *sql =
+     "[\n"
+     "    {\n"
+     "        \"metric\": \"sys.cpu.nice\",\n"
+     "        \"timestamp\": 1346846400,\n"
+     "        \"value\": 18,\n"
+     "        \"tags\": {\n"
+     "           \"host\": \"web01\",\n"
+     "           \"dc\": \"lga\"\n"
+     "        }\n"
+     "    },\n"
+     "    {\n"
+     "        \"metric\": \"sys.cpu.nice\",\n"
+     "        \"timestamp\": 1346846400,\n"
+     "        \"value\": 9,\n"
+     "        \"tags\": {\n"
+     "           \"host\": \"web02\",\n"
+     "           \"dc\": \"lga\"\n"
+     "        }\n"
+     "    }\n"
+     "]";
+  int ret = smlProcess(info, (char **)(&sql), -1);
+  ASSERT_EQ(ret, 0);
+
+  TAOS_RES *res = taos_query(taos, "select * from t_cb27a7198d637b4f1c6464bd73f756a7");
+  ASSERT_NE(res, nullptr);
+  int fieldNum = taos_field_count(res);
+  ASSERT_EQ(fieldNum, 2);
+  //   int rowNum = taos_affected_rows(res);
+  //   ASSERT_EQ(rowNum, 1);
+  //   for (int i = 0; i < rowNum; ++i) {
+  //     TAOS_ROW rows = taos_fetch_row(res);
+  //   }
+  taos_free_result(pRes);
+  smlDestroyInfo(info);
+}
+
+TEST(testCase, smlProcess_json2_Test) {
+  TAOS *taos = taos_connect("localhost", "root", "taosdata", NULL, 0);
+  ASSERT_NE(taos, nullptr);
+
+  TAOS_RES *pRes = taos_query(taos, "create database if not exists sml_db");
+  taos_free_result(pRes);
+
+  pRes = taos_query(taos, "use sml_db");
+  taos_free_result(pRes);
+
+  SRequestObj *request = (SRequestObj *)createRequest((STscObj *)taos, NULL, NULL, TSDB_SQL_INSERT);
+  ASSERT_NE(request, nullptr);
+
+  SSmlHandle *info = smlBuildSmlInfo(taos, request, TSDB_SML_JSON_PROTOCOL, TSDB_SML_TIMESTAMP_NANO_SECONDS, true);
+  ASSERT_NE(info, nullptr);
+  const char *sql =
+     "{\n"
+     "    \"metric\": \"meter_current\",\n"
+     "    \"timestamp\": {\n"
+     "        \"value\"  : 1346846400,\n"
+     "        \"type\"   : \"s\"\n"
+     "    },\n"
+     "    \"value\": {\n"
+     "         \"value\" : 10.3,\n"
+     "         \"type\"  : \"i64\"\n"
+     "    },\n"
+     "    \"tags\": {\n"
+     "       \"groupid\": { \n"
+     "           \"value\" : 2,\n"
+     "           \"type\"  : \"bigint\"\n"
+     "       },\n"
+     "       \"location\": { \n"
+     "           \"value\" : \"北京\",\n"
+     "           \"type\"  : \"binary\"\n"
+     "       },\n"
+     "       \"id\": \"d1001\"\n"
+     "    }\n"
+     "}";
+  int32_t ret = smlProcess(info, (char **)(&sql), -1);
+  ASSERT_EQ(ret, 0);
+  taos_free_result(pRes);
+  smlDestroyInfo(info);
+}
+
+TEST(testCase, smlProcess_json3_Test) {
+  TAOS *taos = taos_connect("localhost", "root", "taosdata", NULL, 0);
+  ASSERT_NE(taos, nullptr);
+
+  TAOS_RES *pRes = taos_query(taos, "create database if not exists sml_db");
+  taos_free_result(pRes);
+
+  pRes = taos_query(taos, "use sml_db");
+  taos_free_result(pRes);
+
+  SRequestObj *request = (SRequestObj *)createRequest((STscObj *)taos, NULL, NULL, TSDB_SQL_INSERT);
+  ASSERT_NE(request, nullptr);
+
+  SSmlHandle *info = smlBuildSmlInfo(taos, request, TSDB_SML_JSON_PROTOCOL, TSDB_SML_TIMESTAMP_NANO_SECONDS, true);
+  ASSERT_NE(info, nullptr);
+  const char *sql =
+     "{\n"
+     "    \"metric\": \"meter_current\",\n"
+     "    \"timestamp\": {\n"
+     "        \"value\"  : 1346846400,\n"
+     "        \"type\"   : \"s\"\n"
+     "    },\n"
+     "    \"value\": {\n"
+     "         \"value\" : 10.3,\n"
+     "         \"type\"  : \"i64\"\n"
+     "    },\n"
+     "    \"tags\": {\n"
+     "       \"t1\": { \n"
+     "           \"value\" : 2,\n"
+     "           \"type\"  : \"bigint\"\n"
+     "       },\n"
+     "       \"t2\": { \n"
+     "           \"value\" : 2,\n"
+     "           \"type\"  : \"int\"\n"
+     "       },\n"
+     "       \"t3\": { \n"
+     "           \"value\" : 2,\n"
+     "           \"type\"  : \"i16\"\n"
+     "       },\n"
+     "       \"t4\": { \n"
+     "           \"value\" : 2,\n"
+     "           \"type\"  : \"i8\"\n"
+     "       },\n"
+     "       \"t5\": { \n"
+     "           \"value\" : 2,\n"
+     "           \"type\"  : \"f32\"\n"
+     "       },\n"
+     "       \"t6\": { \n"
+     "           \"value\" : 2,\n"
+     "           \"type\"  : \"double\"\n"
+     "       },\n"
+     "       \"t7\": { \n"
+     "           \"value\" : \"8323\",\n"
+     "           \"type\"  : \"binary\"\n"
+     "       },\n"
+     "       \"t8\": { \n"
+     "           \"value\" : \"北京\",\n"
+     "           \"type\"  : \"nchar\"\n"
+     "       },\n"
+     "       \"t9\": { \n"
+     "           \"value\" : true,\n"
+     "           \"type\"  : \"bool\"\n"
+     "       },\n"
+     "       \"id\": \"d1001\"\n"
+     "    }\n"
+     "}";
+  int32_t ret = smlProcess(info, (char **)(&sql), -1);
+  ASSERT_EQ(ret, 0);
+  taos_free_result(pRes);
+  smlDestroyInfo(info);
+}
+
+TEST(testCase, smlProcess_json4_Test) {
+  TAOS *taos = taos_connect("localhost", "root", "taosdata", NULL, 0);
+  ASSERT_NE(taos, nullptr);
+
+  TAOS_RES* pRes = taos_query(taos, "create database if not exists sml_db");
+  taos_free_result(pRes);
+
+  pRes = taos_query(taos, "use sml_db");
+  taos_free_result(pRes);
+
+  SRequestObj *request = (SRequestObj *)createRequest((STscObj*)taos, NULL, NULL, TSDB_SQL_INSERT);
+  ASSERT_NE(request, nullptr);
+
+  SSmlHandle *info = smlBuildSmlInfo(taos, request, TSDB_SML_JSON_PROTOCOL, TSDB_SML_TIMESTAMP_NANO_SECONDS, true);
+  ASSERT_NE(info, nullptr);
+  const char *sql = "{\n"
+     "    \"metric\": \"meter_current\",\n"
+     "    \"timestamp\": {\n"
+     "        \"value\"  : 1346846400000,\n"
+     "        \"type\"   : \"ms\"\n"
+     "    },\n"
+     "    \"value\": \"ni\",\n"
+     "    \"tags\": {\n"
+     "       \"t1\": { \n"
+     "           \"value\" : 20,\n"
+     "           \"type\"  : \"i64\"\n"
+     "       },\n"
+     "       \"t2\": { \n"
+     "           \"value\" : 25,\n"
+     "           \"type\"  : \"i32\"\n"
+     "       },\n"
+     "       \"t3\": { \n"
+     "           \"value\" : 2,\n"
+     "           \"type\"  : \"smallint\"\n"
+     "       },\n"
+     "       \"t4\": { \n"
+     "           \"value\" : 2,\n"
+     "           \"type\"  : \"tinyint\"\n"
+     "       },\n"
+     "       \"t5\": { \n"
+     "           \"value\" : 2,\n"
+     "           \"type\"  : \"float\"\n"
+     "       },\n"
+     "       \"t6\": { \n"
+     "           \"value\" : 0.2,\n"
+     "           \"type\"  : \"f64\"\n"
+     "       },\n"
+     "       \"t7\": \"nsj\",\n"
+     "       \"t8\": { \n"
+     "           \"value\" : \"北京\",\n"
+     "           \"type\"  : \"nchar\"\n"
+     "       },\n"
+     "       \"t9\": false,\n"
+     "       \"id\": \"d1001\"\n"
+     "    }\n"
+     "}";
+  int32_t ret = smlProcess(info, (char**)(&sql), -1);
+  ASSERT_EQ(ret, 0);
+  taos_free_result(pRes);
+  smlDestroyInfo(info);
+}